[Bug 1127339] New: kernel: efi: EFI_MEMMAP is not enabled
http://bugzilla.suse.com/show_bug.cgi?id=1127339 Bug ID: 1127339 Summary: kernel: efi: EFI_MEMMAP is not enabled Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Kubic Assignee: kubic-bugs@opensuse.org Reporter: mkravec@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- openQA: https://openqa.opensuse.org/tests/864184#step/journal_check/4 Please say if this error in log can be safely ignored
kernel: efi: EFI_MEMMAP is not enabled.
I noticed it on non-uefi jobs. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c3 --- Comment #3 from Takashi Iwai <tiwai@suse.com> --- Since it could be easily reproduced, I bisected. It leads to the commit 61f0d55569463a1af897117ff47d202b0ccb2e24 efi/esrt: Only call efi_mem_reserve() for boot services memory -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c4 --- Comment #4 from Takashi Iwai <tiwai@suse.com> --- Sorry, the bisection was incorrect. Now retrying... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c5 --- Comment #5 from Takashi Iwai <tiwai@suse.com> --- OK, the second try lead to the commit 38ac0287b7f4f3922e25fd8f81db67f2c13d16bb fbdev/efifb: Honour UEFI memory map attributes when mapping the FB This sounds more reasonable. It's the commit introducing the efi_mem_desc_lookup() check at efifb_probe(). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c6 --- Comment #6 from Takashi Iwai <tiwai@suse.com> --- ... and it means that the error message is harmless and nothing to worry much. The call efi_mem_desc_lookup() inspects whether the given area has been reserved, so it should be OK even if it's not reserved. The easiest "fix" would be to downgrade the message to pr_info*() or pr_debug*() instead of pr_err*(). Or we may add a flag not to spew errors, but I guess it's overkill. There are only a few places calling efi_mem_desc_lookup(). The other callers show the errors via pr_err() or err_warn() when an error is returned from the function, so showing an error in the function is almost superfluous. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c7 --- Comment #7 from Takashi Iwai <tiwai@suse.com> --- Created attachment 798559 --> http://bugzilla.suse.com/attachment.cgi?id=798559&action=edit Test fix patch -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c8 --- Comment #8 from Takashi Iwai <tiwai@suse.com> --- I submitted the patch to usptream. Let's see whether it's accepted. Then we can backport to TW kernel. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c9 --- Comment #9 from Takashi Iwai <tiwai@suse.com> --- (In reply to Takashi Iwai from comment #8)
I submitted the patch to usptream. Let's see whether it's accepted. Then we can backport to TW kernel.
This went on to an interesting discussion, and the upstream dev suggested a better fix. https://lkml.org/lkml/2019/3/1/303 Will check and backport once when it's merged to upstream. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kernel-maintainers@forge.pr |tiwai@suse.com |ovo.novell.com | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c10 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #798559|0 |1 is obsolete| | --- Comment #10 from Takashi Iwai <tiwai@suse.com> --- Created attachment 801843 --> http://bugzilla.suse.com/attachment.cgi?id=801843&action=edit Upstream fix patch -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1127339 http://bugzilla.suse.com/show_bug.cgi?id=1127339#c11 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Takashi Iwai <tiwai@suse.com> --- Now I pushed the upstream fix patch in the subsystem tree to stable branch. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1127339 https://bugzilla.suse.com/show_bug.cgi?id=1127339#c14 Martin Loviska <mloviska@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED CC| |mloviska@suse.com --- Comment #14 from Martin Loviska <mloviska@suse.com> --- Haven't been present in the latest runs. If no objections, I close this report. -- You are receiving this mail because: You are on the CC list for the bug.
participants (2)
-
bugzilla_noreply＠novell.com -
bugzilla_noreply＠suse.com