[Bug 1121829] libpng16 fails in make test on aarch64
http://bugzilla.suse.com/show_bug.cgi?id=1121829 http://bugzilla.suse.com/show_bug.cgi?id=1121829#c20 Petr Gajdos <pgajdos@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(guillaume.gardet@ | |arm.com) --- Comment #20 from Petr Gajdos <pgajdos@suse.com> --- I think they forgot to free png_ptr->riffled_palette on correct place. There is #ifdef PNG_READ_EXPANDED_SUPPORTED png_free(png_ptr, png_ptr->riffled_palette); png_ptr->riffled_palette = NULL; #endif in pngwrite.c nevertheless I have two doubts: 1. why the free is in pngwrite.c; the png_ptr->riffled_palette structure is allocated in png_do_read_transformations() from pngrtran.c and called only from pngread.c 2. why PNG_READ_EXPANDED_SUPPORTED is used in the preprocessor condition; the structure is allocated only only if PNG_ARM_NEON_INTRINSICS_AVAILABLE is defined and this is iff PNG_ARM_NEON_IMPLEMENTATION == 1. These two doubts resulted in https://build.opensuse.org/package/view_file/graphics/libpng16/libpng-arm-fr... and the build now succedes: https://build.opensuse.org/package/show/graphics/libpng16 However, upstream has to look at the patch more thoroughly. Guillaume, could you please forward it to Richard Townsend? -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com