http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c1 Stanislav Brabec <sbrabec@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED --- Comment #1 from Stanislav Brabec <sbrabec@suse.com> --- It requires another way to de-duplicate. fstrim -A works perfectly as long as fstab contains device names. If the source is specified by UUID=, then it fails to de-duplicate. Tested on this setup: Works: /dev/loop0 /mnt/1 btrfs defaults 0 0 /dev/loop0 /mnt/2 btrfs subvol=/subvol 0 0 /dev/loop0 /mnt/3 btrfs subvol=/subvol2 0 0 Broken: UUID=cb4cf1ab-b586-4980-bd7f-92422bc8f082 /mnt/1 btrfs defaults 0 0 UUID=cb4cf1ab-b586-4980-bd7f-92422bc8f082 /mnt/2 btrfs subvol=/subvol 0 0 UUID=cb4cf1ab-b586-4980-bd7f-92422bc8f082 /mnt/3 btrfs subvol=/subvol2 0 0 Additionally, /dev/root also needs testing (in case, when subvolumes use real device name). -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c2 Stanislav Brabec <sbrabec@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |IN_PROGRESS --- Comment #2 from Stanislav Brabec <sbrabec@suse.com> --- It looks like a logical error in the sys-utils/fstrim.c: fstrim_all(). De-duplication of items is performed too early. First it calls mnt_new_table_from_file(filename); In case of "fstrim -a", it reads /proc/self/mountinfo, in case of "fstrim -A", it reads /etc/fstab. But in case of source in the UUID= format, mnt_fs_get_srcpath(fs) returns NULL. On that table, de-duplication is called: mnt_table_uniq_fs(tab, MNT_UNIQ_FORWARD, uniq_fs_source_cmp); De-duplication by source is performed on unprocessed /etc/fstab, so de-duplication by source is not possible. One has to call: mnt_resolve_spec(mnt_fs_get_source(fs), cache); to resolve the source. It is really done, but after the de-duplication, just before calling fstrim_filesystem() itself. It is too late to de-duplicate. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c5 --- Comment #5 from Stanislav Brabec <sbrabec@suse.com> --- The de-duplication of fstab is more complicated than "fstrim -a", as it needs to evaluate tags, bind mounts, pseudo filesystems and everything else that "mount -a" does. Otherwise de-duplication can fail in many ways (use source specified by tags, subvolumes as source, bind mounts, false evaluation of pseudo or net filesystem path). The core of the path evaluation is implemented in mnt_context_prepare_srcpath(). But it is not possible to use it directly in fstrim. mnt_context_prepare_srcpath() uses libmnt_context structure, but the de-duplication functions mnt_table_uniq_fs() use libmnt_table and libmnt_fs. So there are several options to implement this: 1. Rewrite fstrim.c to use libmnt_context instead of libmnt_fs (libmnt_context is a superset of libmnt_fs), and then use mnt_context_prepare_srcpath() and then de-duplicate. 2. Use parts of mount_all() code to perform full parsing of fstab, and then fill table with evaluated and canonicalized srcpath. 3. Implement mnt_fs_prepare_srcpath() as a counterpart of mnt_context_prepare_srcpath(). 4. Create a temporary libmnt_context for performing the tag evaluation and canonicalization. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c7 --- Comment #7 from Stanislav Brabec <sbrabec@suse.com> --- It seems that use of mnt_context makes only a little sense for the rest of fstrim_all() (and for the rest of the fstrim, we don't need these structures at all). Additionally, we cannot use mnt_context_prepare_srcpath() anyway. In case of loop device inside fstab, it is going to initialize the loop device again, which would be pretty ugly, even if recent libmount has a loop dep-duplication code. It complicates 1. and 4. So 2. or 3. seems to be the best solution. I am trying to finish 3. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c18 --- Comment #18 from Andreas Schneider <asn@cryptomilk.org> --- Is this already fixed in Tumbleweed. I can't really find something in the changelog. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c21 ravas mi <ravas@tuta.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ravas@tuta.io --- Comment #21 from ravas mi <ravas@tuta.io> --- I just upgraded to 20190828, which included a util-linux update. Running fstrim -Av now shows /, /home and /boot/efi as being trimmed. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c23 --- Comment #23 from ravas mi <ravas@tuta.io> ---

"I suppose that you have these on 3 partitions."

Correct. Thank you for the substantial bug fix! -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |obs:running:11017:moderate -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 http://bugzilla.suse.com/show_bug.cgi?id=1127701#c25 --- Comment #25 from Swamp Workflow Management <swamp@suse.de> --- openSUSE-SU-2019:2121-1: An update that contains security fixes can now be installed. Category: security (moderate) Bug References: 1081947,1082293,1085196,1106214,1121197,1122417,1125886,1127701,1135534,1135708,1141113,353876 CVE References: Sources used: openSUSE Leap 15.1 (src): python3-libmount-2.33.1-lp151.3.3.2, shadow-4.6-lp151.2.3.2, util-linux-2.33.1-lp151.3.3.2, util-linux-systemd-2.33.1-lp151.3.3.2 -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1127701 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|obs:running:11017:moderate | -- You are receiving this mail because: You are on the CC list for the bug.