[Bug 714995] New: open-iscsi script does not properly umount iscsi devices
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c0 Summary: open-iscsi script does not properly umount iscsi devices Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: x86-64 OS/Version: openSUSE 11.4 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: thomas.saupe@novell.com QAContact: qa@suse.de Found By: Novell Technical Services Services Priority: 1000 Blocker: --- The code for umounting iscsi device in /etc/init.d/open-iscsi is broken, especially if the iscsi devices are used within multipathing. On system shutdown the umount of the mounted iscsi devices fails but the devices itself get logged out. This leads to a hang of the reboot, since the later the boot.localfs init script tries to umount the iscsi mounts that already have lost their devices. Attached a patch to the open-iscsi init script that corrects this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c1 --- Comment #1 from Thomas Saupe <thomas.saupe@novell.com> 2011-08-30 15:48:55 UTC --- Created an attachment (id=448446) --> (http://bugzilla.novell.com/attachment.cgi?id=448446) open-iscsi-umount.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c2 Thomas Saupe <thomas.saupe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #448446|0 |1 is obsolete| | --- Comment #2 from Thomas Saupe <thomas.saupe@novell.com> 2011-08-31 12:54:02 UTC --- Created an attachment (id=448680) --> (http://bugzilla.novell.com/attachment.cgi?id=448680) new patch sorry there was a litte mistake in the original patch attaching the corrected version -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c3 Thomas Saupe <thomas.saupe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #448680|0 |1 is obsolete| | --- Comment #3 from Thomas Saupe <thomas.saupe@novell.com> 2011-08-31 14:20:57 UTC --- Created an attachment (id=448700) --> (http://bugzilla.novell.com/attachment.cgi?id=448700) iscsi-multipath-patch Did a little more polishing on the patch to properly reflect the start and stop of multipathing for iscsi devices. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c zj jia <zjjia@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@suse.com AssignedTo|bnc-team-screening@forge.pr |hare@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c4 Dennis Olsson <D.Olsson@Netzwerk-Design.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |D.Olsson@Netzwerk-Design.de --- Comment #4 from Dennis Olsson <D.Olsson@Netzwerk-Design.de> 2011-09-28 18:31:06 CEST --- Sinec you are polishing the script, how about changing: cat /proc/mounts | sed -ne '/^\/dev\/.*/p' | while read d m t o x; do to the less resource demanding (one less process running) and even more readable: sed -ne '/^\/dev\/.*/p' /proc/mounts | while read d m t o x; do ?? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c5 Joseph Brown <joseph.brown@coaccess.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.brown@coaccess.com --- Comment #5 from Joseph Brown <joseph.brown@coaccess.com> 2011-10-28 17:45:42 UTC --- How do I apply the patch to the system? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c6 --- Comment #6 from Thomas Saupe <thomas.saupe@novell.com> 2011-10-31 09:11:12 UTC --- Dennis, thanks for the hint. Still I would prefer to wait for approval from the open-iscsi maintainer before going further here. Joseph, just do a: patch -p0 <iscsi-multipath-patch in order to apply it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c7 Per Jessen <per@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |per@opensuse.org --- Comment #7 from Per Jessen <per@opensuse.org> 2011-10-31 14:24:46 UTC --- I applied the patch and did a reboot - I saw the following during shutdown: hutting down service (remotefs) network . . . . . . . . .done <notice -- Oct 31 11:57:39.523000> service network-remotefs done basename: extra operand `target4:0:0/4:0:0:3/block/sdg' Try `basename --help' for more information. basename: extra operand `target4:0:0/4:0:0:3/block/sdg' Try `basename --help' for more information. basename: extra operand `target4:0:0/4:0:0:3/block/sdg' Try `basename --help' for more information. Oct 31 11:57:38 | DM multipath kernel driver not loaded -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c8 --- Comment #8 from Per Jessen <per@opensuse.org> 2011-10-31 14:35:41 UTC --- (In reply to comment #4)
Sinec you are polishing the script, how about changing:
cat /proc/mounts | sed -ne '/^\/dev\/.*/p' | while read d m t o x; do
to the less resource demanding (one less process running) and even more readable:
sed -ne '/^\/dev\/.*/p' /proc/mounts | while read d m t o x; do
How about grep ^/dev /proc/mounts | while read d m t o x; do -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c9 --- Comment #9 from Dennis Olsson <D.Olsson@Netzwerk-Design.de> 2011-11-01 15:25:08 CET --- (In reply to comment #8)
grep ^/dev /proc/mounts | while read d m t o x; do
Well, nice, except in order to keep the original search pattern (need "/" at end): grep ^/dev/ /proc/mounts | while read d m t o x; do -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c10 Thomas Saupe <thomas.saupe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #448700|0 |1 is obsolete| | --- Comment #10 from Thomas Saupe <thomas.saupe@novell.com> 2011-11-02 16:14:56 UTC --- Created an attachment (id=459966) --> (http://bugzilla.novell.com/attachment.cgi?id=459966) patch update Thanks for the hints and reports, updated the patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c11 --- Comment #11 from Per Jessen <per@opensuse.org> 2011-11-03 08:01:52 UTC --- Thanks Thomas - I'll test it again, but it'll have to wait a couple of days, my test system is running a long job. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c12 Thomas Saupe <thomas.saupe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #459966|0 |1 is obsolete| | --- Comment #12 from Thomas Saupe <thomas.saupe@novell.com> 2011-11-03 09:47:52 UTC --- Created an attachment (id=460140) --> (http://bugzilla.novell.com/attachment.cgi?id=460140) patch update2 One more correction to the patch. Thanks Per for pointing this out. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c13 Thomas Saupe <thomas.saupe@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #460140|0 |1 is obsolete| | --- Comment #13 from Thomas Saupe <thomas.saupe@novell.com> 2011-11-03 09:48:53 UTC --- Created an attachment (id=460141) --> (http://bugzilla.novell.com/attachment.cgi?id=460141) patch update2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c14 --- Comment #14 from Dennis Olsson <D.Olsson@Netzwerk-Design.de> 2011-11-03 16:57:38 CET --- Created an attachment (id=460273) --> (http://bugzilla.novell.com/attachment.cgi?id=460273) Another update of patch. Thomas, I had a go at you patch, but found that it did not like my mounts of e.g. loop devices (spitted out errors). So, I made a code review and rewrite and came up with this one. As I do not have multipath, I have not been able to test whether I have gotten it right with this part, but at least the patch now works with my setup using loops, LVM and iSCSI. I have not obsoleted your patch, as I do not know, whether you agree with my patch version. :-) Hope you like my patch suggestion, just as it would be nice, if you would test my patch in a multipath iSCSI environment. Many thanks in advance. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c15 --- Comment #15 from Thomas Saupe <thomas.saupe@novell.com> 2011-11-03 16:11:30 UTC --- Thanks for the update Dennis. It is hard to cover all setups, so any contribution is appreciated. I will test your patch. Per, you might also want to give it a try? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c16 --- Comment #16 from Per Jessen <per@opensuse.org> 2011-11-03 18:00:43 UTC --- One comment - the test for any "iscsi devices at all", isn't that superfluous? I mean, when this script is being run at startup or shutdown, we can assume that iscsi _is_ in use. Otherwise the script looks good, my first test showed no problems. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c17 --- Comment #17 from Dennis Olsson <D.Olsson@Netzwerk-Design.de> 2011-11-04 10:55:08 CET --- Reply to comment #15: Yes, I know - that was why I took the time to review / test / rewrite it. (Although, I have to admit, the real reason was that I did not really like the code, I was reading during the code review;-) Reply to comment #16: Hhhnmmmm, you are making a valid point. I originally added this test to Thomas' version of the patch, while it was throwing errors, when no iSCSI attachments were active, which is often the case when running the script manually during testing of the iSCSI setup. But, since then, I have completely rewritten the patch, so that this test is not strictly necessary any more - at least not for the original reasons.-) Now, it is only an optimization to avoid running through the entire mount points in case no iSCSI devices have been attached. So, strictly speaking the test is not necessary, but does come in handy, when running the script manually during testings.-) Have thus left it there. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c Petr Uzel <puzel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c19 Gregor Dschung <opensuse@dschung.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensuse@dschung.de OS/Version|openSUSE 11.4 |openSUSE 12.1 Severity|Normal |Major --- Comment #19 from Gregor Dschung <opensuse@dschung.de> 2012-08-03 10:30:41 UTC --- The issue is still present in openSUSE 12.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=714995 http://bugzilla.novell.com/show_bug.cgi?id=714995#c20 Petr Uzel <puzel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #20 from Petr Uzel <puzel@suse.com> --- I am sorry, but I was not able to find time to look into this bug. Now the affected openSUSE versions are no longer supported, so I will close this bug. If it can still be reproduced with current and supported openSUSE version, please reopen. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com