[Bug 1077145] New: [regression] osc build uses wrong changes file - openSUSE Bugs - openSUSE Mailing Lists

newer
[Bug 1070556] Kernel 4.14.1 bug...

[Bug 1077145] New: [regression] osc build uses wrong changes file

older
[Bug 1080332] yast-iplb does not...

bugzilla_noreply＠novell.com

23 Jan 2018 23 Jan '18

06:57

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 Bug ID: 1077145 Summary: [regression] osc build uses wrong changes file Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: All OS: openSUSE Factory Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: adrian@suse.com Reporter: bwiedemann@suse.com QA Contact: qa-bugs@suse.de CC: coolo@suse.com Found By: Development Blocker: --- I found this when working on reproducible builds for openSUSE. Regression occurring since at least 2018-01-19 Using the /usr/lib/build/changelog2spec script from build-20171128-278.1 from openSUSE:Tools repo When building packages like antlr openssh qemu python-pandas that have multiple .changes files sometimes the wrong one will end up in the resulting .src.rpm and binary rpms Steps To Reproduce: osc co openSUSE:Factory/antlr ; cd $_ time osc build --keep-pkg=test.2/ --noservice antlr.spec rpm -qp --changelog test.2/antlr-2.7.7-0.src.rpm|head -2 Actual Result: * Thu Dec 07 2017 dimstar@opensuse.org - Escape the usage of %{VERSION} when calling out to rpm. Expected Result: * Fri Jan 12 2018 tchvatal@suse.com - Add condition about python2 module, the rewrite happened in antlr4 Reproducible: Sometimes on another build host I got build-20171027 and could not reproduce the problem. -- You are receiving this mail because: You are on the CC list for the bug.

Attachments:

attachment.htm (text/html — 3.2 KB)

Reply

Sign in to reply online Use email software

Show replies by date

bugzilla_noreply＠novell.com

23 Jan 23 Jan

09:38

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c1 Bernhard Wiedemann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |seyfried@b1-systems.de --- Comment #1 from Bernhard Wiedemann --- I looked at the diff and this might have broken it: commit 393c490671d24ea188acfbbec5f62946aba8d12f Author: Stefan Seyfried Date: Wed Sep 6 16:31:44 2017 +0200 changelog2spec: prefer _service:.*:.*.changes without this,. "foo.changes" will be preferred over "_service:obs_scm:foo.changes" which means --generatechanges in obs_scm has no effect. but then I wonder why we even consider antlr-bootstrap.changes when building antlr.spec just because the 'antlr' string appears in the file name? because the name might have been _service:...:antlr.changes? I guess, we should use a more specific regexp in line 86 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

10:02

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c2 --- Comment #2 from Bernhard Wiedemann --- and now I noticed that the randomness comes from perl's randomized hash in line 81 as explained in https://github.com/bmwiedemann/theunreproduciblepackage/tree/master/hash so we need to have a sort after such hash (or not use hashes) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

10:34

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c3 --- Comment #3 from Bernhard Wiedemann --- There is already a partial fix in git: commit 797b060ca5020bb0dbc49682c082262a4bd340ad Author: Stefan Seyfried Date: Thu Nov 23 10:12:40 2017 +0100 changelog2spec: fix "multiple .changes files" case but nevertheless the moved sort is useless because map introduces randomness after it. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

12:24

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c4 Stefan Seyfried changed: What |Removed |Added ---------------------------------------------------------------------------- CC|seyfried@b1-systems.de |seife@novell.slipkontur.de --- Comment #4 from Stefan Seyfried --- it "worked for me", and tbh, I do not know too much about perl's internals, and when I read line 81 of current changelog2spec, my brain goes into suspend mode, and I turn to more rewarding problems. Anyway, something to this effect needs to be implemented in changelog2spec: if (just one .changes file is present) { use it and be done. } else if there_is("{*:,}$specname.changes") { if (more than one result) { prefer ("_service:*:$specname.changes") } else { use (result) } } else { # no $specname.changes, but maybe $specname-master.changes # more than one result, because already checked first prefer (service:*...) } maybe if it is really coded as verbose as my pseudocode, it would actually be maintainable in the future by someone besides mls :-) My two commits probably did not make anything worse than before, maybe they do not fix every case. well, without them it was reproducibly broken (wrong changes file used). Now it might be sometimes broken ;-) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

12:58

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c5 --- Comment #5 from Bernhard Wiedemann --- (In reply to Stefan Seyfried from comment #4)

My two commits probably did not make anything worse than before, maybe they do not fix every case.

actually, the first commit effectively dropped the sort, making things worse than before and the 2nd commit just fixed the case of foo-something.changes but not something-foo.changes (e.g. python-rpm / rpm) and also the intended effect of the first commit was about service generated .changes file and you only sometimes get that depending on hash randomization. In a certain sense 'always broken' is better than 'randomly broken' because you can catch it in testsuites. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

13:34

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c6 --- Comment #6 from Stefan Seyfried --- ok, then just revert my two commits. I'm not going to touch this code again :-) -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

13:36

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c7 --- Comment #7 from Stefan Seyfried --- server side source services are not really wanted or even working on public obs anyway, so the loss of functionality is not significant. I will carry local patches for my build service. -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

16:04

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c8 Bernhard Wiedemann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #8 from Bernhard Wiedemann --- I think, this fix should cover your use-case as well => see the included test coverage https://github.com/openSUSE/obs-build/pull/424 -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

bugzilla_noreply＠novell.com

9 Feb 9 Feb

16:57

New subject: [Bug 1077145] [regression] osc build uses wrong changes file

http://bugzilla.opensuse.org/show_bug.cgi?id=1077145 http://bugzilla.opensuse.org/show_bug.cgi?id=1077145#c11 Bernhard Wiedemann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #11 from Bernhard Wiedemann --- should be fixed now -- You are receiving this mail because: You are on the CC list for the bug.

Reply

Sign in to reply online Use email software

2276

Age (days ago)

2293

Last active (days ago)

Download

9 comments

1 participants

tags

participants (1)

bugzilla_noreply＠novell.com