[Bug 1231661] New: wget incorrectly truncate long file names
https://bugzilla.suse.com/show_bug.cgi?id=1231661 Bug ID: 1231661 Summary: wget incorrectly truncate long file names Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.6 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: screening-team-bugs@suse.de Reporter: osukup@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- wget on SLE-15/Leap 15 truncates names not based on name length but on length of whole patch. wget version 1.20.3 log example: ~~~ The name is too long, 257 chars total. Trying to shorten... New name is download.suse.de/ibs/SUSE:/ALP:/Products:/Marble:/6.0:/ToTest/product/repo/SL-Micro-6.0-x86_64/repodata/fd6a97967b76bd8a32e3045f048c3e126758a1dfd80a8c20aa9b3c45051c64252fc0e2a2d13d80bcdb60b0bcdfd234d39b4b3379d58e677ba4034b80836596aa-lic. --2024-10-14 08:04:47-- https://download.suse.de/ibs/SUSE:/ALP:/Products:/Marble:/6.0:/ToTest/produc... Connecting to download.suse.de (download.suse.de)|10.145.50.110|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 78097 (76K) [application/x-download] Saving to: ‘download.suse.de/ibs/SUSE:/ALP:/Products:/Marble:/6.0:/ToTest/product/repo/SL-Micro-6.0-x86_64/repodata/fd6a97967b76bd8a32e3045f048c3e126758a1dfd80a8c20aa9b3c45051c64252fc0e2a2d13d80bcdb60b0bcdfd234d39b4b3379d58e677ba4034b80836596aa-lic’ download.suse.de/ibs/SUSE:/ALP:/Products:/Marble:/6.0:/ToTest/product/repo/SL-Micro-6.0-x86_64/repodata/fd6a97967b76bd8a32e3045f048c3e126758a1dfd80a8c20aa9b3c45051c64252fc0e2a2d13d80bcdb60b0bcdfd234d39b4b3379d58e677ba4034b80836596aa-lic 0%[ ] 0 --.-KB/s download.suse.de/ibs/SUSE:/ALP:/Products:/Marble:/6.0:/ToTest/product/repo/SL-Micro-6.0-x86_64/repodata/fd6a97967b76bd8a32e3045f048c3e126758a1dfd80a8c20aa9b3c45051c64252fc0e2a2d13d80bcdb60b0bcdfd234d39b4b3379d58e677ba4034b80836596aa-lic 100%[=======================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================================>] 76.27K --.-KB/s in 0.002s ~~~ -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|wget incorrectly truncate |wget incorrectly truncates |long file names |long file names -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c1 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |valentin.lefebvre@suse.com --- Comment #1 from Stefan Hundhammer <shundhammer@suse.com> --- Looks like it uses _POSIX_PATH_MAX (265), not Linux PATH_MAX (4096). % osc maintainer -e wget Defined in package: network:utilities/wget bugowner of wget : valentin.lefebvre@suse.com maintainer of wget : josef.moellers@suse.com, valentin.lefebvre@suse.com Defined in project: network:utilities bugowner of wget : - maintainer of wget : mrueckert@suse.com, dmueller@suse.com, mag@entropy.be, meissner@suse.com, drahn@suse.com, lrupp@suse.com, tiwai@suse.com, eich@suse.com, mseben@gmail.com, alexander_naumov@opensuse.org, - -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c3 Valentin Lefebvre <valentin.lefebvre@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #3 from Valentin Lefebvre <valentin.lefebvre@suse.com> --- Thanks for the reports. The patch has been reformatted due to this report: https://bugzilla.suse.com/show_bug.cgi?id=1204720 Unfortunately, seems to not have been correctly re-world. I am on it to fix it ! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c4 --- Comment #4 from Valentin Lefebvre <valentin.lefebvre@suse.com> --- (In reply to Andreas Stieger from comment #2)
https://git.savannah.gnu.org/cgit/wget.git/commit/ ?id=718ab3f79b3e2a547a8e6538b97cfdb8a94611b8
From 718ab3f79b3e2a547a8e6538b97cfdb8a94611b8 Mon Sep 17 00:00:00 2001 From: Josef Moellers <jmoellers@suse.de> Date: Fri, 11 Jun 2021 16:57:48 +0200 Subject: Long pathnames patch
Thanks for the link. It seems to be a different patch from what I just shared. Therefore, forget my previous comment #3. Both change the same lines. I will need to adapt it based on the previously one we have provided. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c5 --- Comment #5 from Valentin Lefebvre <valentin.lefebvre@suse.com> --- (In reply to Stefan Hundhammer from comment #1)
Looks like it uses _POSIX_PATH_MAX (265), not Linux PATH_MAX (4096).
Initially, wget will check the file length before installing it. The error seems that it takes care about the path during the check of the filename, instead of taking only the filename. So nothing to do with the choice between _POSIX_PATH_MAX and PATH_MAX. (In reply to Andreas Stieger from comment #2)
https://git.savannah.gnu.org/cgit/wget.git/commit/ ?id=718ab3f79b3e2a547a8e6538b97cfdb8a94611b8
Looks like the error also appears in Tumbleweed where wget version is 1.24.5 that includes this change. However it is into this commit that the check of the file length is done when the option "-r/-x" is provided and therefore checking the whole pathname instead of the filename -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c6 --- Comment #6 from Valentin Lefebvre <valentin.lefebvre@suse.com> --- The error doesn't appear in version 1.24.3 and adapting the patch at comment #2 solved the issue. Submit Request has been send to : - SLE15:Update - SLE15-SP6:Update -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c8 --- Comment #8 from Maintenance Automation <maint-coord+maintenance-robot@suse.de> --- SUSE-RU-2024:3890-1: An update that has two fixes can now be installed. URL: https://www.suse.com/support/update/announcement/2024/suse-ru-20243890-1 Category: recommended (moderate) Bug References: 1204720, 1231661 Maintenance Incident: [SUSE:Maintenance:36152](https://smelt.suse.de/incident/36152/) Sources used: openSUSE Leap 15.5 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Micro 5.5 (src): wget-1.20.3-150000.3.23.2 Basesystem Module 15-SP5 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise High Performance Computing 15 SP2 LTSS 15-SP2 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise High Performance Computing LTSS 15 SP3 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise High Performance Computing ESPOS 15 SP4 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise High Performance Computing LTSS 15 SP4 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Desktop 15 SP4 LTSS 15-SP4 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Server 15 SP2 LTSS 15-SP2 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Server 15 SP3 LTSS 15-SP3 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Server 15 SP4 LTSS 15-SP4 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Server for SAP Applications 15 SP2 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Server for SAP Applications 15 SP3 (src): wget-1.20.3-150000.3.23.2 SUSE Linux Enterprise Server for SAP Applications 15 SP4 (src): wget-1.20.3-150000.3.23.2 SUSE Manager Proxy 4.3 (src): wget-1.20.3-150000.3.23.2 SUSE Manager Retail Branch Server 4.3 (src): wget-1.20.3-150000.3.23.2 SUSE Manager Server 4.3 (src): wget-1.20.3-150000.3.23.2 SUSE Enterprise Storage 7.1 (src): wget-1.20.3-150000.3.23.2 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c9 --- Comment #9 from Maintenance Automation <maint-coord+maintenance-robot@suse.de> --- SUSE-RU-2024:3888-1: An update that has two fixes can now be installed. URL: https://www.suse.com/support/update/announcement/2024/suse-ru-20243888-1 Category: recommended (moderate) Bug References: 1204720, 1231661 Maintenance Incident: [SUSE:Maintenance:36153](https://smelt.suse.de/incident/36153/) Sources used: openSUSE Leap 15.6 (src): wget-1.20.3-150600.19.6.2 Basesystem Module 15-SP6 (src): wget-1.20.3-150600.19.6.2 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c10 Valentin Lefebvre <valentin.lefebvre@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(osukup@suse.com) CC| |osukup@suse.com --- Comment #10 from Valentin Lefebvre <valentin.lefebvre@suse.com> --- Should be fixed. Should be find to close the bug ? -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c11 Ondřej Súkup <osukup@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(osukup@suse.com) | --- Comment #11 from Ondřej Súkup <osukup@suse.com> --- LGTM -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1231661 https://bugzilla.suse.com/show_bug.cgi?id=1231661#c12 Valentin Lefebvre <valentin.lefebvre@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #12 from Valentin Lefebvre <valentin.lefebvre@suse.com> --- (In reply to Ondřej Súkup from comment #11)
LGTM
thanks ! -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com