[Bug 1153280] New: fillup breaks on some multiline variables
http://bugzilla.suse.com/show_bug.cgi?id=1153280 Bug ID: 1153280 Summary: fillup breaks on some multiline variables Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: jan.fajerski@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- The prometheus node exporter takes cli arguments that can include regular expression strings. For example /etc/sysconfig/prometheus-node_exporter can have content like so: ARGS="-collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \ -collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) \ -collector.textfile.directory=/var/lib/prometheus/node-exporter" The package https://build.opensuse.org/package/show/server:monitoring/golang-github-prom... recently introduced the use of %fillup_only in its spec file. This however breaks existing sysconfig files. This behaviour can be reproduced by only calling fillup. With the content as listed above in prometheus-node_exporter, a file prometheus-node_exporter.default with this content: ARGS="foo" Calling fillup prometheus-node_exporter prometheus-node_exporter.default prometheus-node_exporter.out produces ARGS="-collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \ -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1153280 Tim Serong <tserong@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tserong@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1153280 Jan Fajerski <jan.fajerski@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocker|--- |Yes Found By|--- |Development Blocks| |1151557 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1153280 http://bugzilla.suse.com/show_bug.cgi?id=1153280#c1 --- Comment #1 from Tim Serong <tserong@suse.com> --- Here's steps to reproduce: # cat prometheus-node_exporter ARGS="-collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \ -collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) \ -collector.textfile.directory=/var/lib/prometheus/node-exporter" # cat prometheus-node_exporter.default ARGS="foo" # fillup prometheus-node_exporter prometheus-node_exporter.default \ prometheus-node_exporter.broken # cat prometheus-node_exporter.broken ARGS="-collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \ I have no idea why, but if I remove the '-' character from the third line of prometheus-node_exporter, the problem goes away: # cat prometheus-node_exporter ARGS="-collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \ -collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) \ collector.textfile.directory=/var/lib/prometheus/node-exporter" # fillup prometheus-node_exporter prometheus-node_exporter.default prometheus-node_exporter.broken # cat prometheus-node_exporter.broken ARGS="-collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \ -collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) \ collector.textfile.directory=/var/lib/prometheus/node-exporter" Something in that string must be confusing fillup's parser, I'm just surprised it's the '-' character. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1153280 Alynx Zhou <alynx.zhou@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alynx.zhou@suse.com Assignee|bnc-team-screening@forge.pr |amajer@suse.com |ovo.novell.com | -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1153280 Stefano Torresi <stefano.torresi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|1151557 | -- You are receiving this mail because: You are on the CC list for the bug.
participants (2)
-
bugzilla_noreply＠novell.com -
bugzilla_noreply＠suse.com