[Bug 479874] New: Gnome Live CD Live installer confirmation dialogue has wrong icon on install button
https://bugzilla.novell.com/show_bug.cgi?id=479874 Summary: Gnome Live CD Live installer confirmation dialogue has wrong icon on install button Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: x86 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Live Medium AssignedTo: coolo@novell.com ReportedBy: casualprogrammer@gmail.com QAContact: qa@suse.de Found By: --- Created an attachment (id=275636) --> (https://bugzilla.novell.com/attachment.cgi?id=275636) Screenshot of confirmation dialogue User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009012700 SUSE/3.0.6-2.5 Firefox/3.0.6 self explanatory Reproducible: Always Steps to Reproduce: 1. Boot 2. Run Live Installer 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Live Medium |YaST2 AssignedTo|coolo@novell.com |bnc-team-screening@forge.pr | |ovo.novell.com QAContact|qa@suse.de |jsrain@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c1 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |captain.magnus@opensuse.org --- Comment #1 from Stephan Kulow <coolo@novell.com> 2009-03-02 02:31:42 MST --- *** Bug 480768 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=480768 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 Cyril Hrubis <chrubis@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |yast2-maintainers@suse.de |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 Hubert Mantel <mantel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mantel@novell.com AssignedTo|yast2-maintainers@suse.de |michael.meeks@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 Martin Kudlvasr <mkudlvasr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkudlvasr@novell.com AssignedTo|michael.meeks@novell.com |mkudlvasr@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User mkudlvasr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c2 Martin Kudlvasr <mkudlvasr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Martin Kudlvasr <mkudlvasr@novell.com> 2009-03-18 10:13:32 MST --- Well, that's when the heuristic uses multiple indicators: installation/src/include/misc.ycp `PushButton (`id (`cancel), `opt(`cancelButton, `key_F10, `default), Label::BackButton()), `PushButton (`id (`ok), `opt (`okButton, `key_F9), confirm_button_label) when 'key', 'id' and 'result' indicators contradict (cancel should use F9), the heuristic goes diabolic. fixed in trunk -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c3 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |locilka@novell.com Resolution|FIXED | --- Comment #3 from Lukas Ocilka <locilka@novell.com> 2009-03-18 10:24:48 MST --- I'm afraid this was intended. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c4 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO Info Provider| |visnov@novell.com --- Comment #4 from Lukas Ocilka <locilka@novell.com> 2009-03-18 10:26:47 MST --- Stano, what's your opinion on this? I think you wanted to have the last dialog with F10==`cancel or "without F_keys at all"? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User visnov@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c5 Stanislav Visnovsky <visnov@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED CC| |visnov@novell.com Info Provider|visnov@novell.com | --- Comment #5 from Stanislav Visnovsky <visnov@novell.com> 2009-03-19 04:46:57 MST --- Well, F10 is used for confirmation, isn't it? This would be highly confusing to use F10 for Cancel. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c6 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |CLOSED Resolution| |FIXED --- Comment #6 from Lukas Ocilka <locilka@novell.com> 2009-03-19 05:07:01 MST --- On the other hand it was intended so :) User pressing F10 the whole fist stage installation should really read the very last pop-up message. I don't remember which PM wanted that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=479874 User mkudlvasr@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=479874#c7 Martin Kudlvasr <mkudlvasr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.meeks@novell.com --- Comment #7 from Martin Kudlvasr <mkudlvasr@novell.com> 2009-03-25 08:51:25 MST --- Well, now it's split into 2 different problems: problem 1: Should the last dialog have F10 mapped to cancel? Argumentation of Lukas is very logical in this part and I agree, that user should be really warned before he wipes the disks. problem 2: Behaviour specified in YCPDialogParser::parseWidgetTreeTerm, YCPDialogParser::parsePushButton, YPushButton::setFunctionKey works like this: role of a PushButton is determined by Key shortcut, explicitely specified role, id string guess - in this order. Which means, that is you specify key shortcut, button role will be always assigned according to this. `PushButton (`id (`cancel), `opt(`cancelButton, `key_F10, `default) will have OkButton role regardless of the role you specify in opt. With this behaviour there is no way to specify in YCP a pushbutton with cancelButton role and F10 shortcut. Maybe this behaviour was programmed into yast to force equivalency of Ok,Cancel,Help button and F10,F9,F1 keys. Yast2-gtk only correctly behaves according to (previously decided) button role, so this is not yast2-gtk problem. I propose we agree on rules by which button roles and function keys are decided and then change them in code. Proposed rules: Button role is determined by (in this order): role option key option widget id After that key shortcut is determined by (in this order): key option button role -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com