[Bug 533538] New: bsd-games-2.17-89.10: missing call to closedir
http://bugzilla.novell.com/show_bug.cgi?id=533538 Summary: bsd-games-2.17-89.10: missing call to closedir Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package bsd-games-2.17-89.10 For source code file bsd-games-2.17/fortune/fortune/fortune.c, around line 750, function add_dir is the following code if ((dir = opendir(fp->path)) == NULL) { but I fail to find a matching call to closedir. This seems to be a resource leak. Suggest add call to closedir. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=533538 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |nadvornik@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=533538 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=533538#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:09 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com