[Bug 546014] New: argus-client-3.0.0-6.2: memory leak and some unfinished code
http://bugzilla.novell.com/show_bug.cgi?id=546014 Summary: argus-client-3.0.0-6.2: memory leak and some unfinished code Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package argus-client-3.0.0-6.2 source code file argus-clients-3.0.0/common/argus_event.c function ArgusProcessSQLEvent local variable is uid
From the command line
$ fgrep uid ../BUILD/argus-clients-3.0.0/common/argus_event.c char mbuf[MAXSTRLEN], username[1024], *uid; accounts = getpwuid(geteuid())->pw_name; if (row[0]) uid = strdup((const char *)row [0]); We can see that local variable uid is declared, line 2 is unrelated and line 3 has a call to strdup. Other than that, local variable uid is unused but causes a memory leak. Suggest delete local variable uid. In the same routine, local variables uid, name, fullname, address, telephone, mobile, fax, email url, pass, filter and stat all seem to be set but never used. It might be unfinished code, but suggest remove this code until it is ready for use. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=546014 Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mseben@novell.com AssignedTo|bnc-team-screening@forge.pr |mseben@novell.com |ovo.novell.com | Summary|argus-client-3.0.0-6.2: |JJ: argus-client-3.0.0-6.2: |memory leak and some |memory leak and some |unfinished code |unfinished code -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=546014 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=546014#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:56:20 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=546014 Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|JJ: argus-client-3.0.0-6.2: |argus-client-3.0.0-6.2: |memory leak and some |memory leak and some |unfinished code |unfinished code -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=546014 User mseben@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=546014#c2 Michal Seben <mseben@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Michal Seben <mseben@novell.com> 2009-10-19 23:59:23 MDT --- reported to upstream : http://thread.gmane.org/gmane.network.argus/6910 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com