[Bug 524535] New: espeak-1.39-2.60: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=524535 Summary: espeak-1.39-2.60: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Sound AssignedTo: tiwai@novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package espeak-1.39-2.60 For source code file espeak-1.39-2.60, around line 630 is the source code for the function LoadConfig. I notice the following code if((f = fopen(buf,"r"))==NULL) but no matching call to fclose. This looks like a resource leak to me. Suggest code rework. Maybe it would be enough to add fclose( f); near the end of the function. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524535 User tiwai@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524535#c1 Takashi Iwai <tiwai@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|tiwai@novell.com |marco@novell.com --- Comment #1 from Takashi Iwai <tiwai@novell.com> 2009-07-23 03:46:40 MDT --- Reassigned to maintainer. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524535 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524535#c2 --- Comment #2 from David Binderman <dcb314@hotmail.com> 2009-07-23 04:37:43 MDT --- That source code filename should be espeak-1.39/src/synthdata.cpp -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=524535 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=524535#c3 --- Comment #3 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:41 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=524535 https://bugzilla.novell.com/show_bug.cgi?id=524535#c5 Takashi Iwai <tiwai@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #5 from Takashi Iwai <tiwai@novell.com> 2010-12-03 15:14:37 UTC --- Resolved as in comment 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com