[Bug 1181066] New: YaST mounts target /run on top of running system
https://bugzilla.suse.com/show_bug.cgi?id=1181066 Bug ID: 1181066 Summary: YaST mounts target /run on top of running system Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: fvogt@suse.com QA Contact: jsrain@suse.com Found By: --- Blocker: --- I noticed that while YaST runs, (/mnt)/run of the target system is bind mounted on top of /run. This impacts the live environment badly, as it's pretty much unusuable without dbus and wayland sockets and so on... /proc/self/mountinfo shows: 644 577 0:24 / /mnt/run rw,nosuid,nodev shared:24 - tmpfs tmpfs rw,size=802844k,nr_inodes=819200,mode=755,inode64 661 644 0:24 / /mnt/run rw,nosuid,nodev shared:24 - tmpfs tmpfs rw,size=802844k,nr_inodes=819200,mode=755,inode64 662 28 0:24 / /run rw,nosuid,nodev shared:24 - tmpfs tmpfs rw,size=802844k,nr_inodes=819200,mode=755,inode64 So it seems like YaST basically does: mount -t tmpfs tmpfs /mnt/run mount --bind /mnt/run /mnt/run mount --bind /mnt/run /run Why not just mount --bind /run /mnt/run? -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c1 Fabian Vogt <fvogt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|YaST2 |Installation --- Comment #1 from Fabian Vogt <fvogt@suse.com> --- Moving to "Installation" component as this is about Installations and Upgrades. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c2 Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jlopez@suse.com, | |snwint@suse.com Flags| |needinfo?(snwint@suse.com) --- Comment #2 from Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> --- Stefen, I think you know more details about this. Could you please have a look? Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c4 Steffen Winterfeldt <snwint@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(snwint@suse.com) | --- Comment #4 from Steffen Winterfeldt <snwint@suse.com> ---
Why not just mount --bind /run /mnt/run?
That's what yast does, afaik. At least during a 'normal' installation. https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/client... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 Arvin Schnell <aschnell@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c5 --- Comment #5 from Fabian Vogt <fvogt@suse.com> --- Found it! It's actually specific to upgrades. https://github.com/yast/yast-update/blob/15c6f2148e05aaf5cdc77f3620658667f4e... runs "mount -o bind -t none /run /mnt/run", and in line 825 it runs "mount --bind /run /mnt/run". The duplication doesn't seem intended to me. As /mnt/run is a bind mount, this is effectively "mount --bind /run /run", which hides all mountpoints inside. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c6 --- Comment #6 from Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> --- Thanks Fabian! I am going to create a card to have a closer look to that logic in RootPart. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED URL| |https://trello.com/c/7pp6hn | |68 Assignee|yast2-maintainers@suse.de |yast-internal@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c7 Lukas Ocilka <locilka@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schubi@suse.com --- Comment #7 from Lukas Ocilka <locilka@suse.com> --- Added by this commit https://github.com/yast/yast-update/commit/77b9d0f206002e3e34eccab8beace13f1... Written by Schubi: At upgrade time, mount also /run and efivars in the target to fix hanging LVM tools (bsc#1148500) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c8 Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fvogt@suse.com Flags| |needinfo?(fvogt@suse.com) --- Comment #8 from Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> --- Fabian, could you please describe how to reproduce this bug? I understood that it happens in a live installer, but the bug is in yast2-update package, so it is not clear to me how to manage to reproduce it. Thank! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c9 --- Comment #9 from Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> --- (In reply to Jos� Iv�n L�pez Gonz�lez from comment #8)
Fabian, could you please describe how to reproduce this bug? I understood that it happens in a live installer, but the bug is in yast2-update package, so it is not clear to me how to manage to reproduce it. Thank!
Any update here? We need to know how to reproduce the bug in order to know what products are affected and which branches require a fix. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c10 Fabian Vogt <fvogt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fvogt@suse.com) | --- Comment #10 from Fabian Vogt <fvogt@suse.com> --- (In reply to Jos� Iv�n L�pez Gonz�lez from comment #8)
Fabian, could you please describe how to reproduce this bug? I understood that it happens in a live installer, but the bug is in yast2-update package, so it is not clear to me how to manage to reproduce it. Thank!
During the installation, sub-mounts of /run become invisible. In the live environment this manifests itself as "/run/user/1000/" appearing empty while the upgrade is in progress. It can be reproduced also outside of the live installer, by doing a submount manually: "mkdir -p /run/foo && mount -t tmpfs tmpfs /tmp/foo && touch /run/foo/bar". While the upgrade is running, "/run/foo" appears empty. (I did not actually try this). live-net-installer starts YaST in a separate mount namespace to workaround this, so I can't actually tell for sure whether YaST still does the double mount. More generally, that /run is mounted into the target system at all is also an issue. It means the RPM transaction (e.g. scriptlets and file actions) change /run of the running system. Can be reproduced by making sure "/run/utmp" exists in the inst-sys before an upgrade from 42.x to TW starts. After aaa_base got upgraded, it's gone from the inst-sys. With systemd this crashes logind (boo#1187971) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c13 Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #13 from Jos� Iv�n L�pez Gonz�lez <jlopez@suse.com> --- Fixed by yast2-update 4.4.2: * https://github.com/yast/yast-update/pull/170 * https://build.opensuse.org/request/show/908364 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c14 --- Comment #14 from Swamp Workflow Management <swamp@suse.de> --- # maintenance_jira_update_notice openSUSE-RU-2021:2869-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1181066 CVE References: JIRA References: Sources used: openSUSE Leap 15.3 (src): yast2-update-4.3.3-3.3.1 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c15 --- Comment #15 from Swamp Workflow Management <swamp@suse.de> --- # maintenance_jira_update_notice SUSE-RU-2021:2869-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1181066 CVE References: JIRA References: Sources used: SUSE Linux Enterprise Module for Basesystem 15-SP3 (src): yast2-update-4.3.3-3.3.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c16 --- Comment #16 from Swamp Workflow Management <swamp@suse.de> --- # maintenance_jira_update_notice SUSE-RU-2021:2882-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1181066 CVE References: JIRA References: Sources used: SUSE Linux Enterprise Module for Basesystem 15-SP2 (src): yast2-update-4.2.22-3.10.1 SUSE Linux Enterprise Installer 15-SP2 (src): yast2-update-4.2.22-3.10.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1181066 https://bugzilla.suse.com/show_bug.cgi?id=1181066#c17 --- Comment #17 from Swamp Workflow Management <swamp@suse.de> --- # maintenance_jira_update_notice openSUSE-RU-2021:1241-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1181066 CVE References: JIRA References: Sources used: openSUSE Leap 15.2 (src): yast2-update-4.2.22-lp152.2.10.1 -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com