[Bug 900099] New: smartmontools: generate_smartd_opts refers to init script
http://bugzilla.suse.com/show_bug.cgi?id=900099 Bug ID: 900099 Summary: smartmontools: generate_smartd_opts refers to init script Classification: openSUSE Product: openSUSE Factory Version: 201410* Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: sbrabec@suse.com Reporter: lnussel@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- - /usr/lib/smartmontools/generate_smartd_opts refers to an init script that no longer exists - /usr/lib/smartmontools/generate_smartd_opts is never called AFAICS unless one uses YaST to edit /etc/sysconfig/smartmontools. Maybe the service file should call it before launching smartd? - /var/lib/smartmontools/smartd_opts should probably be moved to /run - rcsmartd symlink is missing -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=900099
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=900099
--- Comment #3 from Ludwig Nussel
- /usr/lib/smartmontools/generate_smartd_opts refers to an init script that no longer exists
It tries to restart service. Needs fix.
- /usr/lib/smartmontools/generate_smartd_opts is never called AFAICS unless one uses YaST to edit /etc/sysconfig/smartmontools. Maybe the service file should call it before launching smartd?
It is called by YaST and in %post.
- /var/lib/smartmontools/smartd_opts should probably be moved to /run
This file should be reboot persistent, as it prevents need of calling shell on every boot.
That way you need to know that you need to call this script after editing the sysconfig file though. Which is likely non obvious to most people as they are unfamiliar with the extra yast syntax in there. Alternatively the file could be retired completely. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=900099
--- Comment #4 from Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=900099
Marc Schütz
http://bugzilla.suse.com/show_bug.cgi?id=900099
--- Comment #6 from Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=900099
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=900099
Marc Schütz
Marc Schütz:
This was already fixed by:
Tue Oct 7 22:55:04 CEST 2014 - sbrabec@suse.cz
- Fix service restart in smartmontools.generate_smartd_opts.in (bnc#900099).
The file will be re-generated either on update or after editing parameters in yast2 sysconfig.
The fix should be already in 13.2.
Please check your /usr/lib/smartmontools/generate_smartd_opts. If it contains corrected comment, then something gone wrong. (Script skipped on update or so.)
Indeed, the script contains the correct text. Somethings must have gone wrong with the update. I did the update shortly after 13.2 was released, so I'm afraid I cannot remember any unusual circumstances. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=900099
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=900099
Marc Schütz
If you are using Factory, you have a package with fix mentioned in changelog, and your /var/lib/smartmontools/smartd_opts still refers to an incorrect file, then something gone wrong and should be investigated.
This file should have been re-generated just after the release of fixed package. The time stamp should match install time, or it could be newer, if you used YaST to edit smartd options.
If the time stamp is older than install date of the last smartmontools update, something gone wrong.
Could you check your YaST/zypp logs? Maybe you can find there a failure of smartmontools script.
This is from /var/log/zypp/history: # 2012-11-22 21:35:56 smartmontools-5.42-8.1.3.x86_64.rpm installed ok # Additional rpm output: # Updating /etc/sysconfig/smartmontools... # 2012-11-22 21:35:56|install|smartmontools|5.42-8.1.3|x86_64||openSUSE-12.2-1.6|00bf732223d3a9c8e3ae08f93acc529281ef8fa3b9debe91c365ce0dc5c61869 ... # 2013-01-01 20:52:02 smartmontools-6.0-8.4.1.x86_64.rpm installed ok # Additional rpm output: # Updating /etc/sysconfig/smartmontools... # redirecting to systemctl # 2013-01-01 20:52:02|install|smartmontools|6.0-8.4.1|x86_64||repo-update|f07aa13daa4cd143c72a1b45a96ab57afb04b1701868931eb86aa96f18b97f31 ... # 2013-03-20 18:55:27 smartmontools-6.0-5.1.1.x86_64.rpm installed ok # Additional rpm output: # Updating /etc/sysconfig/smartmontools... # redirecting to systemctl try-restart smartd # 2013-03-20 18:55:27|install|smartmontools|6.0-5.1.1|x86_64||openSUSE-12.2-1.6|ab0596d12bde1b4b6202d6bdd3d8a396b1b50764a5035dc94bb75912bee6c40f| ... # 2013-11-19 22:31:08 smartmontools-6.2-2.1.2.x86_64.rpm installed ok # Additional rpm output: # Updating /etc/sysconfig/smartmontools... # /var/tmp/rpm-tmp.pEP8AP: line 8: /etc/init.d/smartd: No such file or directory # 2013-11-19 22:31:08|install|smartmontools|6.2-2.1.2|x86_64||openSUSE-13.1|97c1928b64ef47dd165b9f2dd1f24efa5ebccb928ee5af70c32c3bcc3933a358| ... # 2014-11-04 20:36:30 smartmontools-6.3-2.1.x86_64.rpm installed ok # Additional rpm output: # Updating /etc/sysconfig/smartmontools... # 2014-11-04 20:36:30|install|smartmontools|6.3-2.1|x86_64||openSUSE-13.2|2651fb4d85c4e29e56032a1462999664a999e20c| Evidently the update to 13.1 on 2013-11-19 went wrong. But there's the question why it was downgraded on 2013-03-20. I can't remember whether I did this intentionally. Anyway, /var/lib/smartmontools/smartd_opts has an mtime of 2014-11-04, the time of the update to 13.2! # LANG=C stat /var/lib/smartmontools/smartd_opts File: ‘/var/lib/smartmontools/smartd_opts’ Size: 74 Blocks: 8 IO Block: 4096 regular file Device: 802h/2050d Inode: 1060421 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2015-03-12 10:04:25.989419900 +0100 Modify: 2014-11-04 20:36:30.191641296 +0100 Change: 2014-11-04 20:36:30.191641296 +0100 Birth: - A wild guess: maybe the update script was run as preinstall and still used the old generator? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=900099
--- Comment #10 from Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=900099
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
http://bugzilla.suse.com/show_bug.cgi?id=900099#c11
--- Comment #11 from Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
http://bugzilla.suse.com/show_bug.cgi?id=900099#c12
--- Comment #12 from Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
http://bugzilla.suse.com/show_bug.cgi?id=900099#c13
--- Comment #13 from Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=900099
http://bugzilla.suse.com/show_bug.cgi?id=900099#c14
Marketa Calabkova
participants (1)
-
bugzilla_noreply@novell.com