[Bug 1091305] New: gnome-control-center differs between SLE and Leap
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305 Bug ID: 1091305 Summary: gnome-control-center differs between SLE and Leap Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.0 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME Assignee: bnc-team-gnome@forge.provo.novell.com Reporter: lnussel@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- gnome-control-center has quite some patches guarded with !is_opensuse. That means Leap differs from SLE there. Is that really correct? # PATCH-FEATURE-SLE gnome-control-center-890979-change-remote-passwd.patch bnc#890979 dliang@suse.com -- user: Enable remote user to change password in user panel Patch1002: gnome-control-center-890979-change-remote-passwd.patch # PATCH-FEATURE-SLE gnome-control-center-info-never-use-gnome-software.patch bsc#999336 fezhang@suse.com -- info: Never search for gnome-software as an option when checking for updates on SLE and Leap 42.2, because we use gpk-update-viewer. Patch1003: gnome-control-center-info-never-use-gnome-software.patch # PATCH-FEATURE-SLE gnome-control-center-more-power-button-actions.patch bsc#993381 fezhang@suse.com -- power: Bring back the "shutdown" and "interactive" power button actions. Patch1004: gnome-control-center-more-power-button-actions.patch # PATCH-FEATURE-SLE gnome-control-center-bring-back-firewall-zone.patch fate#316719 sckang@suse.com -- network: Bring back the firewall zone combo box to select proper firewall zone for each connection. Patch1005: gnome-control-center-bring-back-firewall-zone.patch -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
Ludwig Nussel
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
Yifan Jiang
# PATCH-FEATURE-SLE gnome-control-center-info-never-use-gnome-software.patch bsc#999336 fezhang@suse.com -- info: Never search for gnome-software as an option when checking for updates on SLE and Leap 42.2, because we use gpk-update-viewer. Patch1003: gnome-control-center-info-never-use-gnome-software.patch Currently in Leap15 gnome-software will be launched if you go to g-c-c /
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c3
--- Comment #3 from QK ZHU
# PATCH-FEATURE-SLE gnome-control-center-more-power-button-actions.patch bsc#993381 fezhang@suse.com -- power: Bring back the "shutdown" and "interactive" power button actions. Patch1004: gnome-control-center-more-power-button-actions.patch
Two power button options were removed in GNOME 3.20, then we brought them back in SLE with label 'Shutdown' and 'Interactive'. However things changed in upstream 8 months ago, the 'Interactive' option was re-added with label 'Power Off' This patch should be re-based to Leap15 and we should rename 'Power Off' to 'Interactive' to align with SLE12SP3 I filed another bug to track the rename issue: bsc#1091796 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c4
--- Comment #4 from Ludwig Nussel
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c5
--- Comment #5 from QK ZHU
when you say rebase you mean enable them for leap? It's the same code so Yes, sorry for the wrong wording。 there should be nothing to rebase :-) In any case we are running out of time, please submit the fixes ASAP :)
I just checked changing the password of AD user in g-c-c on Leap15 build 219.1 and TW 20180501, it works fine without
# PATCH-FEATURE-SLE gnome-control-center-890979-change-remote-passwd.patch bnc#890979 dliang@suse.com -- user: Enable remote user to change password in user panel Patch1002: gnome-control-center-890979-change-remote-passwd.patch
Password changing for remote users was disabled in GNOME 3.6.X - https://bugzilla.gnome.org/show_bug.cgi?id=681866#c16 And it seems no one check it again until SLE12, we enabled it by gnome-control-center-890979-change-remote-passwd.patch, however it works again in Leap15 and TW. Perhaps it was fixed by upstream recently (But I didn't find the fix commit until now) I think this patch shouldn't be enabled in Leap15 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c6
--- Comment #6 from Ludwig Nussel
And it seems no one check it again until SLE12, we enabled it by gnome-control-center-890979-change-remote-passwd.patch, however it works again in Leap15 and TW. Perhaps it was fixed by upstream recently (But I didn't find the fix commit until now)
I think this patch shouldn't be enabled in Leap15
But it's enabled in SLE15 right now, right? Why would it be enabled in SLE but not Leap? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c9
--- Comment #9 from Yifan Jiang
From the patch, these lines seem harmless for local users, while it might have side effect to remote users.
+/* Enable the remote account also. enable = act_user_is_local_account (user); +*/ + enable = TRUE; Am I right even with this patch, remote users password still can be changed? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c10
--- Comment #10 from QK ZHU
@Chingkai,
From the patch, these lines seem harmless for local users, while it might have side effect to remote users.
+/* Enable the remote account also. enable = act_user_is_local_account (user); +*/ + enable = TRUE;
Am I right even with this patch, remote users password still can be changed?
I just removed this patch in my personal repo: - https://build.suse.de/package/show/home:qkzhu:branches:SUSE:SLE-15:GA/gnome-... Just tested on SLED15 RC3, remote users password can be changed in without this patch, I think we should file another bug and drop this patch. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305
http://bugzilla.opensuse.org/show_bug.cgi?id=1091305#c11
--- Comment #11 from Yifan Jiang
(In reply to Yifan Jiang from comment #9)
@Chingkai,
From the patch, these lines seem harmless for local users, while it might have side effect to remote users.
+/* Enable the remote account also. enable = act_user_is_local_account (user); +*/ + enable = TRUE;
Am I right even with this patch, remote users password still can be changed?
I just removed this patch in my personal repo: - https://build.suse.de/package/show/home:qkzhu:branches:SUSE:SLE-15:GA/gnome- control-center
I took a glance of the current code base, as well as the patch's target: https://bugzilla.opensuse.org/show_bug.cgi?id=890979#c2 Actually I don't see upstream ever intended to enable the password change for remote users. The start point to debug comment#5 might be to look deeper what does accountsservice really do here nowadays: act_user_is_local_account (user);
Just tested on SLED15 RC3, remote users password can be changed in without this patch, I think we should file another bug and drop this patch.
Regarding the timeline, before we are clear about the reason, perhaps it's better to enable the patch by now to keep it consistent with SLE-15 (if the answer to comment#9 is positive) -- which has been tested. @Felix, Feel free to comment if you have any inputs for this :-) -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com