[Bug 1046591] New: [lvm test] thin-overprovisioning.sh failed
http://bugzilla.suse.com/show_bug.cgi?id=1046591 Bug ID: 1046591 Summary: [lvm test] thin-overprovisioning.sh failed Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: zren@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Created attachment 730693 --> http://bugzilla.suse.com/attachment.cgi?id=730693&action=edit log for thin-overprovisioning.sh # lvm2-testsuite --flavours udev-lvmetad --only thin-overprovisioning.sh ... ### 1 tests: 0 passed, 0 skipped, 0 timed out, 0 warned, 1 failed -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1046591
zhen ren
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c1
--- Comment #1 from zhen ren
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c2
--- Comment #2 from zhen ren
http://bugzilla.suse.com/show_bug.cgi?id=1046591
zhen ren
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c4
zhen ren
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c5
Hannes Reinecke
DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG is set to indicate not creating symlink like /dev/${vg_name}/${lv_name} for LV that should not be visible to user, like a thin pool LV.
lib/activate/dev_manager.c : _get_udev_flags() """ 1665 /* 1666 * Is this top-level and visible device? 1667 * If not, create just the /dev/mapper content. 1668 */ 1669 /* FIXME: add target's method for this */ 1670 if (lv_is_new_thin_pool(lv)) 1671 /* New thin-pool is regular LV with -tpool UUID suffix. */ 1672 udev_flags |= DM_UDEV_DISABLE_DISK_RULES_FLAG | 1673 DM_UDEV_DISABLE_OTHER_RULES_FLAG; 1674 else if (layer || !lv_is_visible(lv) || lv_is_thin_pool(lv)) 1675 udev_flags |= DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG | 1676 DM_UDEV_DISABLE_DISK_RULES_FLAG | 1677 DM_UDEV_DISABLE_OTHER_RULES_FLAG; """
udev/11-dm-lvm.rules.in: """ 38 ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}=="1", GOTO="lvm_end" ... 46 # Create symlinks for top-level devices only. 47 ENV{DM_VG_NAME}=="?*", ENV{DM_LV_NAME}=="?*", SYMLINK+="$env{DM_VG_NAME}/$env{DM_LV_NAME}", GOTO="lvm_end" """
But, this patch "Subject: [PATCH] 10-dm.rules: Reset state variables for spurious events" cleared DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG by: """ +ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}="" """
@Hannes, this testcase will pass if I remove the line above from your patch. But, I'm not sure if it's safe. What do you think?
Hmm. Should be okay, indeed. The DM_UDEV_* variables are magic thingies anyway, so I'm not _that_ surprised that this error happened. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c6
--- Comment #6 from zhen ren
But, this patch "Subject: [PATCH] 10-dm.rules: Reset state variables for spurious events" cleared DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG by: """ +ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}="" """
@Hannes, this testcase will pass if I remove the line above from your patch. But, I'm not sure if it's safe. What do you think?
Hmm. Should be okay, indeed.
Just remove the DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG line, or drop this patch?
The DM_UDEV_* variables are magic thingies anyway, so I'm not _that_ surprised that this error happened.
Yes. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1046591
http://bugzilla.suse.com/show_bug.cgi?id=1046591#c7
zhen ren
participants (1)
-
bugzilla_noreply@novell.com