[Bug 530339] New: sbl-3.4.0-12.32: missing call to close
http://bugzilla.novell.com/show_bug.cgi?id=530339 Summary: sbl-3.4.0-12.32: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package sbl-3.4.0-12.32 For source code file sblsrc-3.4.0/sbl/HT/vario.c around line 640 is the source code for the function loadkeytbl. I notice the following line of code if ((tbl_fd = open (KEYTBL, O_RDONLY)) >= 0 but I fail to notice a matching call to close This looks like a resource leak to me. Suggest add call to close. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=530339 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |marco@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=530339 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=530339#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:00 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=530339 http://bugzilla.novell.com/show_bug.cgi?id=530339#c3 yang xiaoyu <xyyang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xyyang@novell.com AssignedTo|bnc-team-screening@forge.pr |coolo@novell.com |ovo.novell.com | --- Comment #3 from yang xiaoyu <xyyang@novell.com> 2010-03-09 06:53:35 UTC --- stephan,do you know who take care of this bug?Please assign to the right person.Thx. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=530339 http://bugzilla.novell.com/show_bug.cgi?id=530339#c Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|coolo@novell.com |btaylor1@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=530339 https://bugzilla.novell.com/show_bug.cgi?id=530339#c Xinli Niu <xlniu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |xlniu@novell.com AssignedTo|bnc-team-screening@forge.pr |marco@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=530339 https://bugzilla.novell.com/show_bug.cgi?id=530339#c Xinli Niu <xlniu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |npaxton@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=530339 https://bugzilla.novell.com/show_bug.cgi?id=530339#c Norm Paxton <npaxton@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|npaxton@novell.com |bnc-team-screening@forge.pr | |ovo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=530339 https://bugzilla.novell.com/show_bug.cgi?id=530339#c zj jia <zjjia@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@suse.com AssignedTo|bnc-team-screening@forge.pr |jw@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com