[Bug 224192] New: rug does not query for license
https://bugzilla.novell.com/show_bug.cgi?id=224192 Summary: rug does not query for license Product: openSUSE 10.2 Version: RC 2 Platform: Other OS/Version: Other Status: NEW Severity: Blocker Priority: P5 - None Component: Zenworks AssignedTo: zlm-code10-bugs@forge.provo.novell.com ReportedBy: meissner@novell.com QAContact: sarifulla@novell.com CC: holgi@novell.com, aj@novell.com even with latest RC2 + latest ZYPP / ZMD update: # rug in -t patch fetchmsttfonts.sh installs the fetchmsttfonts patch without asking to confirm the license. It must ask for the license unless the --skip-interactive thing is given. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 kkaempf@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |visnov@novell.com, mvidner@novell.com, | |ma@novell.com AssignedTo|zlm-code10- |dmacvicar@novell.com |bugs@forge.provo.novell.com | Component|Zenworks |libzypp ------- Comment #1 from kkaempf@novell.com 2006-11-28 13:09 MST ------- This seems to be a bug in libzypp resp. libzypp-zmd-backend. How to test: - run the 'rug' command as described above - cancel the transaction - at this point /var/lib/zmd/zmd.db contains the (uncommitted) transaction - copy /var/lib/zmd/zmd.db to a safe place (so the zmd deamon doesn't tamper with it), e.g 'cp /var/lib/zmd/zmd.db /tmp' - now run the 'transact' helper standalone, e.g /var/lib/zmd/transact /tmp/zmd.db It will print all callbacks to stdout - the message/license callback does not show. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 ------- Comment #2 from kkaempf@novell.com 2006-11-28 13:29 MST ------- Hmm, after installing this patch it shows up in /var/lib/zypp/db/patches (which is correct) but has <interactive>false</interactive> which is probably not correct. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 ------- Comment #6 from kkaempf@novell.com 2006-11-28 14:32 MST ------- Looking at libzypp-zmd-backend, its quite obvious that licenses in patches are completely ignored. Fix is underway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 ------- Comment #7 from ma@novell.com 2006-11-28 14:33 MST ------- This seems closely related to bug #221476. A couple of (identical) methods computing a patches 'interactive' property were removed from zypp and zmd-backend. PatchImplIf::interactive should now be the sole location that computes and distributes the value. The method was fixed to actually compute 'interactive' the way the comments suggested it should be: Interactive returns true, iff Patch needs reboot, or contains a Message, or contains an Atom with licenseToConfirm So this does not cover the case that the patch itself has a licenseToConfirm ;( -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 ma@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |kkaempf@novell.com ------- Comment #8 from ma@novell.com 2006-11-28 14:37 MST ------- @Klaus: I'll fix PatchImplIf::interactive to return true as well, if the patch itself has a license. Are the more conditions, where interactive should be true? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 kkaempf@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Info Provider|kkaempf@novell.com | Resolution| |FIXED ------- Comment #9 from kkaempf@novell.com 2006-11-28 14:38 MST ------- Fixed in libzypp-zmd-backend svn rev 4701. tested and verified. submitted to autobuild. case closed ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 ------- Comment #10 from kkaempf@novell.com 2006-11-28 14:39 MST ------- Michael, please postpone any further fixes ! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=224192 ------- Comment #11 from ma@novell.com 2006-11-28 15:11 MST ------- Sorry, already in SVN. But appart from the fact that zmd-backend ignored license in patches... The bug revealed that Patch::interactive is not computed correctly for e.g. fetchmsttfonts.sh. AFAIK YaST/zypper evaluate this. Thus if they fail on --skip-interactive, we should submitt libzypp as well. --- detail/PatchImplIf.cc (revision 4701) +++ detail/PatchImplIf.cc (working copy) @@ -43,7 +43,8 @@ bool PatchImplIf::interactive() const { - if ( reboot_needed() ) + if ( reboot_needed() + || ! licenseToConfirm().empty() ) { return true; } -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com