[Bug 1121720] New: Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

bugzilla_noreply＠novell.com

12 Jan 2019 12 Jan '19

19:15

http://bugzilla.suse.com/show_bug.cgi?id=1121720 Bug ID: 1121720 Summary: Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: x86-64 OS: Other Status: NEW Severity: Major Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: pieter@hollants.com QA Contact: jsrain@suse.com Found By: --- Blocker: --- Created attachment 794273 --> http://bugzilla.suse.com/attachment.cgi?id=794273&action=edit Autoyast profile to reproduce; install once first, then try to re-install Retaining an existing software RAID via AutoYast is also broken with regard to reuse of the MD itself: inspite of reformat == false being picked up from the Autoyast profile, y2storage md_creator.rb wants to format an MD device because of this code block: if planned_md.partitions.empty? format_md(new_graph, md, planned_md) else partition_md(new_graph, md, planned_md) end ...because planned_md.partitions is empty. I couldn't figure out yet whether planned_md SHOULD have contained the member partitions or whether the if-statement needs modification. NOTE: The attached example Autoyast file uses "/dev/md/0" for both the "/dev/md" drive as well as the RAID member partitions to work around the bug in #1120979. Nevertheless I don't think this bug is a direct result of said workaround because if I - use a Autoyast profile with /dev/md0 - with Byebug break on the code block affected in #1120979 and manually make it find the MD to reuse Yast still wants to format /dev/md0. -- You are receiving this mail because: You are on the CC list for the bug.

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

bugzilla_noreply＠novell.com

23 Jan 23 Jan

14:57

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c1 Steffen Winterfeldt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pieter@hollants.com Flags| |needinfo?(pieter@hollants.c | |om) --- Comment #1 from Steffen Winterfeldt --- Pieter, please attach the yast logs for this. -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

15:47

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c2 Steffen Winterfeldt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED CC| |ancor@suse.com Flags|needinfo?(pieter@hollants.c |needinfo?(ancor@suse.com) |om) | --- Comment #2 from Steffen Winterfeldt --- FWIW, I did a test install. But bugzilla is not in a good mood today. So I put the logs here: https://w3.suse.de/~snwint/y2log-RBfdhq.tar.xz Ancor, probably the same as bug 1120979? -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

15:47

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 Steffen Winterfeldt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snwint@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16:01

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c3 Ancor Gonzalez Sosa changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ancor@suse.com) | --- Comment #3 from Ancor Gonzalez Sosa --- (In reply to Steffen Winterfeldt from comment #2)

...

Ancor, probably the same as bug 1120979?

Yes, I'm pretty sure this is a duplicate of bug#1120979. (In reply to Pieter Hollants from comment #0)

...

NOTE: The attached example Autoyast file uses "/dev/md/0" for both the "/dev/md" drive as well as the RAID member partitions to work around the bug in #1120979.

The style of the names used in the profile (/dev/md/0 vs /dev/md0) is not relevant, since (as already mentioned in the other bug report) the real problem doesn't come from matching the strings in the profile with the device name. The problem is how we translate this to a device name in the (Auto)YaST code: <drive> <device>/dev/md</device> <partitions> <partition> 0 </partition> </partitions> </drive> That's becoming "/dev/md0" and it should be "/dev/md/0". In other words, the bug is here: https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/autoin... The failures in the code mentioned in bug#1120979 and in the code pasted in the description of this bug are just consequences. -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16:09

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c4 --- Comment #4 from Pieter Hollants --- I'm wondering where the confusion could come from in the first place: so far I've seen the kernel only use "/dev/md0", so I assume "/dev/md/0" is some YaST-internal syntax? -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16:11

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 Arvin Schnell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16:15

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c5 --- Comment #5 from Ancor Gonzalez Sosa --- (In reply to Pieter Hollants from comment #4)

...

I'm wondering where the confusion could come from in the first place: so far I've seen the kernel only use "/dev/md0", so I assume "/dev/md/0" is some YaST-internal syntax?

No, it's not. According to libstorage-ng, that's the real kernel name of the MD device. Ask Arvin for more details. -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

18:17

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c6 --- Comment #6 from Arvin Schnell --- "/dev/md/0" is a link to "/dev/md0" created my mdadm as it does for all named RAIDs (see man mdadm). You can compare "mdadm --create /dev/md0 ..." with "mdadm --create /dev/md/1 ...". For the first no link in /dev/md/ is created and 'mdadm --detail --export' does not report a MD_DEVNAME. For the second the link /dev/md/1 is created and MD_DEVNAME=1 is reported. AFAIR mdadm creates a named RAID during auto assembly even if the name is just a number. For details you could contact upstream mdadm, e.g. linux-raid ML. libstorage-ng uses the link with the name if available as device name. AFAIK the documentation does not mention "real kernel name" here. -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

22:52

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c7 --- Comment #7 from Pieter Hollants --- I don't think it is a duplicate: by looking at https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/autoin... I deducted that specifying an explicit in the section, I could work around the other bug #1120979: <drive> <device>/dev/md</device> <partitions config:type="list"> <partition> [...] raid1 /dev/md/0 </partition> </partitions> <use>free</se> </drive> But then I discovered _this_ bug. Please also note that by referring to the raid as /dev/md/0 instead of /dev/md0 I think we've broken compatibility with existing Autoyast profiles: both the Autoyast Documentation for openSUSE 15.0 at https://doc.opensuse.org/projects/autoyast/#ay.partition_sw_raid and the newest documentation I could find, for SLES 12SP4, use "/dev/md0" as . -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

24 Jan 24 Jan

14:41

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 Ancor Gonzalez Sosa changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://trello.com/c/lZCZ7g | |mP Assignee|yast2-maintainers@suse.de |yast-internal@suse.de -- You are receiving this mail because: You are on the CC list for the bug.

bugzilla_noreply＠novell.com

1 Feb 1 Feb

11:40

New subject: [Bug 1121720] Retaining existing Software RAID via AutoYast is broken: y2storage always formats MD

http://bugzilla.suse.com/show_bug.cgi?id=1121720 http://bugzilla.suse.com/show_bug.cgi?id=1121720#c9 --- Comment #9 from Ancor Gonzalez Sosa --- (In reply to Pieter Hollants from comment #7)

...

I don't think it is a duplicate: by looking at

Yes, this is just another consequence of the very same bug. The same fix that we already reported for bug#1120979 (adding a slash to the line linked below) also fixes this other symptom. https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/autoin...

...

I deducted that specifying an explicit in the section, I could work around the other bug #1120979:

Wrong deduction ;-) Reusing a raid was broken either by using /dev/md0 and by using /dev/md/0. With the fix we already commented in the other bug, both work.

...

<drive> [...] /dev/md/0 [...] </drive>

But then I discovered _this_ bug.

Then you rediscovered the same bug. ;-)

...

Please also note that by referring to the raid as /dev/md/0 instead of /dev/md0 I think we've broken compatibility with existing Autoyast profiles: both the Autoyast Documentation for openSUSE 15.0 at https://doc.opensuse.org/projects/autoyast/#ay.partition_sw_raid and the newest documentation I could find, for SLES 12SP4, use "/dev/md0" as .

As said, backwards compatibility is not broken. Once the bug is fixed, it will work for both /dev/md0 and /dev/md/0. -- You are receiving this mail because: You are on the CC list for the bug.