[Bug 351386] New: error in /etc/init.d/skeleton.compat
https://bugzilla.novell.com/show_bug.cgi?id=351386 Summary: error in /etc/init.d/skeleton.compat Product: openSUSE 10.3 Version: Final Platform: x86-64 OS/Version: openSUSE 10.3 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: ken@turnkey.com.au QAContact: qa@suse.de Found By: Customer At lines 159-162 there are 4 definitions of compatibility functions for init scripts on LSB and other non-SUSE systems. The returns in there are wrong. Errors like this happen on SUSE: line 162: return: /sbin/checkproc: numeric argument required In bash, "return" in a function takes a numeric argument, not the status of a command. To return the status of the command, as it's the last one, just omit the return, like this: start_daemon() { /sbin/start_daemon ${1+"$@"}; } killproc() { /sbin/killproc ${1+"$@"}; } pidofproc() { /sbin/pidofproc ${1+"$@"}; } checkproc() { /sbin/checkproc ${1+"$@"}; } It's a wonder nobody spotted this before, nobody must have attempted to use the template on SUSE since it was written, or at least not reported the problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=351386 Cyril Hrubis <chrubis@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |ro@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=351386 User ro@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=351386#c1 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |garloff@novell.com --- Comment #1 from Ruediger Oertel <ro@novell.com> 2008-01-08 11:00:40 MST --- Kurt, as author ... any objections ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=351386 User garloff@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=351386#c2 Kurt Garloff <garloff@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |garloff@novell.com Status|NEEDINFO |NEW Info Provider|garloff@novell.com | --- Comment #2 from Kurt Garloff <garloff@novell.com> 2008-01-11 02:54:10 MST --- No objections, sir. Thanks or reporting! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=351386 User ro@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=351386#c3 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Ruediger Oertel <ro@novell.com> 2008-01-11 03:50:44 MST --- ok, change applied for STABLE/FACTORY -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com