[Bug 672045] New: hxtools sets EDITOR=mcedit
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c0 Summary: hxtools sets EDITOR=mcedit Classification: openSUSE Product: openSUSE 11.4 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: wstephenson@novell.com QAContact: qa@suse.de CC: jengelh@medozas.de Found By: --- Blocker: --- Which is intrusive, it should use a hxtools-local variable instead of messing with the system EDITOR. Alternatively hxtools shouldn't be pulled into a factory install. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c1 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com --- Comment #1 from Jan Engelhardt <jengelh@medozas.de> 2011-02-15 11:29:35 UTC --- I have an update ready in home:jengelh:dev/hxtools. Now there are two showstoppers: 1. I wanted this to go into the utilities: devel project, which mrdocs has hold up 2. coolo set the dp to devel:libraries:c_c++ (despite it being not a library) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c2 --- Comment #2 from P Linnell <mrdocs@opensuse.org> 2011-02-15 11:44:28 UTC --- Hi, I did not hold up the package. It was declined because of uneeded and unwanted removal of the build root in the %install. You are free to re-submit with fixes or comments. When reviewing packages, I try to ensure the spec files are readable not just for me, but for others who might review them in the future. That's all. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c3 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |SHIP_STOPPER+ --- Comment #3 from Stephan Kulow <coolo@novell.com> 2011-02-15 12:51:43 CET --- if the devel project name is a a show stopper for you, I remove the package in openSUSE:Factory again. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c4 --- Comment #4 from Jan Engelhardt <jengelh@medozas.de> 2011-02-15 11:57:54 UTC ---
1. o="$PWD"; b="%buildroot"; rm -Rf "$b"; in %install is a no no see: http://lists.opensuse.org/opensuse-packaging/2007-02/msg00005.html
Quoting the post:
If you want to do it [...]: %install rm -rf $RPM_BUILD_ROOT mkdir $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT/usr ... or make install
Which the spec file does (save $RPM_BUILD_ROOT <=> %buildroot). Confused. Remove rm -Rf or not. Now just tell me which. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c5 --- Comment #5 from Jan Engelhardt <jengelh@medozas.de> 2011-02-15 12:02:31 UTC --- sr 61240,61242 to devel:libraries:c_c++. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c6 --- Comment #6 from Jan Engelhardt <jengelh@medozas.de> 2011-02-15 12:22:54 UTC --- coolo: I checked the package lists, and was surprised to see pam_mount being part of the default install lists. Do you think pam_mount is this essential? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c7 --- Comment #7 from P Linnell <mrdocs@opensuse.org> 2011-02-15 12:25:31 UTC ---
Remove rm -Rf or not. Now just tell me which.
Ok. Here is how the large majority of packages I see all over the place in OBS: %install nothing but install stuff %clean rm -rf %buildroot Simpler, cleaner and easier to read. %clean is *the* macro to clean the buildroot, no need to repeat... OBS automatically removes all buildroots anyways. The french have a saying: "Why prefer the simple, when the complicated will do?" :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c8 --- Comment #8 from Stephan Kulow <coolo@novell.com> 2011-02-15 13:33:31 CET --- @#6: it's not installed by default, yast2-storage requires it in case of encryption. So all installation media (including the live cds) have it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c9 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jslaby@novell.com --- Comment #9 from Jan Engelhardt <jengelh@medozas.de> 2011-02-16 19:52:46 UTC --- *** Bug 672700 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=672700 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c10 --- Comment #10 from Jan Engelhardt <jengelh@medozas.de> 2011-02-16 19:56:11 UTC --- Also created sr 61517. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |jengelh@medozas.de |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c11 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Platform|Other |All Resolution| |FIXED Target Milestone|--- |RC 2 OS/Version|Other |Linux --- Comment #11 from Jan Engelhardt <jengelh@medozas.de> 2011-02-18 19:19:36 UTC --- This was accepted to o:F on Fri, 18 Feb 2011 12:29:07 UTC. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c12 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-beta@cboltz.de --- Comment #12 from Jan Engelhardt <jengelh@medozas.de> 2011-02-18 19:24:37 UTC --- *** Bug 671545 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=671545 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Factory |RC 1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c13 --- Comment #13 from Jan Engelhardt <jengelh@medozas.de> 2011-02-21 09:49:52 UTC --- (In reply to comment #7)
Ok. Here is how the large majority of packages I see all over the place in OBS:
%install nothing but install stuff
%clean rm -rf %buildroot
Simpler, cleaner and easier to read.
But does not work very well if you reuse the BS chroot to debug and rerun rpmbuild, perhaps even with --short-circuit, before attempting a new osc build run.
%clean is *the* macro to clean the buildroot, no need to repeat... OBS automatically removes all buildroots anyways.
The french have a saying: "Why prefer the simple, when the complicated will do?" :)
Then by your very saying, why do packages even use %clean? It only makes debugging of a built software harder because it immediately kills the compiled unit. (Omitting %clean and chrooting is _the_ way to do a quick analysis as mentioned above.) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c14 --- Comment #14 from Jan Engelhardt <jengelh@medozas.de> 2011-02-25 17:41:34 UTC --- *** Bug 671545 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=671545 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=672045 https://bugzilla.novell.com/show_bug.cgi?id=672045#c Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com