[Bug 443363] New: cdrdao-1.2.2-308.17: 2 * suspicious delete code
https://bugzilla.novell.com/show_bug.cgi?id=443363 Summary: cdrdao-1.2.2-308.17: 2 * suspicious delete code Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just checked some of the source code in the Suse Linux factory package cdrdao-1.2.2-308.17 and I noticed the following $ egrep -n "new|delete" ../BUILD/cdrdao-1.2.2/dao/CdrDriver.cc | fgrep toc 1645: toc = new CdToc[nTracks + 1]; 3461: delete toc; 3489: Toc *toc = new Toc; I guess lines 1645 and 3461 are supposed to match, but they don't. Maybe delete [] toc; toc = NULL; would be better. Also, I don't understand where the matching delete for line 3489 is. Maybe it has been forgotten. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=443363
Cyril Hrubis
https://bugzilla.novell.com/show_bug.cgi?id=443363
Vladimir Nadvornik
participants (1)
-
bugzilla_noreply@novell.com