[Bug 888142] New: qemu-2.1rc2 stalls VNC updates
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c0 Summary: qemu-2.1rc2 stalls VNC updates Classification: openSUSE Product: openSUSE Factory Version: 201407* Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: KVM AssignedTo: kvm-bugs@forge.provo.novell.com ReportedBy: coolo@suse.com QAContact: jdouglas@suse.com Found By: Development Blocker: --- I updated qemu on openqa.opensuse.org to the version in factory (compiled in devel:openQA) and we see missing redraws. openQA uses VNC protocol to get the screen updates and in 20-25% of all cases it fails to pass the bootloader test as its stuck in a state like this: https://openqa.opensuse.org/tests/12844/modules/bootloader/steps/3 (it should read console=tty but reads console=ttty) And when I connect to qemu with a 2nd VNC client, the redraws kick in out of the sudden. I compiled qemu from factory sources and the VNC worker thread gets stuck in vnc-jobs.c in this code: 224 while (QTAILQ_EMPTY(&queue->jobs) && !queue->exit) { 225 qemu_cond_wait(&queue->cond, &queue->mutex); 226 } (the line numbers are off due to my adding debug output). Somehow there are never jobs in the queue, so the thread is not continueing sending updates. I'm going back to 2.0, but if you have an idea how to continue debugging this, let me know. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c Bruce Rogers <brogers@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brogers@suse.com AssignedTo|kvm-bugs@forge.provo.novell |agraf@suse.com |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c1 --- Comment #1 from Stephan Kulow <coolo@suse.com> 2014-07-23 11:51:22 CEST --- I found the 2.1 regression. !incremental is ignored. vs->need_update = 1; - if (!incremental) { - vs->force_update = 1; - for (i = 0; i < h; i++) { - bitmap_set(vs->dirty[y_position + i], 0, width); - bitmap_clear(vs->dirty[y_position + i], width, - VNC_DIRTY_BITS - width); - } + + if (incremental) { + return; } the vs->force_update = 1; was lost in 2.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c2 --- Comment #2 from Stephan Kulow <coolo@suse.com> 2014-07-23 15:50:07 CEST --- Sent kraxel this: commit 29e2d30a1dbe56329058454d832a628fac376583 Author: Stephan Kulow <coolo@suse.de> Date: Wed Jul 23 15:43:29 2014 +0200 fix full frame updates for VNC clients If the client asks for !incremental frame updates, it has lost its content so dirty doesn't matter - it has to see the full frame, so setting force_update diff --git a/ui/vnc.c b/ui/vnc.c index 01f72a7..edfaf75 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1893,6 +1893,7 @@ static void framebuffer_update_request(VncState *vs, int incremental, return; } + vs->force_update = 1; vnc_set_area_dirty(vs->dirty, width, height, x, y, w, h); } -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c Andreas Färber <afaerber@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |afaerber@suse.com AssignedTo|agraf@suse.com |afaerber@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c3 --- Comment #3 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-08-01 11:00:59 CEST --- This is an autogenerated message for OBS integration: This bug (888142) was mentioned in https://build.opensuse.org/request/show/243344 Factory / qemu -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=888142 https://bugzilla.novell.com/show_bug.cgi?id=888142#c4 Stephan Kulow <coolo@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |FIXED --- Comment #4 from Stephan Kulow <coolo@suse.com> 2014-09-12 15:48:19 CEST --- fixed -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com