[Bug 1207462] New: Outdated information about temporary disabling of patches
http://bugzilla.opensuse.org/show_bug.cgi?id=1207462 Bug ID: 1207462 Summary: Outdated information about temporary disabling of patches Classification: openSUSE Product: openSUSE.org Version: unspecified Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Wiki Assignee: suse-beta@cboltz.de Reporter: ralf.habacker@freenet.de QA Contact: adrian.schroeter@suse.com Found By: --- Blocker: --- At https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Type_1:_minima... there is mentioned:
Special case: we often have patches that get commented out temporarily because they failed to apply to the latest sources, and the patches need to be rebased. Do not comment out the patch's declaration, but do comment out its application.
This statement seems to be deprecated as more and more packages use %autosetup where %patch lines are no longer used. Instead, the associated patch line PatchXX: ... would be commented out. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1207462 http://bugzilla.opensuse.org/show_bug.cgi?id=1207462#c1 --- Comment #1 from Christian Boltz <suse-beta@cboltz.de> --- It's a wiki, so feel free to update it yourself ;-) Note that not all packages use %autopatch, therefore ideally both ways should be documented. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1207462 http://bugzilla.opensuse.org/show_bug.cgi?id=1207462#c2 --- Comment #2 from Ralf Habacker <ralf.habacker@freenet.de> --- (In reply to Christian Boltz from comment #1)
It's a wiki, so feel free to update it yourself ;-)
Yes, I will
Note that not all packages use %autopatch, therefore ideally both ways should be documented.
To get this hint, I opened this ticket. ;-) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1207462 http://bugzilla.opensuse.org/show_bug.cgi?id=1207462#c3 --- Comment #3 from Ralf Habacker <ralf.habacker@freenet.de> --- (In reply to Ralf Habacker from comment #2)
(In reply to Christian Boltz from comment #1)
It's a wiki, so feel free to update it yourself ;-)
I'm going to change https://en.opensuse.org/index.php?title=openSUSE:Packaging_Patches_guidelines&action=submit#Type_1:_minimal_single-line_comment_in_spec_file after the patch list to: and later in the %prep section %autopatch -p1 ... or if not all patches are applicable with -p1 [...] %patch7 Special case when using %patch: We often have patches that are temporarily commented out because they are not applicable to the latest sources, and the patches need to be rebased. Do not comment out the declaration of the patch, but comment out its application. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1207462 http://bugzilla.opensuse.org/show_bug.cgi?id=1207462#c4 Ralf Habacker <ralf.habacker@freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Ralf Habacker <ralf.habacker@freenet.de> --- The proposed adjustments were taken over in https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Type_1%3A_mini.... -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com