[Bug 755136] New: patch command failes architecture dependent
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c0 Summary: patch command failes architecture dependent Classification: openSUSE Product: openSUSE 12.1 Version: Final Platform: i686 OS/Version: openSUSE 12.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: sledz@zone42.org QAContact: qa-bugs@suse.de Found By: --- Blocker: --- Created an attachment (id=484321) --> (http://bugzilla.novell.com/attachment.cgi?id=484321) Archive to reproduce the bug User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0 Depending on the architecture the patch command fails with "can't find file to patch" in some situations. Behaviour can be reproduced e.g. on i686 but not on x86_64. Reproducible: Always Steps to Reproduce: 1. Untar attached file: tar xvf patch.bug.tar 2. cd patch.bug/bash-3.2 3. patch --dry-run -p0 < ../bash32-001 Actual Results: Ignoring potentially dangerous file name ../bash-3.2/parse.y patching file parse.y Ignoring potentially dangerous file name ../bash-3.2/patchlevel.h can't find file to patch at input line 35 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |*** ../bash-3.2/patchlevel.h Thu Apr 13 08:31:04 2006 |--- patchlevel.h Mon Oct 16 14:22:54 2006 -------------------------- File to patch: ^C Expected Results: Ignoring potentially dangerous file name ../bash-3.2/parse.y patching file parse.y Ignoring potentially dangerous file name ../bash-3.2/patchlevel.h patching file patchlevel.h # rpm -q -i patch Name : patch Version : 2.6.1.116 Release : 4.1.5 Architecture: i586 Install Date: Sat Nov 19 18:03:12 2011 Group : Productivity/Text/Utilities Size : 169579 License : GPLv3+ Signature : RSA/SHA256, Sat Oct 29 03:49:29 2011, Key ID b88b2fd43dbdc284 Source RPM : patch-2.6.1.116-4.1.5.src.rpm Build Date : Sat Oct 29 03:49:12 2011 Build Host : build09 Relocations : (not relocatable) Packager : http://bugs.opensuse.org Vendor : openSUSE URL : ftp://alpha.gnu.org/gnu/diffutils/ Summary : GNU patch Description : The GNU patch program is used to apply diffs between original and changed files (generated by the diff command) to the original files. Authors: -------- Larry Wall Paul Eggert Distribution: openSUSE 12.1 # arch i686 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c kk zhang <kkzhang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkzhang@novell.com AssignedTo|bnc-team-screening@forge.pr |jdelvare@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c Steffen Sledz <sledz@zone42.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|patch command failes |patch command fails |architecture dependent |architecture dependent -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c1 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Other |Development --- Comment #1 from Jean Delvare <jdelvare@suse.com> 2012-04-04 16:46:27 UTC --- I can reproduce this thanks to the test case your provided. I admit this architecture-specific behavior is very odd. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c2 --- Comment #2 from Jean Delvare <jdelvare@suse.com> 2012-04-04 16:48:46 UTC --- Note that valgrind reports invalid memory reads, with both the i586 and the x86_64 binaries. Don't know if this is related, but this may well be, as valgrind doesn't report such invalid reads when applying a "normal" patch file. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c3 --- Comment #3 from Jean Delvare <jdelvare@suse.com> 2012-04-05 14:50:09 UTC --- I packaged the last available alpha snapshot (2.6.1.136) but it doesn't solve the bug. Next step is testing with the latest snapshot from the git repository. I have also asked upstream to release at least another alpha snapshot as the last one is almost one year old. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c4 --- Comment #4 from Jean Delvare <jdelvare@suse.com> 2012-04-06 11:19:35 UTC --- Bug is still present upstream, introduced by commit e0f707523cab26f74ec23f4a20a27add8702ed5b Author: Jim Meyering <meyering@redhat.com> Date: Thu Feb 17 09:59:56 2011 +0100 don't warn twice about the same invalid file name * src/pch.c (name_is_valid): Don't warn about the same name twice. * tests/bad-filenames (emit_patch): Exercise the new code. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c5 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |sledz@zone42.org --- Comment #5 from Jean Delvare <jdelvare@suse.com> 2012-04-06 13:31:18 UTC --- Fixed package available at: https://build.opensuse.org/package/show?package=patch&project=devel%3Atools Please give it a try and report. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c6 Steffen Sledz <sledz@zone42.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|sledz@zone42.org | --- Comment #6 from Steffen Sledz <sledz@zone42.org> 2012-04-06 20:21:53 CEST --- Bingo! Seems to be fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c7 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Severity|Normal |Minor --- Comment #7 from Jean Delvare <jdelvare@suse.com> 2012-04-10 13:09:44 UTC --- Thanks for testing. I've pushed the updated package to Factory. I don't think it is worth a maintenance update for openSUSE 12.1 as the issue only happens in rare cases. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c8 --- Comment #8 from Steffen Sledz <sledz@zone42.org> 2012-04-10 15:13:28 CEST --- I don't agree in this, patch is (like tar) a basic command in package management itself. It should work in every case! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c9 --- Comment #9 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-04-10 16:00:08 CEST --- This is an autogenerated message for OBS integration: This bug (755136) was mentioned in https://build.opensuse.org/request/show/113094 Factory / patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c10 --- Comment #10 from Jean Delvare <jdelvare@suse.com> 2012-04-10 16:36:55 UTC --- No, patch isn't a basic command. Most users can live without patch at all, it's not even installed by default. It is a developer tool. Plus, it's not failing on all patches, only some with weird headers. It's easy enough to edit the faulty patch to get it to apply. With such a low impact and easy workaround, there is simply no rationale for a maintenance update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c11 --- Comment #11 from Steffen Sledz <sledz@zone42.org> 2012-04-10 19:31:55 CEST --- OK. You convinced me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c12 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #12 from Jean Delvare <jdelvare@suse.com> 2012-04-12 12:33:59 UTC --- Fix is in Factory now, closing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c13 --- Comment #13 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-03-21 18:00:07 CET --- This is an autogenerated message for OBS integration: This bug (755136) was mentioned in https://build.opensuse.org/request/show/160492 Maintenance / -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=755136 https://bugzilla.novell.com/show_bug.cgi?id=755136#c14 --- Comment #14 from Swamp Workflow Management <swamp@suse.de> 2013-04-03 15:04:56 UTC --- openSUSE-RU-2013:0600-1: An update that has two recommended fixes can now be installed. Category: recommended (moderate) Bug References: 755136,794658 CVE References: Sources used: openSUSE 12.1 (src): patch-2.6.1.116-4.4.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com