[Bug 1103679] New: updater applet notification madness
http://bugzilla.suse.com/show_bug.cgi?id=1103679 Bug ID: 1103679 Summary: updater applet notification madness Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.0 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: KDE Workspace (Plasma) Assignee: opensuse-kde-bugs@opensuse.org Reporter: lnussel@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Created attachment 778823 --> http://bugzilla.suse.com/attachment.cgi?id=778823&action=edit screenshot The updater applet is rather aggressive with it's notifications, see screenshot. Doesn't for example make sense to ask for reboot when the update that requires the reboot wasn't actually installed due to the error. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1103679
http://bugzilla.suse.com/show_bug.cgi?id=1103679#c1
Fabian Vogt
Created attachment 778823 [details] screenshot
The updater applet is rather aggressive with it's notifications, see screenshot. Doesn't for example make sense to ask for reboot when the update that requires the reboot wasn't actually installed due to the error.
It looks like the zypp backend emits restartrequired: a) At the beginning of the transaction, before anything is done b) For simulations as well I had already prepared a patch which rewrites the onRestartRequired handling but never got around to test it. It results in only reporting the most severe type (pk restart -> logout -> reboot) after the end of actual transactions, so should fix this as well. I'll give it a try. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1103679
http://bugzilla.suse.com/show_bug.cgi?id=1103679#c2
Fabian Vogt
(In reply to Ludwig Nussel from comment #0)
Created attachment 778823 [details] screenshot
The updater applet is rather aggressive with it's notifications, see screenshot. Doesn't for example make sense to ask for reboot when the update that requires the reboot wasn't actually installed due to the error.
It looks like the zypp backend emits restartrequired:
a) At the beginning of the transaction, before anything is done b) For simulations as well
I had already prepared a patch which rewrites the onRestartRequired handling but never got around to test it. It results in only reporting the most severe type (pk restart -> logout -> reboot) after the end of actual transactions, so should fix this as well. I'll give it a try.
Seems to work here. Please have a try with the packages from https://build.opensuse.org/package/show/home:Vogtinator:ppu/plasma5-pk-updat... It would be more complete to check whether the package which requested the reboot got installed successfully, but it's not really possible with the PKit API to tell at which point the transaction failed and how severe the failure is. As errors like the one in the screenshot should appear in the simulation it should never get to the point to show the restart notifications. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1103679
http://bugzilla.suse.com/show_bug.cgi?id=1103679#c3
Ludwig Nussel
https://bugzilla.suse.com/show_bug.cgi?id=1103679
https://bugzilla.suse.com/show_bug.cgi?id=1103679#c4
Fabian Vogt
participants (2)
-
bugzilla_noreply@novell.com
-
bugzilla_noreply@suse.com