[Bug 610313] New: yast2-gtk: textdomain missing in most of source files
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c0 Summary: yast2-gtk: textdomain missing in most of source files Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 AssignedTo: rpmcruz@alunos.dcc.fc.up.pt ReportedBy: jsrain@novell.com QAContact: jsrain@novell.com Found By: Development Blocker: --- The text domain is missing in the source files of yast2-gtk: This results in the texts not being passed for translations. y2makepot reports appropriate errors. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c1 Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpmcruz@alunos.dcc.fc.up.pt --- Comment #1 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-08 14:33:36 UTC --- Well, given only the gtk-pkg code makes intensive use of strings, I have not added such text to every single file. But if you're getting errors, I sure will. Anyway, do clarify the urgency of the matter. The messages you're getting are not critical errors, but only cosmetic warnings, right? I mean, the build does work? If that's the case, I would feel more comfortable applying the changes to trunk post-11.3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |jsrain@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c2 Jiri Srain <jsrain@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|jsrain@novell.com | --- Comment #2 from Jiri Srain <jsrain@novell.com> 2010-06-08 14:47:15 UTC --- Of course, build works, the only problem is that the text don't get their way to the .pot-file and will not be passed for translations. The urgency depends on whether it should be fixed into 11.3 or not. However, I don't dare to say as it affects only unimportant strings: Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/YGTable.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/ygtktreeview.c Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgmenubar.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgfilterview.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/yzypptags.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgstatusbar.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgrpmgroupsview.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgpatternview.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgdetailview.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkghistorydialog.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgundolist.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkglistview.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgsearchentry.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/YGPackageSelector.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/ygtkpkgproductdialog.cc Warning: empty textdomain in /local/svn/yast/trunk/gtk/./src/pkg/yzyppwrapper.cc Creating ./yast2-gtk.pot from ./src/YGProgressBar.cc ./src/YGUI.cc /src/YGUtils.cc ./src/ygtksteps.c ./src/ygtkwizard.c ... The fact that they are translated in last milestone does not mean it will be translated in GA - if the textdomain was removed at some point of time, next snapshot of the .pot-file did not contain the texts and they will be removed from the final translations. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c3 --- Comment #3 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-08 15:33:51 UTC --- So, all those files with errors do have the Textdomain comment, but it is as: /* Textdomain "yast2-gtk" */ instead of the successful ones: /* Textdomain "yast2-gtk" */ This was always the case since their inception. Is the y2makepot tool picker now? :) I sure think we should correct this for 11.3 if it means no i18n. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c4 --- Comment #4 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-08 16:47:50 UTC --- (In reply to comment #3)
This was always the case since their inception. Is the y2makepot tool picker now? :)
Okay, so all those are post-11.2 files, so the i18n build only hit the problem now. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c5 Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |jsrain@novell.com --- Comment #5 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-08 16:50:20 UTC --- Jiri, submitted fixed files to build-service. Tell me if there is anything more I should do. I am also curious if this means the software manager UI will be shipped in English. :( Will at least common strings with the 11.2 release be picked up? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c6 --- Comment #6 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-08 16:51:54 UTC --- By the way, thank you so much for spotting the problem, and bringing it to my attention. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c7 Jiri Srain <jsrain@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW CC| |jsrain@novell.com InfoProvider|jsrain@novell.com | AssignedTo|rpmcruz@alunos.dcc.fc.up.pt |ke@novell.com --- Comment #7 from Jiri Srain <jsrain@novell.com> 2010-06-09 05:56:02 UTC --- I have submitted new .pot-file to the i18n SVN. Karl, please, merge the already translated texts and pass the remaining strings to translators so that we get the package selector translated at least in some languages, thanks! -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c8 Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #8 from Karl Eichwalder <ke@novell.com> 2010-06-09 08:15:45 UTC --- Thanks for your help, Jiri! Merging is running now. I'll try to recover as much as possible from the memory files and the 11.2 branch. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c9 --- Comment #9 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-09 12:21:12 UTC --- Appreciated Karl! Do tell me where I can locate those files. I know some people who will be happy to review them. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c10 --- Comment #10 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-09 18:45:25 UTC --- FYI: [obs submit-request 41268] openSUSE:Factory/yast2-gtk: accepted by autobuild -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c11 Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |RC 1 --- Comment #11 from Karl Eichwalder <ke@novell.com> 2010-06-14 07:57:21 UTC --- (In reply to comment #9)
Do tell me where I can locate those files. I know some people who will be happy to review them.
yast translations are in the opensuse-i18n SVN at BerliOS.de: for more info, see http://en.opensuse.org/OpenSUSE_Localization_Guide . Last week, I submitted the updated yast2-trans package. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c12 --- Comment #12 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-14 14:30:29 UTC --- Created an attachment (id=368982) --> (http://bugzilla.novell.com/attachment.cgi?id=368982) PT translation Here's the PT file reviewed. I noticed that major languages like French (fr), Spanish (es) and Brazilian Portuguese (pt_BR) are all fully translated already. Very cool. German (de) isn't however. Will try to get someone to review that one. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c13 --- Comment #13 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-14 14:32:03 UTC --- Karl, please commit the PT file from comment 12. No need to submit this already to build-service just now. Let's see if we can get at least the German one reviewed too. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c14 Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #14 from Karl Eichwalder <ke@novell.com> 2010-06-14 14:45:52 UTC --- Thanks for your help! I guess or hope that I can add a translation update for RC2. Thus, reopening. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c15 --- Comment #15 from Karl Eichwalder <ke@novell.com> 2010-06-16 09:43:35 UTC --- Created an attachment (id=369476) --> (http://bugzilla.novell.com/attachment.cgi?id=369476) Gnome desktop with an xterm open -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c16 Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #369476|0 |1 is obsolete| | --- Comment #16 from Karl Eichwalder <ke@novell.com> 2010-06-16 09:45:59 UTC --- (From update of attachment 369476) wrong bug; it belongs to bug 614651 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c17 Martin Kudlvasr <mkudlvasr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tilman@imap.cc --- Comment #17 from Martin Kudlvasr <mkudlvasr@novell.com> 2010-06-23 15:53:26 UTC --- *** Bug 608802 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=608802 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c18 Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com AssignedTo|ke@novell.com |opensuse-translation-de@ope | |nsuse.org Target Milestone|RC 1 |RC 2 --- Comment #18 from Karl Eichwalder <ke@novell.com> 2010-06-25 12:31:40 UTC --- Not sure, whether this counts as a ship stopper: msgfmt --stat de/po/yast2-gtk.de.po 141 translated messages, 93 fuzzy translations, 18 untranslated messages. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c19 --- Comment #19 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-25 14:54:37 UTC --- By the way, noticed this mistake in the German PO file: #: src/pkg/yzyppwrapper.cc:147 msgid " of " msgstr "von" Treacherous trailing whites-spaces... Will avoid using them in the future. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c20 --- Comment #20 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-06-27 13:04:54 UTC --- I had someone (In reply to comment #12)
German (de) isn't however. Will try to get someone to review that one.
Sorry, that guy just told me he has been unable to have a take at it. Contact me if you need assistance. I have posted some thoughts to translators here: http://groups.google.com/group/yast2-gtk/browse_thread/thread/2517efcb01d21f... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |617672 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c Karl Eichwalder <ke@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|617672 | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c21 --- Comment #21 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2010-07-05 11:17:19 UTC --- Guys, the following PO file is still the out-dated one. Check my comment 12 for a revised one. https://svn.berlios.de/svnroot/repos/opensuse-i18n/trunk/yast/pt/po/yast2-gt... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c22 --- Comment #22 from Karl Eichwalder <ke@novell.com> 2010-07-05 13:14:34 UTC --- (In reply to comment #21)
Guys, the following PO file is still the out-dated one. Check my comment 12 for a revised one.
https://svn.berlios.de/svnroot/repos/opensuse-i18n/trunk/yast/pt/po/yast2-gt...
In SVN now. I also fixed #19 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=610313 https://bugzilla.novell.com/show_bug.cgi?id=610313#c23 Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #23 from Ricardo Cruz <rpmcruz@alunos.dcc.fc.up.pt> 2011-08-26 22:24:04 UTC --- Should be fixed by now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=610313 http://bugzilla.novell.com/show_bug.cgi?id=610313#c24 --- Comment #24 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (610313) was mentioned in https://build.opensuse.org/request/show/42486 Factory / yast2-trans https://build.opensuse.org/request/show/42610 11.3 / yast2-trans -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com