[Bug 539521] New: installer shows wrong partition size while formatting swap partition
http://bugzilla.novell.com/show_bug.cgi?id=539521 Summary: installer shows wrong partition size while formatting swap partition Classification: openSUSE Product: openSUSE 11.2 Version: Milestone 7 Platform: x86 OS/Version: SuSE Other Status: NEW Severity: Minor Priority: P5 - None Component: Installation AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: patz1983@googlemail.com QAContact: jsrain@novell.com Found By: --- User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.13) Gecko/2009080200 SUSE/3.0.13-0.1 Firefox/3.0.13 i was installing opensuse 11.2 milestone 7. the hdd i used was a western digital wd600ab-32cza0 . the drive is pata and 60GB in size (55.7 if you do your maths correct). the drive contained a single ext3 partition before the installation. i didn't alter the partition setup suggestet by the installer. when the installer did the formatting of the swap partition, the screen output read something like: formatting swap partition (55.7 GB) the size of the swap partition is <2GB (don't remember the exact size) and it is apparently formatted correctly. the size of root and home partition were displayed correctly. its not really a major bug, but might be a bit scary if you have other partitions on the drive and don't know if your data is gone. Reproducible: Didn't try Steps to Reproduce: 1. 2. 3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 User aj@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=539521#c1 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |patz1983@googlemail.com --- Comment #1 from Andreas Jaeger <aj@novell.com> 2009-10-02 05:36:15 MDT --- Please add the YaST log files for this as described at http://en.opensuse.org/Bugs/YaST -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 Martin Vidner <mvidner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |aschnell@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 User patz1983@googlemail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=539521#c2 Matthias Patz <patz1983@googlemail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|patz1983@googlemail.com | --- Comment #2 from Matthias Patz <patz1983@googlemail.com> 2009-10-07 08:34:39 MDT --- Created an attachment (id=321497) --> (http://bugzilla.novell.com/attachment.cgi?id=321497) tar of the yast2 logs -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 User aschnell@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=539521#c3 Arvin Schnell <aschnell@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED --- Comment #3 from Arvin Schnell <aschnell@novell.com> 2009-10-07 08:56:37 MDT --- For some reason YaST shows the old size: sda1 (55.90 GB) is deleted, then created (2.01 GB) and during format 55.90 GB is shown. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 User aschnell@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=539521#c4 Arvin Schnell <aschnell@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|aschnell@novell.com |kernel-maintainers@forge.pr | |ovo.novell.com --- Comment #4 from Arvin Schnell <aschnell@novell.com> 2009-10-07 09:36:23 MDT --- The information YaST reads from /proc/partitions is outdated. After deleting sda1 /proc/partition still includes sda1. Even after creating sda1 the entry in /proc/partitions contains the old size. Only after creating sda2 the entires is /proc/partitions are correct. Looks like a kernel or communication problem between kernel and parted. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c5 Thomas Fehr <fehr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fehr@novell.com --- Comment #5 from Thomas Fehr <fehr@novell.com> 2009-11-23 14:46:44 UTC --- I can reproduce the problem without needing to use YaST2 but only by calling parted from the commandline. At the beginning I have a disk with an empty partition table, the I use parted to create a partition there. This partition correctly shows up in /proc/partitions. Afterwards I use parted to remove the newly created partition again. This succeeds in parted but the removed partition still shows up in /proc/partition. Only after explicitely telling the kernel to re-read the partition table on the disk the removed partition vanishes from /proc/partitions. I can reproduce the problem with openSuSE 11.2 on two different machine one with kernel 2.6.31.3-1-default and the other one with kernel 2.6.31.5-0.1-default. See following console log: Lagrange:~ # cat /proc/partitions | grep sdb 8 16 244198584 sdb Lagrange:~ # parted /dev/sdb mkpart primary 0 100000 Information: You may need to update /etc/fstab. Lagrange:~ # cat /proc/partitions | grep sdb 8 16 244198584 sdb 8 17 97656250 sdb1 Lagrange:~ # parted /dev/sdb rm 1 Information: You may need to update /etc/fstab. Lagrange:~ # cat /proc/partitions | grep sdb 8 16 244198584 sdb 8 17 97656250 sdb1 Lagrange:~ # blockdev --rereadpt /dev/sdb Lagrange:~ # cat /proc/partitions | grep sdb 8 16 244198584 sdb Lagrange:~ # -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c6 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kernel-maintainers@forge.pr |bnc-team-screening@forge.pr |ovo.novell.com |ovo.novell.com --- Comment #6 from Jeff Mahoney <jeffm@novell.com> 2009-11-25 20:39:12 UTC --- This isn't a kernel problem. It's working as expected, as documented by Thomas's test in comment #5. parted is a normal program that writes to a block device directly. From the kernel's perspective, there is no difference between it, mkfs, or fsck. Until the kernel is notified that the partition table has changed, it will use the old partitions. blockdev --rereadpt is how the kernel is notified. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c7 Thomas Fehr <fehr@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeffm@novell.com --- Comment #7 from Thomas Fehr <fehr@novell.com> 2009-11-26 10:00:24 UTC --- Of course comment 5 clearly shows that it is not working as expected. Of course parted tells the kernel about modified partitions (it uses the BLKPG ioctl for this while blockdev uses BLKRRPART ioctl). If parted would not tell kernel about modified partitions no installation involving modifications of partitions since at least 5 year could have succeeded. Some more info I gathered during testing: - the problem seems to only occur when the last partition on a disk is removed - the problem does not occur everytime, so there might be timing issues or access to random memory content involved. On the two different machines I tested the problem occured in more than 50 percent of the tests I did. - for strange reasons the problem does not seem to happen if the parted call is straced. From the strace output one sees that the parted correctly calls the BLKPG ioctls. Unfortunately the content of blkpg_ioctl_arg and blkpg_partition are not displayed by strace so one cannot be really sure if parted provided correct content in ioctl data to kernel. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c8 Arvin Schnell <aschnell@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P2 - High Severity|Minor |Critical --- Comment #8 from Arvin Schnell <aschnell@novell.com> 2009-11-30 14:12:09 UTC --- Mismatches between partition layouts "on disk" and "in kernel data" can lead to data loss. E.g. during mkfs the device is still 55 GB big. But after the next reboot the device is suddenly only 2 GB big so the filesystem cannot access all of it's data anymore. Increasing Severity and Pririty. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c9 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |jeffm@novell.com |ovo.novell.com | --- Comment #9 from Jeff Mahoney <jeffm@novell.com> 2009-11-30 18:28:25 UTC --- Since the strace output is useless and would be useful for debugging this issue, I implemented blockdev support for strace. The packages are building now but will be available here: http://download.opensuse.org/repositories/home:/jeff_mahoney:/branches:/open... I'll take another look at it after lunch, but at a quick glance it looks like parted tries to remove everything and add it again and see what works. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c10 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kasievers@novell.com --- Comment #10 from Jeff Mahoney <jeffm@novell.com> 2009-11-30 19:30:40 UTC --- I have a script that fails quickly on this. It creates and destroys a partition in a loop, failing when a partition exists (or doesn't) when it shouldn't (or should). It writes out the strace output for each operation and breaks out when there is a failure for analysis. ----->8----- parted /dev/sda mkpart logical 87.8GB 120GB while true; do strace -o strace.out parted /dev/sda rm 13 if grep sda13 /proc/partitions; then echo FAIL1 break fi strace -o strace.out parted /dev/sda mkpart logical 87.8GB 120GB if ! grep sda13 /proc/partitions; then echo FAIL2 break fi done -----8<----- Here's what I got: ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=1, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=2, devname="", volname=""}}) = 0 ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=3, devname="", volname=""}}) = -1 ENXIO (No such device or address) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=4, devname="", volname=""}}) = -1 ENXIO (No such device or address) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=5, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=6, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=7, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=8, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=9, devname="", volname=""}}) = 0 ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=10, devname="", volname=""}}) = 0 ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=11, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=12, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=13, devname="", volname=""}}) = -1 EBUSY (Device or resource busy) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=14, devname="", volname=""}}) = -1 ENXIO (No such device or address) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=15, devname="", volname=""}}) = -1 ENXIO (No such device or address) ioctl(3, BLKPG, {BLKPG_DEL_PARTITION, flags=0, datalen=152, {start=0, length=0, pno=16, devname="", volname=""}}) = -1 ENXIO (No such device or address) ioctl(3, BLKPG, {BLKPG_ADD_PARTITION, flags=0, datalen=152, {start=139829760, length=512, pno=2, devname="/dev/sda2", volname=""}}) = 0 ioctl(3, BLKPG, {BLKPG_ADD_PARTITION, flags=0, datalen=152, {start=62446358016, length=6004422144, pno=9, devname="/dev/sda9", volname=""}}) = 0 ioctl(3, BLKPG, {BLKPG_ADD_PARTITION, flags=0, datalen=152, {start=68450812416, length=6448587264, pno=10, devname="/dev/sda10", volname=""}}) = 0 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c11 --- Comment #11 from Jeff Mahoney <jeffm@novell.com> 2009-11-30 19:38:28 UTC --- I only have partitions 1, 5, 6, and 7 (machine-boot, home, swap, and /) in use, so getting -EBUSY on other partitions is... unexpected. Every time a partition is added or removed, it issues a uevent. udev processes these uevents in order to add and remove device nodes, but also to scan the new devices to identify what type of file system, if any, is on the devices as well as scanning for labels and UUIDs. Or at least that's where I was going to point. Putting a udevadm settle in my script after each parted command didn't improve results. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c12 --- Comment #12 from Jeff Mahoney <jeffm@novell.com> 2009-11-30 20:05:46 UTC --- Ah, but adding a udevadm settle in there doesn't account for the fact that the race is internal to parted. In my case, every BLKPG_DEL_PARTITION but sda2 (the extended partition table) fails with either -EBUSY or -ENXIO. udev could still be processing the events. When I add a system("/sbin/udevadm settle"); after the ioctl calls in parted, it seems to work fine. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c13 Jeff Mahoney <jeffm@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jeffm@novell.com |puzel@novell.com --- Comment #13 from Jeff Mahoney <jeffm@novell.com> 2009-11-30 20:17:47 UTC --- Assigning to parted maintainer. The kernel is behaving as expected when the device is open. I'll stay on CC to follow along. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c14 --- Comment #14 from Petr Uzel <puzel@novell.com> 2009-12-01 08:18:51 UTC --- Parted upstream recently switched back to use of BLKRRPART (from BLKPG_*) ioctls, which should fix this kind of problems - I'll check and report. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c15 --- Comment #15 from Thomas Fehr <fehr@novell.com> 2009-12-01 14:13:28 UTC --- Unfortunately we will completely loose the ability to modify partitions on a disk where at least one partition is in use. This will make a lot of usage scenarios of YaST2 in installed systems impossible and it would also most probably break installation scenarios like having installation sources on the disk. So please tell us as soon as this crippled version of parted becomes part of our distribution, since it will mean a quite severe regression in functionality. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c16 --- Comment #16 from Petr Uzel <puzel@novell.com> 2009-12-04 13:54:15 UTC --- Patches [1] and [2] from parted repository remove some unnecessary open/close calls and thus avoiding unnecessary udev activity => fix the EBUSY issue for me. [1] http://git.debian.org/?p=parted/parted.git;a=commit;h=2a6936fab4d4499a4b812d... [2] http://git.debian.org/?p=parted/parted.git;a=commit;h=ad25892bb995f61b0ddf80... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:planned:update -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c22 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:planned:update |maint:running:29521 --- Comment #22 from Swamp Workflow Management <swamp@suse.com> 2009-12-10 16:34:29 UTC --- The SWAMPID for this issue is 29521. Please submit the patch and patchinfo file using this ID. (https://swamp.suse.de/webswamp/wf/29521) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c26 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #26 from Petr Uzel <puzel@novell.com> 2009-12-16 11:53:04 UTC --- Fixed -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c27 --- Comment #27 from Petr Uzel <puzel@novell.com> 2009-12-16 12:02:02 UTC --- (In reply to comment #15)
Unfortunately we will completely loose the ability to modify partitions on a disk where at least one partition is in use. This will make a lot of usage scenarios of YaST2 in installed systems impossible and it would also most probably break installation scenarios like having installation sources on the disk.
Yes, that's correct. As pointed out in [1], can't we use addpart(8), delpart(8) instead? [1] http://www.mail-archive.com/parted-devel@lists.alioth.debian.org/msg02826.ht... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c28 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:running:29521 | |maint:released:sle10-sp2:29 | |638 --- Comment #28 from Swamp Workflow Management <swamp@suse.com> 2010-01-07 23:08:40 UTC --- Update released for: parted, parted-devel Products: SLE-DEBUGINFO 10-SP2 (i386, ia64, ppc, s390x, x86_64) SLE-DESKTOP 10-SP2 (i386, x86_64) SLE-SAP-AIO 10-SP2 (x86_64) SLE-SDK 10-SP2 (i386, ia64, ppc, s390x, x86_64) SLE-SERVER 10-SP2 (i386, ia64, ppc, s390x, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c29 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:running:29521 |maint:released:sle10-sp2:29 |maint:released:sle10-sp3:29 |638 |641 --- Comment #29 from Swamp Workflow Management <swamp@suse.com> 2010-01-07 23:10:11 UTC --- Update released for: parted, parted-32bit, parted-64bit, parted-debuginfo, parted-devel, parted-x86 Products: SLE-DEBUGINFO 10-SP3 (i386, ia64, ppc, s390x, x86_64) SLE-DESKTOP 10-SP3 (i386, x86_64) SLE-SDK 10-SP3 (i386, ia64, ppc, s390x, x86_64) SLE-SERVER 10-SP3 (i386, ia64, ppc, s390x, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c30 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #30 from Petr Uzel <puzel@novell.com> 2010-01-19 17:09:28 UTC --- Reopening: it seems there is still something racing (hal?) with parted on newer distributions (at least on 11.1). -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c31 --- Comment #31 from Petr Uzel <puzel@novell.com> 2010-01-20 13:37:01 UTC --- Simple script: #!/bin/bash parted -s $/dev/sdb mkpart primary ext2 0 10M lsof +c 15 /dev/sdb1 parted -s /dev/sdb rm 1 grep sdb1 /proc/partitions && echo "FAIL" reveals that the problem is that after the partition is created, udev triggers hal to probe the device with hald-probe-volume. Later, when parted tries to remove the partition, hal has the device still open and thus parted's ioctl results in EBUSY => /proc/partitions not updated. udevadm settle isn't enough to serialize access to the disk. I can't think out anything better then doing simple sleep(1) after each modification of partition table. Does anybody have better idea? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c32 --- Comment #32 from Thomas Fehr <fehr@novell.com> 2010-01-20 14:39:37 UTC --- In libstorage we sent a signal SIGSTOP to process /usr/sbin/hald before executing parted and sent SIGCONT after parted is finished. Maybe this would also be an option for parted. I added this to fix bug #224516. What tests did you do that made you reopen the bug in comment #30? If you were using yast2 partitioning the problem should have been fixed. Of course the problem still can be triggered on parted command line while hald is running. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c33 --- Comment #33 from Petr Uzel <puzel@novell.com> 2010-01-21 11:50:30 UTC --- (In reply to comment #32)
In libstorage we sent a signal SIGSTOP to process /usr/sbin/hald before executing parted and sent SIGCONT after parted is finished. Maybe this would also be an option for parted. I added this to fix bug #224516.
This does not help in case of two subsequent calls to parted like in comment #31 (SIGSTOPping hald does not make it release the device => EBUSY). hald would have to be stopped before the first call and resumed again after the second call - not doable in parted itself (I assume libstorage stops/starts hald before/after _each_ call to parted, right?). Wrapping multiple subsequent calls to parted in libstorage with hald stop/restart should work. Is that an option?
What tests did you do that made you reopen the bug in comment #30?
The one from comment #31.
If you were using yast2 partitioning the problem should have been fixed.
IMHO no - quick subsequent calls to parted could still fail. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c34 --- Comment #34 from Thomas Fehr <fehr@novell.com> 2010-01-21 12:47:14 UTC --- So far we send SIGSTOP to hald before each call to parted and send SIGCONT afterwards. Since we added this we did not have problems with busy devices lib libstorage. In addition we have zillions of calls to udevadm settle in various places. In addition we do a AcquireGlobalInterfaceLock of ""org.freedesktop.Hal.Device.Storage" while yast2 user interface is running. Of course it could be simply luck that there are currently no problems with busy devices in libstorage itself (e.g. failure to format a partition because it is in use). But we do not intend to change anything as long as there are no problems. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c35 --- Comment #35 from Petr Uzel <puzel@novell.com> 2010-01-25 14:46:21 UTC --- I've implemented a patch that retries every BLKPG_DEL_PARTITION after a 1s sleep if the ioctl returns EBUSY (which either means the partition is mounted or something, like hal, has opened the partition). The drawback is that syncing kernel view of partition table will take longer on disks where some of the partitions are mounted (1s for every mounted partition) [*]. If nobody objects, I will push this fix tomorrow. [*] Checking whether the partition is mounted (to avoid unnecessary sleeping) is not an option because it would require big code changes I don't want to do in maintenance update. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c36 --- Comment #36 from Petr Uzel <puzel@novell.com> 2010-01-28 08:27:52 UTC --- Packages with the fix from comment #35 submitted to 11.{0,1,2}:Update:Test repositories and SLE11:Update:Test. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c37 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO CC| |meissner@novell.com Info Provider| |puzel@novell.com --- Comment #37 from Marcus Meissner <meissner@novell.com> 2010-01-29 14:28:08 UTC --- i saw checkins from 26th... are they ok? what is supposed to be the top cvhanges? 11.2 has /work//SRC/old-versions/11.2/UPDATES/all/parted/parted.changes ------------------------------------------------------------------- Mon Jan 25 15:54:17 UTC 2010 - puzel@novell.com - use-ext-range.patch (bnc#567652) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c38 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED Info Provider|puzel@novell.com | --- Comment #38 from Petr Uzel <puzel@novell.com> 2010-02-01 12:25:27 UTC --- (In reply to comment #37)
i saw checkins from 26th... are they ok?
Yes. For 11.2, I'd like to include also fix for #567652, therefore there are two changelog entries. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c40 --- Comment #40 from Marcus Meissner <meissner@novell.com> 2010-03-01 13:18:13 UTC --- its in QA. just waiting. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c44 Jim Omura <jimomura@pathcom.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jimomura@pathcom.com --- Comment #44 from Jim Omura <jimomura@pathcom.com> 2010-04-07 06:57:37 UTC --- I have been trying to organize my thoughts to put together a bug report, and I think this bug covers what I found. When I was trying to change a partition set on an HDD created for Win XP Pro by an H-P installation of XP Pro, I tried reducing the big C: partition with the OpenSuSE 11.2 GNOME LiveCD partitioner, and then create an Extended Partition, OpenSuSE shrank the original partition but failed to do anything further. Oddly, Win XP found nothing wrong with the drive, but some other partitioning software had various problems. In the end, I found that "Parted Magic 4.8" could identify that there was something wrong with the drive. I used that kit to "backup" the partition table, and that fixed everything. I am guessing that what I experienced was the result of this bug. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c47 --- Comment #47 from Petr Uzel <puzel@novell.com> 2010-04-12 14:34:13 UTC --- I've submitted new fix based on what's being discussed in [1]. Parted retries the BLKPG ioctl() after short sleep if it fails. If also second attempt fails, parted tries to verify whether it is actually necessary to update in-kernel view of given partition (this check may fail as well, however). If none of the above steps helps, parted issues a warning that it wasn't able to inform kernel about changes of given partition(s) (before, parted silently ignored that the kernel hasn't been informed). [1] http://lists.alioth.debian.org/pipermail/parted-devel/2010-March/003518.html -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c48 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:running:29521 |maint:released:sle10-sp3:29 |maint:released:sle10-sp3:29 |641 |641 | |maint:released:11.0:32631 --- Comment #48 from Swamp Workflow Management <swamp@suse.com> 2010-04-16 14:06:07 UTC --- Update released for: parted, parted-devel Products: openSUSE 11.0 (debug, i386, ppc, ppc64, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c49 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:running:29521 |maint:released:sle10-sp3:29 |maint:released:sle10-sp3:29 |641 |641 |maint:released:11.0:32631 |maint:released:11.1:32632 --- Comment #49 from Swamp Workflow Management <swamp@suse.com> 2010-04-16 14:06:46 UTC --- Update released for: parted, parted-debuginfo, parted-debugsource, parted-devel, parted-lang Products: openSUSE 11.1 (debug, i586, ppc, ppc64, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c50 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:running:29521 |maint:released:sle10-sp3:29 |maint:released:sle10-sp3:29 |641 |641 |maint:released:11.1:32632 |maint:released:11.2:32633 --- Comment #50 from Swamp Workflow Management <swamp@suse.com> 2010-04-16 14:07:32 UTC --- Update released for: parted, parted-debuginfo, parted-debugsource, parted-devel, parted-lang Products: openSUSE 11.2 (debug, i586, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c51 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:running:29521 |maint:released:sle10-sp3:29 |maint:released:sle10-sp3:29 |641 |641 |maint:released:11.2:32633 |maint:released:sle11:31797 --- Comment #51 from Swamp Workflow Management <swamp@suse.com> 2010-04-16 14:07:41 UTC --- Update released for: parted, parted-32bit, parted-debuginfo, parted-debuginfo-32bit, parted-debuginfo-x86, parted-debugsource, parted-devel, parted-x86 Products: SLE-DEBUGINFO 11 (i386, ia64, ppc64, s390x, x86_64) SLE-DESKTOP 11 (i386, x86_64) SLE-SDK 11 (i386, ia64, ppc64, s390x, x86_64) SLE-SERVER 11 (i386, ia64, ppc64, s390x, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|maint:running:29521 |maint:released:sle10-sp3:29 |maint:released:sle10-sp3:29 |641 |641 | |maint:released:sle11:31797 | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c52 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #52 from Petr Uzel <puzel@novell.com> 2010-04-19 11:36:12 UTC --- Fixed. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=539521 http://bugzilla.novell.com/show_bug.cgi?id=539521#c54 --- Comment #54 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (539521) was mentioned in https://build.opensuse.org/request/show/26247 11.2:Test / parted https://build.opensuse.org/request/show/26248 11.1:Test / parted https://build.opensuse.org/request/show/26249 11.0:Test / parted https://build.opensuse.org/request/show/30477 11.0:Test / parted https://build.opensuse.org/request/show/30478 11.1:Test / parted https://build.opensuse.org/request/show/30479 11.2:Test / parted https://build.opensuse.org/request/show/37780 11.2:Test / parted https://build.opensuse.org/request/show/37781 11.1:Test / parted https://build.opensuse.org/request/show/37782 11.0:Test / parted -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com