https://bugzilla.novell.com/show_bug.cgi?id=227047 ------- Comment #2 from ben.kevan@bio-rad.com 2006-12-08 23:46 MST ------- after closing the firefox window, open a terminal (konsole) and type the following: ps -ae | grep fire Does it report firefox is still running? if so type: kill pid (pid being the 1188 number or so). Reboot, now what happens? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=227047 ------- Comment #4 from el.presidente@titonia.com 2006-12-25 13:18 MST ------- Firefox does this when you log out without quitting; rather than automatically restore itself it asks if you would like to restore your last session or start again. I believe this is by design. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=227047 wolfgang@rosenauer.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfgang@rosenauer.org Component|GNOME |Firefox ------- Comment #6 from wolfgang@rosenauer.org 2007-01-11 13:56 MST ------- This is most probably https://bugzilla.mozilla.org/show_bug.cgi?id=336193 I never checked that yet but I guess closing KDE kills running applications with SIGTERM? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=227047 ------- Comment #8 from jpr@novell.com 2007-04-25 14:51 MST ------- The upstream is https://bugzilla.mozilla.org/show_bug.cgi?id=93789 This is also have of bug 257343. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.novell.com/show_bug.cgi?id=227047#c10 --- Comment #10 from Wolfgang Rosenauer 2007-08-21 09:20:56 MST --- Investigating/testing now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=227047#c12 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federico@novell.com --- Comment #12 from Federico Mena Quintero 2007-08-21 16:50:45 MST --- (In reply to comment #11 from Wolfgang Rosenauer)

- Gnome is not saying that Firefox can't get restored

This is the right behavior. Gnome-session detected that Firefox registered as a session-managed client, so "all is normal".

- Firefox doesn't ask to restore the session

.. as expected, since it has the chance to quit normally from die_cb() in the patch.

but - Firefox also doesn't restart in the old state when login to Gnome (which I understood should be the point with that)

This happens because the patch doesn't provide a "restart command" correctly. Each session has a unique ID. Session-managed programs can use this ID to save their information and restore it later (very few programs implement this correctly, if at all!). [XSMP is pretty baroque... it wants to let you do things like have a session for home, a session for work, etc., all with different programs to be restarted each time. That's what the different IDs are for.] If you simply call gnome_program_init(), the machinery gets set up so that the restart_command is basename(argv[0]). This is a best-effort thing; gnome_program_init() assumes that it is getting the real argv from main(). However, Firefox is passing bogus data for that argv, and it is not setting an explicit restart_command :) Grep for "gecko" in the patch; you'll see that + char *argv[2] = { "gecko", "--disable-crash-dialog" }; + gnome_program_init("Gecko", "1.0", libgnomeui_module_info_get(), 2, argv, NULL); is definitely not a valid command line. If you replace "gecko" with "firefox" in the definition of argv, I'm 99% sure you'll get Firefox to restart, but without restoring its tabs/windows. Ideally, a program will do the full thing in its save_yourself_cb and do: save_my_data_for_session_id (session_id); gnome_client_set_restart_command (client, ["myprog", "--session-restart", session_id]); gnome_client_set_discard_command (client, ["myprog", "--discard-session-info", session_id]); These are just sample arguments; they could be anything your app wants. For example, if your program creates ~/.foo/sessions/[session_id] when saving a session, it could very well set its discard_command to "rm -rf ~/.foo/sessions/[session_id]". [XSMP is even more baroque than that --- you can define other commands for different situations (resign_command, shutdown_command). But you don't care about those unless you are a session-wide, desktop-level program.]

Does metacity try to restore using class as application to start? That would explain why it doesn't work.

It's not metacity; it's gnome-session. See above for how the command gets determined. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=227047#c14 Wolfgang Rosenauer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #14 from Wolfgang Rosenauer 2007-09-26 01:55:20 MST --- Seems it is included in 10.3 Firefox -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.