[Bug 858429] New: do not restart libvirt-guests during libvirt updates!
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c0 Summary: do not restart libvirt-guests during libvirt updates! Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: KVM AssignedTo: jfehlig@suse.com ReportedBy: mrueckert@suse.com QAContact: jdouglas@suse.com Found By: --- Blocker: --- Why are we restarting the libvirt guests during a libvirt update? the kvm/xen are in a different package so no files from libvirt should be affected by leaving those running. this broke me one of my virtualization hosts twice now. I kind of have the feeling this behavior is new in 13.1 and wasnt there on sles 11 sp3 could we please disable this behavior or is there a good reason to keep it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c1 --- Comment #1 from James Fehlig <jfehlig@suse.com> 2014-01-13 21:29:25 UTC --- I will certainly disable this behavior, when I figure out how. As per the systemd packageing guidelines [1], the libvirt spec file has %post client /sbin/ldconfig %if %{with_systemd} %service_add_post libvirt-guests.service %endif %{fillup_only -n libvirt-guests} %preun client %if %{with_systemd} %service_del_preun libvirt-guests.service %endif %stop_on_removal libvirt-guests if [ $1 = 0 ]; then rm -f /var/lib/libvirt/libvirt-guests fi %postun client /sbin/ldconfig %if %{with_systemd} %service_del_postun libvirt-guests.service %endif %insserv_cleanup And if I understand the guidelines, this should not cause the service to be restarted. [1] http://en.opensuse.org/openSUSE:Systemd_packaging_guidelines -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c2 --- Comment #2 from James Fehlig <jfehlig@suse.com> 2014-01-13 21:56:36 UTC --- Looking at the actual script on an installed system (condensed a bit) xen53:~ # rpm -q --scripts libvirt-client-1.1.2-0.x86_64 postinstall scriptlet (using /bin/sh): /sbin/ldconfig /usr/bin/systemctl daemon-reload >/dev/null 2>&1 || : /usr/bin/systemctl preset libvirt-guests.service >/dev/null 2>&1 || : preuninstall scriptlet (using /bin/sh): if [ $FIRST_ARG -eq 0 ]; then # Package removal, not upgrade /usr/bin/systemctl --no-reload disable libvirt-guests.service > /dev/null 2>&1 || : /usr/bin/systemctl stop libvirt-guests.service > /dev/null 2>&1 || : fi postuninstall scriptlet (using /bin/sh): /sbin/ldconfig if [ $FIRST_ARG -ge 1 ]; then # Package upgrade, not uninstall /usr/bin/systemctl try-restart libvirt-guests.service >/dev/null 2>&1 || : else # package uninstall .. fi The postuninstall scriptlet is interesting in the upgrade case, but according to systemctl man page try-restart NAME... Restart one or more units specified on the command line if the units are running. This does nothing if units are not running. So I'm not sure why libvirt-guests is being restarted on upgrade. The service file for libvirt-guests seems correct too [Service] EnvironmentFile=-/etc/sysconfig/libvirt-guests # Hack just call traditional service until we factor # out the code ExecStart=/usr/lib64/libvirt/libvirt-guests.sh start ExecStop=/usr/lib64/libvirt/libvirt-guests.sh stop Type=oneshot RemainAfterExit=yes StandardOutput=journal+console Some advise from the systemd maintainer would be helpful, but I'm not sure who that is these days. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c3 Frederic Crozat <fcrozat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jfehlig@suse.com |systemd-maintainers@suse.de --- Comment #3 from Frederic Crozat <fcrozat@suse.com> 2014-03-27 12:06:50 UTC --- two things to fix it "properly": - the %service_del_postun macro should be improved to ckeck DISABLE_RESTART_ON_UPDATE variable (and YAST_IS_RUNNING) and not run "systemctl try-restart" in that case (similar to %restart_on_update ) - we should have a %service_del_postun_norestart variation of the macro (upstream has two macros : %systemd_postun_with_restart and %systemd_postun) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c4 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |fcrozat@suse.com --- Comment #4 from Dr. Werner Fink <werner@suse.com> 2014-03-27 12:11:37 UTC --- (In reply to comment #3) Send patches ;) ... also is this valid to SLES12 as well -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c5 Frederic Crozat <fcrozat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|fcrozat@suse.com | --- Comment #5 from Frederic Crozat <fcrozat@suse.com> 2014-03-27 12:23:55 UTC --- untested patch: sr#227735 I didn't implement a second macro, let's use the environment variable instead. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c6 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |fcrozat@suse.com --- Comment #6 from Dr. Werner Fink <werner@suse.com> 2014-03-27 12:39:21 UTC --- (In reply to comment #5) acceped ... should this one go into SLES12? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c7 --- Comment #7 from Marcus Rückert <mrueckert@suse.com> 2014-03-27 12:41:57 UTC --- yes please! getting your guests restarted just because libvirt updates is highly annoying. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c8 --- Comment #8 from Marcus Rückert <mrueckert@suse.com> 2014-03-27 12:42:49 UTC --- also 13.1 please. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c9 Frederic Crozat <fcrozat@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|fcrozat@suse.com | --- Comment #9 from Frederic Crozat <fcrozat@suse.com> 2014-03-27 12:50:24 UTC --- yes, SLE12 too.. For 13.1, I'm afraid it is "too late", since we updating the macro won't fix the bug on existing packages :( -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c10 Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |fcrozat@suse.com --- Comment #10 from Dr. Werner Fink <werner@suse.com> 2014-03-27 12:52:14 UTC --- SLES12 SR#34953 (In reply to comment #8) There is no single systemd-rpm-macros package and for a systemd package I do not have the time -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c12 --- Comment #12 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-03-27 14:00:20 CET --- This is an autogenerated message for OBS integration: This bug (858429) was mentioned in https://build.opensuse.org/request/show/227738 Factory / systemd-rpm-macros -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c13 --- Comment #13 from Marcus Rückert <mrueckert@suse.com> 2014-03-27 14:14:02 UTC --- (In reply to comment #9)
yes, SLE12 too.. For 13.1, I'm afraid it is "too late", since we updating the macro won't fix the bug on existing packages :(
well if we push out the new macro to the systemd package in 13.1, we can fix the libvirt package there and avoid the problem there too. maybe not directly in the next upgrade, but in the one after. If nobody objects we could just apply the same diff to the systemd package in 13.1. no other changes. just this fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c15 --- Comment #15 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-03-27 16:00:11 CET --- This is an autogenerated message for OBS integration: This bug (858429) was mentioned in https://build.opensuse.org/request/show/227774 Factory / systemd-rpm-macros -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858429 https://bugzilla.novell.com/show_bug.cgi?id=858429#c Dr. Werner Fink <werner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Other |openSUSE 13.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com