[Bug 465364] New: Evolution showing incorrect time for message
https://bugzilla.novell.com/show_bug.cgi?id=465364 Summary: Evolution showing incorrect time for message Classification: openSUSE Product: openSUSE 11.1 Version: Final Platform: i686 OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Evolution AssignedTo: bnc-team-evolution@forge.provo.novell.com ReportedBy: ruchir.brahmbhatt@ecosmob.com QAContact: lakhil@novell.com Found By: --- Created an attachment (id=264496) --> (https://bugzilla.novell.com/attachment.cgi?id=264496) evolution showing wrong time User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2008121300 SUSE/3.0.5-1.1 Firefox/3.0.5 Build Identifier: Evolution sometimes displays incorrect time for message received in message list. I think it displays GMT time whereas my timezone is IST. By clicking several messages in list or refreshing view, time gets corrected. I'll attach screenshots. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User ruchir.brahmbhatt@ecosmob.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c1 --- Comment #1 from Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> 2009-01-12 06:52:10 MST --- Created an attachment (id=264497) --> (https://bugzilla.novell.com/attachment.cgi?id=264497) evolution showing right time after refresh -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User lakhil@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c2 Akhil Laddha <lakhil@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |ruchir.brahmbhatt@ecosmob.c | |om --- Comment #2 from Akhil Laddha <lakhil@novell.com> 2009-01-12 20:36:01 MST --- Is it a meeting request or normal mail ? One bug has been fixed recently related to wrong time in meeting request mail. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User ruchir.brahmbhatt@ecosmob.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c3 Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|ruchir.brahmbhatt@ecosmob.c | |om | --- Comment #3 from Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> 2009-01-12 22:13:57 MST --- It is normal mail. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User ayerges@novacoast.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c4 --- Comment #4 from Al Maslowski-Yerges <ayerges@novacoast.com> 2009-01-21 12:50:07 MST --- Happens for me as well. One additional caveat to add: My mailserver is GroupWise and exists in PST. The time switches between UTC and PST but never displays my real TZ of MST. It is correctly set and has been reset in the Evolution options control. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User ruchir.brahmbhatt@ecosmob.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c5 --- Comment #5 from Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> 2009-01-22 00:34:38 MST --- Additionally it happens frequently. Clicking the message shows proper time. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User lakhil@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c6 Akhil Laddha <lakhil@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominique.leuenberger@tmf-g | |roup.com --- Comment #6 from Akhil Laddha <lakhil@novell.com> 2009-01-28 02:29:22 MST --- *** Bug 438722 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=438722 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User pchenthill@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c7 --- Comment #7 from Chenthill palanisamy <pchenthill@novell.com> 2009-01-28 15:37:13 MST --- Created an attachment (id=268472) --> (https://bugzilla.novell.com/attachment.cgi?id=268472) should fix the bug. would good if lakhil or any others test it too.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User abharath@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c9 Bharath Acharya <abharath@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abharath@novell.com --- Comment #9 from Bharath Acharya <abharath@novell.com> 2009-02-03 03:57:49 MST --- Suman, could you review this patch? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User pchenthill@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c10 --- Comment #10 from Chenthill palanisamy <pchenthill@novell.com> 2009-02-03 03:59:59 MST --- sankar would be a best person to review this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User psankar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c11 Sankar P <psankar@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |psankar@novell.com --- Comment #11 from Sankar P <psankar@novell.com> 2009-02-03 22:04:00 MST --- I reviewed the patch. Few comments: 1) There is an unused variable. camel-groupwise-folder.c:248 - time 2) if (type==appointment||memo||task) get_happening_date else get_delivery_date this piece of code is used in a lot of places. May be we can move this to a static funciton pasing the EGwItem 3) if (type == E_GW_ITEM_TYPE_APPOINTMENT || type == E_GW_ITEM_TYPE_NOTE || type == E_GW_ITEM_TYPE_TASK) { + int offset = 0; + dtstring = e_gw_item_get_start_date (item); + time_t actual_time = e_gw_connection_get_date_from_string (dtstring); + camel_mime_message_set_date (msg, actual_time, offset); + return; + } + dtstring = e_gw_item_get_delivered_date (item); if(dtstring) { int offset = 0; - time_t time = e_gw_connection_get_date_from_string (dtstring); - time_t actual_time = camel_header_decode_date (ctime(&time), &offset); + time_t actual_time = e_gw_connection_get_date_from_string (dtstring); camel_mime_message_set_date (msg, actual_time, offset); } else { In this piece, the offset, time, actual_time can be moved as function scoped variables (declared as soon as the funciton starts). because the same local variable naems are re-declared and used in more than 2 innerloops within a single function. Also, There is some other issue I am observing. For mails, I am seeing time in UTC and not in the time-zone time that I have sent. So, I suggest to get this more tested by Akhil. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User psankar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c12 --- Comment #12 from Sankar P <psankar@novell.com> 2009-02-03 22:08:29 MST --- The first three coding related comments are not mandatory for patch submission and can be added as FIXMEs Only the last comment should be verified before submission. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User pchenthill@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c13 --- Comment #13 from Chenthill palanisamy <pchenthill@novell.com> 2009-02-03 23:50:18 MST --- Sankar, I guess there are a lot of cleanup work that can be done there. I want to have less code changes as possible, so have adhered to what is existing :) What about the changes made to e_gw_connection_get_date_from_string.. do they make sense ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User psankar@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c14 --- Comment #14 from Sankar P <psankar@novell.com> 2009-02-03 23:58:04 MST --- (In reply to comment #13)
Sankar, I guess there are a lot of cleanup work that can be done there. I want to have less code changes as possible, so have adhered to what is existing :)
Yes. They dont prevent from submitting to autobuild. lots of things in camel-gw-folder needs cleanup
What about the changes made to e_gw_connection_get_date_from_string.. do they make sense ?
The changes in e_gw_con... looks good. But on my test I saw mails appearing in UTC. My timezone is set to IST in both evolution preferences as well as yast. So, I wanted to confirm this alone from QA. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User lakhil@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c15 --- Comment #15 from Akhil Laddha <lakhil@novell.com> 2009-02-04 01:41:11 MST --- I applied the patch in trunk and tried out. I am also seeing +5:30 hrs difference between meeting time and time displayed in message list. But message shows correct time till it is in unread state, time goes wrong as soon as i read it. I have cross checked with java client, it is showing timing properly. Problem is getting worse after some time. Here is an example actual meeting time - 5 PM time when message is unread - 5 PM after some time later - 1:40 PM and now - 8:10 AM -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User pchenthill@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c16 --- Comment #16 from Chenthill palanisamy <pchenthill@novell.com> 2009-02-04 01:57:03 MST --- Akhil, will debug once I reach to office tomorrow. Somehow things seems to be fine in my machine with the patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User pchenthill@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c17 --- Comment #17 from Chenthill palanisamy <pchenthill@novell.com> 2009-02-04 21:46:11 MST --- Created an attachment (id=270228) --> (https://bugzilla.novell.com/attachment.cgi?id=270228) Fix on evo side. The problem was with tz env. not set properly at times. So the convertion to local time did not happen properly in some cases. It was a timing issue. In my first eds patch, i was not facing this. But now after more tries I was able to reproduce this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User ruchir.brahmbhatt@ecosmob.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c20 --- Comment #20 from Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> 2009-03-04 05:52:09 MST --- Any chances to release update? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User lakhil@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c21 --- Comment #21 from Akhil Laddha <lakhil@novell.com> 2009-03-05 05:21:32 MST --- Committed revision in upstream (gnome-2.26) http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=101... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 User ruchir.brahmbhatt@ecosmob.com added comment https://bugzilla.novell.com/show_bug.cgi?id=465364#c22 Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #22 from Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> 2009-03-18 06:19:18 MST --- I confirm this is fixed in Gnome 2.26. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=465364 Ruchir Brahmbhatt <ruchir.brahmbhatt@ecosmob.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com