[Bug 1233410] New: AUDIT-0: incus: new package with sysctl.d drop-in
https://bugzilla.suse.com/show_bug.cgi?id=1233410 Bug ID: 1233410 Summary: AUDIT-0: incus: new package with sysctl.d drop-in Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Security Assignee: security-team@suse.de Reporter: asarai@suse.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- This sysctl drop-in is based on the already-approved 60-lxd.sysctl for the lxd package, but with a few extra options. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 https://bugzilla.suse.com/show_bug.cgi?id=1233410#c1 --- Comment #1 from Aleksa Sarai <asarai@suse.com> --- https://build.opensuse.org/package/show/Virtualization:containers/incus is the devel project for the package. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 https://bugzilla.suse.com/show_bug.cgi?id=1233410#c2 Matthias Gerstner <matthias.gerstner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.gerstner@suse.com, | |security-team@suse.de --- Comment #2 from Matthias Gerstner <matthias.gerstner@suse.com> --- Thanks for creating the AUDIT bug. Back when I looked into the lxc sysctl file I already wondered whether there wouldn't be a better way to do this. As it is, as soon as incus is installed, major system settings are altered permanently. I would find it better to perform these settings only when the containers are actually used e.g. via a systemd unit or something. Just a thought. What happens when incus and lxc are installed in parallel now? Then there will be conflicting settings. We'll have "60-lxd.conf" and "60-incus.conf", so LXD will probably win, appearing later in the alphabet. But some settings on top of the LXD settings done by the incus file will remain. Security wise I guess the file is okay, though. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 Aleksa Sarai <asarai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asarai@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 https://bugzilla.suse.com/show_bug.cgi?id=1233410#c3 --- Comment #3 from Aleksa Sarai <asarai@suse.com> --- Yeah those are good points. The main reason for including these in the LXD and Incus packaging is to ensure that some of the values are large enough to be able to run several thousand system containers on one system (IIRC some of the default system limits on openSUSE lead to a few hundred containers maximum). Maybe it would make more sense to move things into an lxc-sysctl-common package that both LXD and Incus depend on to avoid duplication? We could definitely do it in a systemd unit instead, but is that okay from the security team's perspective? We would probably store the sysctl config in a different directory so there will no longer be an rpmlint blocking us from updating it without an audit... (Obviously admin programs can modify sysctls arbitrarily, so even with an rpmlint you can't be sure that programs aren't doing dumb things, but I guess I'm not entirely sure what the intended scope of sysctl audits is. Is it only for catching stuff that gets applied on-boot automatically if you install a package?) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 https://bugzilla.suse.com/show_bug.cgi?id=1233410#c4 --- Comment #4 from Matthias Gerstner <matthias.gerstner@suse.com> --- I suggest you do it in whatever way is best for you and the outcome of the packaging. Doing it in a shared sysctl-common package also sounds good. Are such high container loads common use cases? Maybe activating these settings should be left to the users that actually need them? You are right, when the settings are moved out of the sysctl.d directories, then they won't popup in rpmlint anymore. But we do have some monitoring e.g. of newly introduced systemd services and changes to them. It's a best effort approach. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 https://bugzilla.suse.com/show_bug.cgi?id=1233410#c5 Aleksa Sarai <asarai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |UPSTREAM --- Comment #5 from Aleksa Sarai <asarai@suse.com> --- After talking to the upstream maintainers, they agree that dropping the sysctl file is probably the best course of action[1]. They expect that you would start hitting issues at around 100 concurrent containers (due to the very low keyring limits set by default) but at that point you would expect users to read the documentation and see what settings they need to apply. [1]: https://discuss.linuxcontainers.org/t/incus-on-opensuse-tumbleweed-microos/1... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1233410 https://bugzilla.suse.com/show_bug.cgi?id=1233410#c7 --- Comment #7 from Marcus Meissner <meissner@suse.com> --- openSUSE-RU-2024:0388-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1233410 CVE References: JIRA References: Sources used: openSUSE Backports SLE-15-SP6 (src): incus-6.7-bp156.2.1 -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com