[Bug 855477] New: daily cron job of storebackup uses all files in /etc/storebackup.d even backupfiles ending with a tilde
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c0 Summary: daily cron job of storebackup uses all files in /etc/storebackup.d even backupfiles ending with a tilde Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: Other OS/Version: openSUSE 13.1 Status: NEW Severity: Enhancement Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: wagner-thomas@gmx.at QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Opera/9.80 (Windows NT 6.1; WOW64) Presto/2.12.388 Version/12.16 The package storebackup sets up a /etc/cron.daily/storebackup script which reads config files by configs=`find /etc/storebackup.d/ -type f` in line 13 of above mentioned file. This also includes backup files which are automatically generated by a lot of common text editors, e.g. files ending with a tilde. I suggest, that only files ending with, e.g., .conf should be considered by the daily cronjob for storebackup. This can be easily achieved by using something like configs=`find /etc/storebackup.d/ -type f -name "*.conf"` in line 13 of /etc/cron.daily/storebackup. This would 1) prevent the execution of a storbackup-run for backup files that are automatically generated by text editor and 2) allow for easily disabling files by renaming the filename extension (just like apache2 behaves with *.conf files in /etc/apache2/vhosts/) Reproducible: Always -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c zhang jiajun <jzhang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzhang@suse.com AssignedTo|bnc-team-screening@forge.pr |mge@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c1 --- Comment #1 from Thomas Wagner <wagner-thomas@gmx.at> 2014-07-16 13:57:14 UTC --- Found another (better compatible solution) Use "ls -B" instead of "find" also gets rid of *~ files generated by text editors. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c2 Jan Ritzerfeld <suse@bugs.jan.ritzerfeld.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse@bugs.jan.ritzerfeld.or | |g --- Comment #2 from Jan Ritzerfeld <suse@bugs.jan.ritzerfeld.org> 2014-08-11 13:31:12 UTC --- Your submit request uses the find and not "ls -B". Do you want to update the request? Or do you think your find solution is better? However, your submit request looks good to me. IMHO you could use -name instead of -iname. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c3 --- Comment #3 from Thomas Wagner <wagner-thomas@gmx.at> 2014-08-11 13:59:39 UTC --- During writing the patch I found that find produces a better result than ls -B. This is because find returns the absolute path while ls returns a relative path. So I'd favor searching with find now. IMHO -name and -iname should produce the same result here. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c4 --- Comment #4 from Jan Ritzerfeld <suse@bugs.jan.ritzerfeld.org> 2014-08-13 07:02:08 UTC --- Your patch should be in Factory now. Thank you for your submission! Feel free to close your bug if you are happy with it. :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=855477 https://bugzilla.novell.com/show_bug.cgi?id=855477#c5 Thomas Wagner <wagner-thomas@gmx.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Thomas Wagner <wagner-thomas@gmx.at> 2014-08-13 08:00:54 UTC --- I tested the version in Factory and it works all as expected. So I'll close the bug now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com