[Bug 418333] New: Provide more information in submit request mails
https://bugzilla.novell.com/show_bug.cgi?id=418333 Summary: Provide more information in submit request mails Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: skh@novell.com QAContact: adrian@novell.com Found By: --- Currently, the mails sent out for a package submit request contain the state of the request, source project and package, and target project and package. It would be helpful if more information could be included in this mail: - the user who sent this submit request - a diff - the message included in the request - the complete history of the request -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418333
Cyril Hrubis
https://bugzilla.novell.com/show_bug.cgi?id=418333
User froh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=418333#c1
Susanne Oberhauser
https://bugzilla.novell.com/show_bug.cgi?id=418333
User skh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=418333#c2
--- Comment #2 from Sonja Krause-Harder
https://bugzilla.novell.com/show_bug.cgi?id=418333
User abauer@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=418333#c3
--- Comment #3 from Andreas Bauer
Not including it seems to me like artificially withholding information which are available at the time the mail is sent anyway.
This assumption is wrong. The mail isn't sent by the backend, which would indeed have all the information to generate a diff. All the backend does is passing a notification with a bunch of key/value pairs to another service (hermes). Hermes currently allows a maximum size of 255 characters for the value part, not usable for a diff. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418333
User froh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=418333#c4
--- Comment #4 from Susanne Oberhauser
Is including the diff expensive in any way? Not including it seems to me like artificially withholding information which are available at the time the mail is sent anyway.
alas, as abauer said, it's not readily 'available', and we're somewhat reluctant making one system depend on the other. you'd need to
The world will not end if I have to switch to another shell, find the project, find the package and call osc with the right incantation. It would just be much easier to have the diff right in the notification email.
I see. As you need to switch to a shell anyway to accept or decline the request, you can also just "osc submitreq show --diff $ID" it, and the mail shall contain the right command line, including $ID, in the message body, for cut&paste. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418333
User froh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=418333#c5
--- Comment #5 from Susanne Oberhauser
alas, as abauer said, it's not readily 'available', and we're somewhat reluctant making one system depend on the other. you'd need to
gargl, that went out too early, sorry. forget about the 'you'd need to'. I'm now in the process of updating the messages, I'd suggest we see how people react and then we decide what's still missing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=418333
User froh@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=418333#c6
Susanne Oberhauser
participants (1)
-
bugzilla_noreply@novell.com