[Bug 450229] New: online update is not run during installation
https://bugzilla.novell.com/show_bug.cgi?id=450229 Summary: online update is not run during installation Product: openSUSE 11.1 Version: RC 1 Platform: Other OS/Version: Other Status: NEW Severity: Blocker Priority: P5 - None Component: Installation AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dmueller@novell.com QAContact: jsrain@novell.com Found By: --- when deselecting "automatic configuration", the installation workflow mentions "Online Update" after "Network Test", however, online update never actually runs. the only thing that happens is that suseconfig is run. is this a fallout of the issue that the current release notes cannot be fetched? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User dmueller@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c1 --- Comment #1 from Dirk Mueller <dmueller@novell.com> 2008-11-29 05:39:53 MST --- Created an attachment (id=256728) --> (https://bugzilla.novell.com/attachment.cgi?id=256728) yast2 logs -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |yast2-maintainers@suse.de -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 Michael Andres <ma@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ma@novell.com AssignedTo|yast2-maintainers@suse.de |locilka@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c2 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |locilka@novell.com, mc@novell.com AssignedTo|locilka@novell.com |jdsn@novell.com --- Comment #2 from Lukas Ocilka <locilka@novell.com> 2008-12-01 04:41:47 MST --- Daniel, please, check. It's about setting the Internet::do_you variable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c3 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |SHIP_STOPPER+ --- Comment #3 from Stephan Kulow <coolo@novell.com> 2008-12-01 06:35:58 MST --- I guess online update during installation is bound to registration, which we don't do anymore. This should still work - and as we need to test the update during installation this is a blocker per excellance (sorry, my frensh :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User jdsn@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c6 --- Comment #6 from J. Daniel Schmidt <jdsn@novell.com> 2008-12-01 08:12:52 MST --- (In reply to comment #3 from Stephan Kulow)
I guess online update during installation is bound to registration,
No it is bound to the the Internet::do_you variable. It defaults to "false". The network test no longer sets it to true on success and the registration is not run during openSUSE installation which also set it to true on success.
which we don't do anymore. This should still work - and as we need to test the update during installation this is a blocker per excellance (sorry, my frensh :)
As the question whether or not to install updates was enhanced and only appears if there are really updates available, I'd recommend to just remove the check of the current "do_you"-state at the beginning of this module. Any objections, Lukas? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c7 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jdsn@novell.com |locilka@novell.com Status|NEW |ASSIGNED --- Comment #7 from Lukas Ocilka <locilka@novell.com> 2008-12-01 08:20:48 MST --- Hmm, this means Internet::do_you is currently (newly) useless. In this case, I can replace this if (!Internet::do_you) return `auto; in inst_ask_online_update.ycp with if (NetworkService.ycp::isNetworkRunning() != true) return `auto; opinions? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c8 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |behlert@novell.com, kukuk@novell.com Status|ASSIGNED |NEEDINFO Info Provider| |coolo@novell.com --- Comment #8 from Lukas Ocilka <locilka@novell.com> 2008-12-01 08:27:25 MST --- BTW: it changes the SLEx behavior a bit, but still doesn't run online update if not wanted by user. On the other hand, it would offer an online update even if user didn't run registration (on SLEx). In that case I'd tend to have it "fixed" on two places. The default Internet::do_you would be set to 'true' and registration would disable it of not registered (or no update channel added). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User jdsn@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c9 --- Comment #9 from J. Daniel Schmidt <jdsn@novell.com> 2008-12-01 08:32:23 MST --- Created an attachment (id=256991) --> (https://bugzilla.novell.com/attachment.cgi?id=256991) Proposed Patch No it is not useless, it is the flag that online_update uses to check if it should start. The client inst_ask_onlineupdate just set it to true if an update is wanted. So did registration and in former times the network test. I just tested the attached patch in an installation and it worked. Only the package manager did not start up in the update view but in the pattern view :( This might be another issue. Do you agree? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #256991|text/x-patch |text/plain mime type| | Attachment #256991|0 |1 is patch| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User visnov@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c10 --- Comment #10 from Stanislav Visnovsky <visnov@novell.com> 2008-12-01 08:38:28 MST --- Sounds like a reasonable approach (if you figure out if you need the do_you flag or not) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c11 --- Comment #11 from Lukas Ocilka <locilka@novell.com> 2008-12-01 08:41:17 MST --- Created an attachment (id=256995) --> (https://bugzilla.novell.com/attachment.cgi?id=256995) A bit more reliable patch proposal -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c12 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #256995|0 |1 is obsolete| | --- Comment #12 from Lukas Ocilka <locilka@novell.com> 2008-12-01 08:46:32 MST --- Created an attachment (id=256998) --> (https://bugzilla.novell.com/attachment.cgi?id=256998) Patch proposal version 2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #256998|text/x-patch |text/plain mime type| | Attachment #256998|0 |1 is patch| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User jdsn@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c13 J. Daniel Schmidt <jdsn@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdsn@novell.com --- Comment #13 from J. Daniel Schmidt <jdsn@novell.com> 2008-12-01 08:51:06 MST --- (In reply to comment #12 from Lukas Ocilka)
A bit more reliable patch proposal
Yes, I agree, depending on the network being up is the better approach. But with you patch #2 the following check for `skip is obsolete as well. Lukas, do you want to add this patch? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c14 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #256991|0 |1 is obsolete| | Attachment #256998|0 |1 is obsolete| | --- Comment #14 from Lukas Ocilka <locilka@novell.com> 2008-12-01 08:58:58 MST --- Created an attachment (id=257001) --> (https://bugzilla.novell.com/attachment.cgi?id=257001) Patch proposal version 3 Yes, we've checked that with jsrain and found the same (I thought I've removed it already) but it seem to be an issue between keyboard and monitor. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c15 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Info Provider|coolo@novell.com | Resolution| |FIXED --- Comment #15 from Lukas Ocilka <locilka@novell.com> 2008-12-01 09:03:22 MST --- - Fixed proposing the online update depending on the fact whether network is running (bnc #450229). - yast2-installation-2.17.43 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c16 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #16 from Stephan Kulow <coolo@novell.com> 2008-12-03 08:45:42 MST --- just tested openSUSE-11.1-RC2-DVD9-i586-x86_64-Build0001-Media.iso and it has the 2.17.43 and still skips. I'll attach logs as soon as the desktop started -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c17 --- Comment #17 from Stephan Kulow <coolo@novell.com> 2008-12-03 08:48:40 MST --- Created an attachment (id=257759) --> (https://bugzilla.novell.com/attachment.cgi?id=257759) yast logs Release notes are up btw and the test was successful -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c18 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #18 from Lukas Ocilka <locilka@novell.com> 2008-12-03 10:25:34 MST --- clients/inst_ask_online_update.ycp:116 Calling YaST client inst_ask_online_update (arguments: [$["enable_back":true, "enable_next":true]]) NetworkService.ycp:138 Network is running ... clients/inst_ask_online_update.ycp:73 Pkg Builtin called: TargetInitialize clients/inst_ask_online_update.ycp:74 Pkg Builtin called: TargetLoad clients/inst_ask_online_update.ycp:75 Pkg Builtin called: SourceStartManager clients/inst_ask_online_update.ycp:78 Pkg Builtin called: PkgSolve clients/inst_ask_online_update.ycp:80 Pkg Builtin called: ResolvableCountPatches clients/inst_ask_online_update.ycp:81 Available patches for pkg management: 0 clients/inst_ask_online_update.ycp:84 Pkg Builtin called: ResolvableCountPatches clients/inst_ask_online_update.ycp:85 All available patches: 0 clients/inst_ask_online_update.ycp:88 No patch available, skiping offer to run YOU Calling `inst_ask_online_update ($["enable_back":true, "enable_next":true]) returned `next clients/inst_extrasources.ycp:191 Calling YaST client inst_extrasources (arguments: [$["enable_back":true, "enable_next":true]]) clients/inst_extrasources.ycp:52 Repositories to register: [$["alias":"repo-update", "autorefresh":true, "baseurl":"http://download.opensuse.org/update/11.1/", "enabled":true, "name":"openSUSE-11.1-Update", "priority":20, "prod_dir":"/"], $["alias":"repo-oss", "autorefresh":true, "baseurl":"http://download.opensuse.org/distribution/11.1/repo/oss/", "enabled":true, "name":"openSUSE-11.1-Oss", "priority":100, "prod_dir":"/"], $["alias":"repo-non-oss", "autorefresh":true, "baseurl":"http://download.opensuse.org/distribution/11.1/repo/non-oss/", "enabled":true, "name":"openSUSE-11.1-Non-Oss", "priority":100, "prod_dir":"/"], $["alias":"repo-debug", "autorefresh":true, "baseurl":"http://download.opensuse.org/debug/distribution/11.1/repo/oss/", "enabled":false, "name":"openSUSE-11.1-Debug", "priority":100, "prod_dir":"/"], $["alias":"repo-source", "autorefresh":true, "baseurl":"http://download.opensuse.org/source/distribution/11.1/repo/oss/", "enabled":false, "name":"openSUSE-11.1-Source", "priority":100, "prod_dir":"/"]] No wonder ... repositories (also the update one) were added after running the inst_ask_online_update client (after checking for patches...) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=450229 User locilka@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=450229#c19 Lukas Ocilka <locilka@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #19 from Lukas Ocilka <locilka@novell.com> 2008-12-03 10:41:31 MST --- - inst_extrasources moved before inst_ask_online_update to register the online update repository before checking for patches (bnc #450229). New skelcd-control-openSUSE is in autobuild... I have to admit that I don't have any possibility to test it here. Anyway, it should be possible to install the install the first stage, and before the system is rebooted to the second stage, copy the control.xml to /etc/YaST2/ on the system. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com