[Bug 527721] New: mcrypt-2.6.8-2.9: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=527721 Summary: mcrypt-2.6.8-2.9: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package mcrypt-2.6.8-2.9 For source code file mcrypt-2.6.8/src/extra.c around line 490 is the source code for the function read_key_file. I notice the following line of code FROMF = fopen(file, "r"); but I fail to find a matching call to fclose. This seems to be a resource leak. Suggest code rework, possibly by adding call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=527721
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=527721
Petr Uzel
http://bugzilla.novell.com/show_bug.cgi?id=527721
User puzel@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527721#c1
Petr Uzel
http://bugzilla.novell.com/show_bug.cgi?id=527721
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527721#c2
--- Comment #2 from David Binderman
David, I really admire the effort you spend on searching this kind of bugs.
I thank you. I heard recently I have submitted over 1,000 bug reports to OpenSuse.
However, I can't resist to suggest (again) that you send bugreports (ideally with patches) directly to package upstream.
I'm afraid this may be convenient for you, but it is not at all convenient for me. There are thousands of packages and I have no intention of getting an account with each package, merely to submit one bug report. I would prefer to continue working in the future as I have done in the past. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=527721
User puzel@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527721#c3
--- Comment #3 from Petr Uzel
I thank you. I heard recently I have submitted over 1,000 bug reports to OpenSuse.
I know - congratulations.
However, I can't resist to suggest (again) that you send bugreports (ideally with patches) directly to package upstream.
I'm afraid this may be convenient for you, but it is not at all convenient for me.
There are thousands of packages and I have no intention of getting an account with each package, merely to submit one bug report.
Come on, many of packages are hosted on sourceforge, where is also an bugtracker and thus you would need only one account for each of these packages.
I would prefer to continue working in the future as I have done in the past.
OK, but my opinion is that by reporting bugs about missing fclose etc. to upstream would be much more useful. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=527721
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=527721#c4
--- Comment #4 from David Binderman
Come on, many of packages are hosted on sourceforge, where is also an bugtracker and thus you would need only one account for each of these packages.
I checked and around 12% of the spec files in front of me now appear to indicate that their project is hosted on sourceforge. So it would seem that 88% aren't on sourceforge. I would not regard 12% as "many".
OK, but my opinion is that by reporting bugs about missing fclose etc. to upstream would be much more useful.
It might well be. However, openSuse continues to ask for bug reports in their promotional literature. Of course, not every bug report is designed to be optimal for the openSuse worker. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com