[Bug 858067] New: Socketcan removed as colateral damage with patch 33d736f0040a00b756454f084b199f87cf960b2c(config: disabled CONFIG_SPI and CONFIG_IIO on non-ARM architectures)
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c0 Summary: Socketcan removed as colateral damage with patch 33d736f0040a00b756454f084b199f87cf960b2c(config: disabled CONFIG_SPI and CONFIG_IIO on non-ARM architectures) Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: x86-64 OS/Version: openSUSE 13.1 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: bon@elektron.ikp.physik.tu-darmstadt.de QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 To whom it may concern, patch config: disabled CONFIG_SPI and CONFIG_IIO on non-ARM architectures These devices are found almost entirely on embedded platforms and end up adding hundreds of drivers for hardware that most users won't have. On systems using them, they are more likely to be embedded systems that should probably have a specialized kernel anyway. also removed items belonging to the socketcan subsystem. Socketcan is not limited to ARM/SPI/IIO, in fact I use USB CAN adapters on X86. The item removals causing the damage are in the first lines of the patch: --- a/config/i386/vanilla +++ b/config/i386/vanilla @@ -1,6 +1,6 @@ # # Automatically generated file; DO NOT EDIT. -# Linux/i386 3.8.1 Kernel Configuration +# Linux/i386 3.8.2 Kernel Configuration # # CONFIG_64BIT is not set CONFIG_X86_32=y @@ -1200,7 +1200,6 @@ CONFIG_NET_EMATCH_U32=m CONFIG_NET_EMATCH_META=m CONFIG_NET_EMATCH_TEXT=m -CONFIG_NET_EMATCH_CANID=m CONFIG_NET_EMATCH_IPSET=m CONFIG_NET_CLS_ACT=y CONFIG_NET_ACT_POLICE=m @@ -1258,50 +1257,7 @@ CONFIG_BAYCOM_PAR=m CONFIG_BAYCOM_EPP=m CONFIG_YAM=m -CONFIG_CAN=m -CONFIG_CAN_RAW=m -CONFIG_CAN_BCM=m -CONFIG_CAN_GW=m - -# -# CAN Device Drivers -# -CONFIG_CAN_VCAN=m -CONFIG_CAN_SLCAN=m -CONFIG_CAN_DEV=m -CONFIG_CAN_CALC_BITTIMING=y -CONFIG_CAN_MCP251X=m -CONFIG_PCH_CAN=m -# CONFIG_CAN_GRCAN is not set -CONFIG_CAN_SJA1000=m -CONFIG_CAN_SJA1000_ISA=m -CONFIG_CAN_SJA1000_PLATFORM=m -# CONFIG_CAN_SJA1000_OF_PLATFORM is not set -CONFIG_CAN_EMS_PCMCIA=m -CONFIG_CAN_EMS_PCI=m -CONFIG_CAN_PEAK_PCMCIA=m -CONFIG_CAN_PEAK_PCI=m -CONFIG_CAN_PEAK_PCIEC=y -CONFIG_CAN_KVASER_PCI=m -CONFIG_CAN_PLX_PCI=m -CONFIG_CAN_TSCAN1=m -CONFIG_CAN_C_CAN=m -CONFIG_CAN_C_CAN_PLATFORM=m -CONFIG_CAN_C_CAN_PCI=m -CONFIG_CAN_CC770=m -CONFIG_CAN_CC770_ISA=m -CONFIG_CAN_CC770_PLATFORM=m - -# -# CAN USB interfaces -# -CONFIG_CAN_EMS_USB=m -# CONFIG_CAN_ESD_USB2 is not set -CONFIG_CAN_KVASER_USB=m -CONFIG_CAN_PEAK_USB=m -CONFIG_CAN_SOFTING=m -CONFIG_CAN_SOFTING_CS=m -# CONFIG_CAN_DEBUG_DEVICES is not set +# CONFIG_CAN is not set CONFIG_IRDA=m Please revive these items/ Reproducible: Always Steps to Reproduce: 1.Use kernel > 3.8.2 2. Look for socketcan related modules. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c1
Borislav Petkov
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c2
--- Comment #2 from Uwe Bonnes
While we can't change configs of already released products, we could take this into consideration for future ones...
Please do at least for the KOTD. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c3
--- Comment #3 from Borislav Petkov
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c4
--- Comment #4 from Egbert Eich
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c11
Egbert Eich
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c12
--- Comment #12 from Uwe Bonnes
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c13
Uwe Bonnes
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c14
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c15
Uwe Bonnes
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c16
Takashi Iwai
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c17
Jean Delvare
While we can't change configs of already released products, (...)
This is not quite true. Nothing prevents us from changing the kernel configuration as part of a maintenance update. This is no different from adding or removing patches as needed. As long as we have a good reason for the change, and there is no risk of introducing a regression for other users, this is something we can do. In this specific case, CAN support has been enabled in openSUSE kernels since version 11.0. Suddenly removing support in openSUSE 13.1 while some users were relying on it is a regression. As such, I believe it deserves to be fixed in released products, in this case openSUSE 13.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c18
--- Comment #18 from Jean Delvare
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c19
Jean Delvare
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c
Swamp Workflow Management
https://bugzilla.novell.com/show_bug.cgi?id=858067
https://bugzilla.novell.com/show_bug.cgi?id=858067#c20
--- Comment #20 from Swamp Workflow Management
http://bugzilla.novell.com/show_bug.cgi?id=858067
Swamp Workflow Management
participants (1)
-
bugzilla_noreply@novell.com