[Bug 858067] New: Socketcan removed as colateral damage with patch 33d736f0040a00b756454f084b199f87cf960b2c(config: disabled CONFIG_SPI and CONFIG_IIO on non-ARM architectures)
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c0 Summary: Socketcan removed as colateral damage with patch 33d736f0040a00b756454f084b199f87cf960b2c(config: disabled CONFIG_SPI and CONFIG_IIO on non-ARM architectures) Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: x86-64 OS/Version: openSUSE 13.1 Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: bon@elektron.ikp.physik.tu-darmstadt.de QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 To whom it may concern, patch config: disabled CONFIG_SPI and CONFIG_IIO on non-ARM architectures These devices are found almost entirely on embedded platforms and end up adding hundreds of drivers for hardware that most users won't have. On systems using them, they are more likely to be embedded systems that should probably have a specialized kernel anyway. also removed items belonging to the socketcan subsystem. Socketcan is not limited to ARM/SPI/IIO, in fact I use USB CAN adapters on X86. The item removals causing the damage are in the first lines of the patch: --- a/config/i386/vanilla +++ b/config/i386/vanilla @@ -1,6 +1,6 @@ # # Automatically generated file; DO NOT EDIT. -# Linux/i386 3.8.1 Kernel Configuration +# Linux/i386 3.8.2 Kernel Configuration # # CONFIG_64BIT is not set CONFIG_X86_32=y @@ -1200,7 +1200,6 @@ CONFIG_NET_EMATCH_U32=m CONFIG_NET_EMATCH_META=m CONFIG_NET_EMATCH_TEXT=m -CONFIG_NET_EMATCH_CANID=m CONFIG_NET_EMATCH_IPSET=m CONFIG_NET_CLS_ACT=y CONFIG_NET_ACT_POLICE=m @@ -1258,50 +1257,7 @@ CONFIG_BAYCOM_PAR=m CONFIG_BAYCOM_EPP=m CONFIG_YAM=m -CONFIG_CAN=m -CONFIG_CAN_RAW=m -CONFIG_CAN_BCM=m -CONFIG_CAN_GW=m - -# -# CAN Device Drivers -# -CONFIG_CAN_VCAN=m -CONFIG_CAN_SLCAN=m -CONFIG_CAN_DEV=m -CONFIG_CAN_CALC_BITTIMING=y -CONFIG_CAN_MCP251X=m -CONFIG_PCH_CAN=m -# CONFIG_CAN_GRCAN is not set -CONFIG_CAN_SJA1000=m -CONFIG_CAN_SJA1000_ISA=m -CONFIG_CAN_SJA1000_PLATFORM=m -# CONFIG_CAN_SJA1000_OF_PLATFORM is not set -CONFIG_CAN_EMS_PCMCIA=m -CONFIG_CAN_EMS_PCI=m -CONFIG_CAN_PEAK_PCMCIA=m -CONFIG_CAN_PEAK_PCI=m -CONFIG_CAN_PEAK_PCIEC=y -CONFIG_CAN_KVASER_PCI=m -CONFIG_CAN_PLX_PCI=m -CONFIG_CAN_TSCAN1=m -CONFIG_CAN_C_CAN=m -CONFIG_CAN_C_CAN_PLATFORM=m -CONFIG_CAN_C_CAN_PCI=m -CONFIG_CAN_CC770=m -CONFIG_CAN_CC770_ISA=m -CONFIG_CAN_CC770_PLATFORM=m - -# -# CAN USB interfaces -# -CONFIG_CAN_EMS_USB=m -# CONFIG_CAN_ESD_USB2 is not set -CONFIG_CAN_KVASER_USB=m -CONFIG_CAN_PEAK_USB=m -CONFIG_CAN_SOFTING=m -CONFIG_CAN_SOFTING_CS=m -# CONFIG_CAN_DEBUG_DEVICES is not set +# CONFIG_CAN is not set CONFIG_IRDA=m Please revive these items/ Reproducible: Always Steps to Reproduce: 1.Use kernel > 3.8.2 2. Look for socketcan related modules. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c1 Borislav Petkov <bpetkov@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Final |13.2 Milestone 0 Component|Kernel |Kernel CC| |bpetkov@suse.com Target Milestone|--- |13.2 Milestone 0 Product|openSUSE 13.1 |openSUSE Factory --- Comment #1 from Borislav Petkov <bpetkov@suse.com> 2014-01-22 23:28:09 UTC --- While we can't change configs of already released products, we could take this into consideration for future ones... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c2 --- Comment #2 from Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de> 2014-01-23 10:12:16 UTC --- (In reply to comment #1)
While we can't change configs of already released products, we could take this into consideration for future ones...
Please do at least for the KOTD. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c3 --- Comment #3 from Borislav Petkov <bpetkov@suse.com> 2014-01-23 11:00:28 UTC --- KOTD is not any different - it is a daily snapshot of an already released product. If you still want to disable that stuff, you can build your own opensuse kernel: http://kernel.opensuse.org/ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c4 --- Comment #4 from Egbert Eich <eich@suse.com> 2014-02-04 15:41:55 UTC --- Created an attachment (id=577116) --> (http://bugzilla.novell.com/attachment.cgi?id=577116) Readd CAN support The patch contains the changes required to enable CAN support. It should get re-enabled at least for x86 and x86_64. Uwe, could you please check if anything is missing? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c11 Egbert Eich <eich@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |bon@elektron.ikp.physik.tu- | |darmstadt.de --- Comment #11 from Egbert Eich <eich@suse.com> 2014-02-05 16:40:08 UTC --- Let's set this NEEDINFO to the reporter so he can look at the patch on comment #4. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c12 --- Comment #12 from Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de> 2014-02-05 22:23:41 UTC --- The patch looks good but I am away from the hardware to test until next Monday. I will try then and report. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c13 Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW CC| |bon@elektron.ikp.physik.tu- | |darmstadt.de InfoProvider|bon@elektron.ikp.physik.tu- | |darmstadt.de | --- Comment #13 from Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de> 2014-02-19 14:20:07 UTC --- I applied Egberts patch to several KOTD by patching /lib/modules/3.xx/.../build/.config, recompling the kernel and modules and installing the can related modules. Everything went fine and the modules work as expected. However Egbert left out the CONFIG_CAN_DEBUG_DEVICES option: -+# CONFIG_CAN_DEBUG_DEVICES is not set ++CONFIG_CAN_DEBUG_DEVICES=y I have no strong argument to reenable CONFIG_CAN_DEBUG_DEVICES as it was before, but if problems arise enabled debug options are of help and worth the larger files i.m.h.o. Thanks -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c14 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |tiwai@suse.com InfoProvider| |bon@elektron.ikp.physik.tu- | |darmstadt.de --- Comment #14 from Takashi Iwai <tiwai@suse.com> 2014-03-18 14:40:34 UTC --- If you have a renewed patch, please provide, so that we can apply it to git master branch. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c15 Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #577116|0 |1 is obsolete| | Status|NEEDINFO |NEW InfoProvider|bon@elektron.ikp.physik.tu- | |darmstadt.de | --- Comment #15 from Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de> 2014-03-18 14:50:01 UTC --- Created an attachment (id=582611) --> (http://bugzilla.novell.com/attachment.cgi?id=582611) Patch to restore socketcan functionality Applies cleanly to 3.14.0-rc6-3.gd1a7ba5-desktop like: /lib/modules/3.14.0-rc6-3.gd1a7ba5-desktop/build # cat /usr/src /socketcan_config_diff |patch -s --dry-run -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c16 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #16 from Takashi Iwai <tiwai@suse.com> 2014-03-19 08:36:50 UTC --- OK, fixed now in kernel git master branch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c17 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |jdelvare@suse.com Resolution|FIXED | AssignedTo|kernel-maintainers@forge.pr |jdelvare@suse.com |ovo.novell.com | --- Comment #17 from Jean Delvare <jdelvare@suse.com> 2014-04-29 09:35:19 UTC --- (In reply to comment #1)
While we can't change configs of already released products, (...)
This is not quite true. Nothing prevents us from changing the kernel configuration as part of a maintenance update. This is no different from adding or removing patches as needed. As long as we have a good reason for the change, and there is no risk of introducing a regression for other users, this is something we can do. In this specific case, CAN support has been enabled in openSUSE kernels since version 11.0. Suddenly removing support in openSUSE 13.1 while some users were relying on it is a regression. As such, I believe it deserves to be fixed in released products, in this case openSUSE 13.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c18 --- Comment #18 from Jean Delvare <jdelvare@suse.com> 2014-04-29 09:40:56 UTC --- I also would like to adjust the configuration a bit: * CAN support makes no sense in ec2 kernels. * The CAN_GRCAN and CAN_TSCAN1 config options enable specific/embedded hardware support which I believe is out of scope for openSUSE/x86, so we could disable these. Same for CAN_SJA1000_OF_PLATFORM in openSUSE 13.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c19 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #19 from Jean Delvare <jdelvare@suse.com> 2014-05-14 19:26:28 UTC --- Fixed in openSUSE 13.1 now: commit 99de145fe02adebb0f00816901427499def00f2b Author: Jean Delvare <jdelvare@suse.de> Date: Wed May 14 18:20:57 2014 +0200 Enable Socketcan again for i386 and x86_64 (bnc#858067) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |obs:running:2876:important -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=858067 https://bugzilla.novell.com/show_bug.cgi?id=858067#c20 --- Comment #20 from Swamp Workflow Management <swamp@suse.de> 2014-06-25 07:05:13 UTC --- openSUSE-SU-2014:0840-1: An update that solves 9 vulnerabilities and has 15 fixes is now available. Category: security (important) Bug References: 851338,858067,868315,869563,870173,870576,871561,872715,873374,876102,876981,877257,877713,877721,878115,878274,879258,879792,880599,880613,880892,881697,881727,882648 CVE References: CVE-2013-7339,CVE-2014-0055,CVE-2014-0077,CVE-2014-2678,CVE-2014-2851,CVE-2014-3122,CVE-2014-3144,CVE-2014-3145,CVE-2014-3153 Sources used: openSUSE 13.1 (src): cloop-2.639-11.10.1, crash-7.0.2-2.10.9, hdjmod-1.28-16.10.1, ipset-6.21.1-2.14.1, iscsitarget-1.4.20.3-13.10.1, kernel-docs-3.11.10-17.6, kernel-source-3.11.10-17.2, kernel-syms-3.11.10-17.1, ndiswrapper-1.58-10.1, pcfclock-0.44-258.10.1, vhba-kmp-20130607-2.11.1, virtualbox-4.2.18-2.15.2, xen-4.3.2_01-18.2, xtables-addons-2.3-2.10.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=858067 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|obs:running:2876:important | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com