[Bug 1065551] Samba daemon should be started as foreground process from smb.service
http://bugzilla.suse.com/show_bug.cgi?id=1065551 http://bugzilla.suse.com/show_bug.cgi?id=1065551#c7 --- Comment #7 from Aurelien Aptel <aaptel@suse.com> --- Here's a diff (- is upstream, + is ours) with some personal analysis. I'm still for keeping ours. --- samba-4.7.3+git.30.54c196e5d35/packaging/systemd/smb.service 2017-11-29 16:17:28.000000000 +0100 +++ vendor-files-git.4adce31/systemd/smb.service 2017-11-03 15:58:19.000000000 +0100 @@ -1,16 +1,16 @@ [Unit] Description=Samba SMB Daemon -After=syslog.target network.target nmb.service winbind.service +After=network.target nmb.service winbind.service ^^^ we can keep upstream [Service] Type=notify NotifyAccess=all -PIDFile=/run/smbd.pid ^^^ wrong path +Environment=KRB5CCNAME=/run/samba/krb5cc_samba ^^^ don't know what this is for LimitNOFILE=16384 EnvironmentFile=-/etc/sysconfig/samba +ExecStartPre=/usr/share/samba/update-apparmor-samba-profile ^^^ this script makes dynamic apparmor rules based on the smb.conf. we need to keep this AFAIK ExecStart=/usr/sbin/smbd $SMBDOPTIONS ExecReload=/usr/bin/kill -HUP $MAINPID -LimitCORE=infinity ^^^ maximum size of core files created. upstream is infinite, ours is the default, defined somewhere else. [Install] WantedBy=multi-user.target -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com