[Bug 657360] New: partitioner error code -1012, failed to set partition ID

newer
[Bug 378416] Don't mark builds as...

older
[Bug 342657] wipebinaries does not...

bugzilla_noreply＠novell.com

3 Dec 2010 3 Dec '10

10:00

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c0 Summary: partitioner error code -1012, failed to set partition ID Classification: openSUSE Product: openSUSE 11.4 Version: Milestone 4 of 6 Platform: x86 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Installation AssignedTo: aschnell@novell.com ReportedBy: mvidner@novell.com QAContact: jsrain@novell.com Found By: Development Blocker: --- I am installing M4 from the Live KDE image off an USB stick (/dev/sdb), having chosen Installation at boot time. The target machine is an EeePC with 3 primary partitions and 50GB of unpartitioned space. The installer proposes to create sda4 as an extended partition with sda5 and sda6 as / and /home. Fine. When the installation starts, it creates sda4 and then tries to set sda4 to type F which results in an error pop-up citing error code -1012. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

3 Dec 3 Dec

11:07

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c2 --- Comment #2 from Martin Vidner 2010-12-03 12:07:34 CET --- Created an attachment (id=403316) --> (http://bugzilla.novell.com/attachment.cgi?id=403316) y2logs.tgz, search for "1012" in y2log -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

11:49

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c3 Arvin Schnell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@novell.com AssignedTo|aschnell@novell.com |puzel@novell.com --- Comment #3 from Arvin Schnell 2010-12-03 11:49:34 UTC --- After creating the extended partition sda4 YaST calls parted to set the boot flag off. Here parted cannot inform the kernel about the change to the partition table. /usr/sbin/parted -s '/dev/sda' set 4 boot off Error: Partition(s) 4 on /dev/sda have been written, but we have been unable to inform the kernel of the change, probably because it/they are in use. As a result, the old partition(s) will remain in use. You should reboot now before making further changes. I cannot see a reason why informing the kernel should fail. A few seconds earlier setting lvm and raid off works fine. Maybe the usual suspect udev? Petr, any idea? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

7 Dec 7 Dec

11:00

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

...

I cannot see a reason why informing the kernel should fail. A few seconds earlier setting lvm and raid off works fine. Maybe the usual suspect udev?

Yes, that would be my guess: udev or whatever called by udev. In parted-2.3, there is already the logic "inform the kernel; if (!success) sleep and retry". The maximum sleep is one second [*]. I really have no idea (nobody seems to have) how to make informing the kernel about PT changes 100% reliable without rebooting. Two ideas how to make it at least more reliable than it is now: 1/ increase the max sleep time [*] to - let's say - 2 seconds to give udev (or whatever it is) more time to scan the disk (which is as far as I understand triggered by the uevent that is generated when the partition is added) and close it. 2/ as far as I remember, we have usually seen these "can not inform the kernel.." messages after setting some partition flag. Furthermore, as far as I can see, the kernel does not care about the partition flags, so I think I could patch parted not to inform the kernel about any changes after 'set flag state' command. Arvin, does this make sense? Or do you have any better idea? Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:20

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c6 Arvin Schnell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|aschnell@novell.com | --- Comment #6 from Arvin Schnell 2010-12-07 13:20:31 UTC --- I just noticed one problem in libstorage and improved it: So far libstorage used several parted calls to set the partition flags, e.g. one for 'lvm off' and one for 'raid on'. And libstorage did only one 'udevadm --settle' at the end of all these calls not in between. I have now changed libstorage to use only one parted call for all flags. This should already improve the situation. And your ideas from comment #4 look fine to us. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:29

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c Petr Uzel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

13:48

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c7 --- Comment #7 from Petr Uzel 2010-12-07 13:48:26 UTC --- I'm afraid your change in libstorage does not improve the situation, but rather make it even worse, because parted -s /dev/XXX set X raid on set X lvm off will inform the kernel _twice_ (yeah, sorry, but that's how parted is implemented and it can be hardly changed). Just the time gap will be shorter :( Even with the change 2/ from comment #4, I think it would be better if libstorage called parted for each flag individually, with 'udevadm --settle' calls in between.

...

And your ideas from comment #4 look fine to us.

So I'll implement them. Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

16:21

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c8 --- Comment #8 from Arvin Schnell 2010-12-07 16:21:34 UTC --- Hm, parted should do a udevadm settle after informing the kernel. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

8 Dec 8 Dec

12:10

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c9 --- Comment #9 from Petr Uzel 2010-12-08 12:10:44 UTC --- (In reply to comment #8)

...

Hm, parted should do a udevadm settle after informing the kernel.

Ack. We had this call-udevadm patch in parted before, but I removed it after parted upstream introduced the improved 'wait and retry' logic. I'll add it back. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

9 Dec 9 Dec

09:47

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c10 Petr Uzel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #10 from Petr Uzel 2010-12-09 09:47:47 UTC --- Submitted to Factory: - max sleep interval increased form 1 to 2 seconds - call udevadm settle --timeout=20 before informing the kernel about changes - do not inform the kernel if only partition flags have changed @Martin: it would be great if you could test installation with next Milestone. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

10 Jan 10 Jan

10:40

New subject: [Bug 657360] partitioner error code -1012, failed to set partition ID

https://bugzilla.novell.com/show_bug.cgi?id=657360 https://bugzilla.novell.com/show_bug.cgi?id=657360#c11 Martin Vidner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED --- Comment #11 from Martin Vidner 2011-01-10 11:40:12 CET --- I have deleted sda4 and installed M5. The bug did not appear. Thank you Petr and Arvin! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4861

Age (days ago)

4899

Last active (days ago)

List overview

Download

10 comments

1 participants

participants (1)

bugzilla_noreply＠novell.com

[Bug 657360] New: partitioner error code -1012, failed to set partition ID

tags

participants (1)