[Bug 246807] New: libstorage passes floating point to find(1)
https://bugzilla.novell.com/show_bug.cgi?id=246807 Summary: libstorage passes floating point to find(1) Product: openSUSE 10.2 Version: Final Platform: PowerPC OS/Version: Linux Status: NEW Severity: Normal Priority: P5 - None Component: Installation AssignedTo: yast2-maintainers@suse.de ReportedBy: olh@novell.com QAContact: jsrain@novell.com AppUtil.cc calls "-printf '%f %l'". at least in 10.2 this leads to a floating point value in the y2log Maybe it should have been '%%f %%l'? I see the same code in 10.3 and sp1, but there is '%f %l' in the (sp1) logs. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 ------- Comment #1 from olh@novell.com 2007-02-19 13:14 MST ------- Created an attachment (id=119996) --> (https://bugzilla.novell.com/attachment.cgi?id=119996&action=view) bug246807.tar.bz2 logs from pepper.suse.de -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 jdsn@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|yast2-maintainers@suse.de |fehr@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 fehr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|fehr@novell.com |mt@novell.com ------- Comment #2 from fehr@novell.com 2007-02-20 08:12 MST ------- This is a problem with our logging function not with libstorage. The find command is executed as expected just the log lines are garbled. Since the log lines are as expected in code 10 I assume this is caused by new blocxx library that is used for logging since 10.2. Reassigning to Marius. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 mt@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 ------- Comment #3 from mt@novell.com 2007-02-21 05:16 MST ------- Created an attachment (id=120283) --> (https://bugzilla.novell.com/attachment.cgi?id=120283&action=view) proposed fix for 10.2 As far as I see, the expansion is not done in blocxx, but in the log handler (redirecting blocxx->y2logger) implemented in yast2. Until now, I was unable to test it, because init_buildsystem fails all the time. The problem exists in 10.0 and 10.1 as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 mt@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mt@novell.com |mvidner@novell.com Status|ASSIGNED |NEW ------- Comment #4 from mt@novell.com 2007-02-21 05:20 MST ------- Martin, can you verify if the above patch is correct and apply it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 ------- Comment #5 from mt@novell.com 2007-02-21 05:28 MST ------- BTW: In some dists this may not happen, because libstorage installs own blocxx log handler and writes directly to the y2log file. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 mvidner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807 mvidner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #6 from mvidner@novell.com 2007-02-26 10:08 MST ------- Thanks for the patch Marius! yast2-devtools already passes -Wformat to C(XX)FLAGS. It seems we should step up to -Wformat=2 to catch this kind of bugs. I caught more bugs of this kind by it, though none as visible as this one. Fixed yast2-core and yast2-devtools in SVN trunk. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=246807
Olaf Hering
participants (1)
-
bugzilla_noreply＠novell.com