[Bug 1208584] New: grub-snapper-plugin drops Windows entry on "rollback"
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 Bug ID: 1208584 Summary: grub-snapper-plugin drops Windows entry on "rollback" Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Bootloader Assignee: screening-team-bugs@suse.de Reporter: lubos.kocman@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Hello team seems that snapper-grub-plugin (whatever is responsible for the grub2 change of boot targets) drops Windows boot entries after the newly updated snapshot is recognized as "broken". Essentially the same thing happened to me last week in MicroOS https://www.reddit.com/r/openSUSE/comments/zm12e0/microos_wants_to_rollback_... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c1 --- Comment #1 from Lubos Kocman <lubos.kocman@suse.com> --- Seems like the os-prober is present: lkocman@localhost:~> sudo grep Windows /etc/grub.d/* /etc/grub.d/30_os-prober: Windows\ Vista*|Windows\ 7*|Windows\ Server\ 2008*) Just to specify my layout: (two nvme disks one Linux-only, the other one Windows-only) lkocman@localhost:~> sudo fdisk -l Disk /dev/nvme1n1: 953,87 GiB, 1024209543168 bytes, 2000409264 sectors Disk model: KINGSTON SKC3000S1024G Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disklabel type: gpt Disk identifier: E0B91263-D7A9-4225-98A5-D03FFC8D538E Device Start End Sectors Size Type /dev/nvme1n1p1 2048 1050623 1048576 512M EFI System /dev/nvme1n1p2 1050624 2000409230 1999358607 953,4G Linux filesystem Disk /dev/nvme0n1: 1,82 TiB, 2000398934016 bytes, 3907029168 sectors Disk model: KINGSTON SNV2S2000G Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disklabel type: gpt Disk identifier: 01DE65FD-53B3-488F-8DE7-628D3F0230DC Device Start End Sectors Size Type /dev/nvme0n1p1 2048 206847 204800 100M EFI System /dev/nvme0n1p2 206848 239615 32768 16M Microsoft reserved /dev/nvme0n1p3 239616 3907025943 3906786328 1,8T Microsoft basic data lkocman@localhost:~> -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c2 --- Comment #2 from Lubos Kocman <lubos.kocman@suse.com> --- lkocman@localhost:~> sudo grub2-mkconfig | grep -i Windows Generating grub configuration file ... Found theme: /boot/grub2/themes/openSUSE/theme.txt Found linux image: /boot/vmlinuz-6.1.12-1-default Found initrd image: /boot/initrd-6.1.12-1-default !! SEEMS LIKE THIS IS THE ACTUAL ISSUE !! Warning: os-prober will not be executed to detect other bootable partitions. Systems on them will not be added to the GRUB boot configuration. Check GRUB_DISABLE_OS_PROBER documentation entry. Adding boot menu entry for UEFI Firmware Settings ... done -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 Lubos Kocman <lubos.kocman@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|grub-snapper-plugin drops |GRUB_DISABLE_OS_PROBER |Windows entry on "rollback" |trashes windows entries on | |automatic system rollback -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c3 --- Comment #3 from Lubos Kocman <lubos.kocman@suse.com> --- lkocman@localhost:~> grep PROBER /etc/default/grub GRUB_DISABLE_OS_PROBER="true" -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c4 --- Comment #4 from Lubos Kocman <lubos.kocman@suse.com> --- After the change lkocman@localhost:~> grep PROBER /etc/default/grub GRUB_DISABLE_OS_PROBER="false" lkocman@localhost:~> sudo grub2-mkconfig | grep -i Windows Generating grub configuration file ... Found theme: /boot/grub2/themes/openSUSE/theme.txt Found linux image: /boot/vmlinuz-6.1.12-1-default Found initrd image: /boot/initrd-6.1.12-1-default Warning: os-prober will be executed to detect other bootable partitions. Its output will be used to detect bootable binaries on them and create new boot entries. Found Windows Boot Manager on /dev/nvme0n1p1@/efi/Microsoft/Boot/bootmgfw.efi menuentry 'Windows Boot Manager (on /dev/nvme0n1p1)' --class windows --class os $menuentry_id_option 'osprober-efi-768D-6013' { Adding boot menu entry for UEFI Firmware Settings ... done -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c4 --- Comment #4 from Lubos Kocman <lubos.kocman@suse.com> --- After the change lkocman@localhost:~> grep PROBER /etc/default/grub GRUB_DISABLE_OS_PROBER="false" lkocman@localhost:~> sudo grub2-mkconfig | grep -i Windows Generating grub configuration file ... Found theme: /boot/grub2/themes/openSUSE/theme.txt Found linux image: /boot/vmlinuz-6.1.12-1-default Found initrd image: /boot/initrd-6.1.12-1-default Warning: os-prober will be executed to detect other bootable partitions. Its output will be used to detect bootable binaries on them and create new boot entries. Found Windows Boot Manager on /dev/nvme0n1p1@/efi/Microsoft/Boot/bootmgfw.efi menuentry 'Windows Boot Manager (on /dev/nvme0n1p1)' --class windows --class os $menuentry_id_option 'osprober-efi-768D-6013' { Adding boot menu entry for UEFI Firmware Settings ... done --- Comment #5 from Lubos Kocman <lubos.kocman@suse.com> --- After the change lkocman@localhost:~> grep PROBER /etc/default/grub GRUB_DISABLE_OS_PROBER="false" lkocman@localhost:~> sudo grub2-mkconfig | grep -i Windows Generating grub configuration file ... Found theme: /boot/grub2/themes/openSUSE/theme.txt Found linux image: /boot/vmlinuz-6.1.12-1-default Found initrd image: /boot/initrd-6.1.12-1-default Warning: os-prober will be executed to detect other bootable partitions. Its output will be used to detect bootable binaries on them and create new boot entries. Found Windows Boot Manager on /dev/nvme0n1p1@/efi/Microsoft/Boot/bootmgfw.efi menuentry 'Windows Boot Manager (on /dev/nvme0n1p1)' --class windows --class os $menuentry_id_option 'osprober-efi-768D-6013' { Adding boot menu entry for UEFI Firmware Settings ... done -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c6 --- Comment #6 from Lubos Kocman <lubos.kocman@suse.com> --- I would prefer if we'd have GRUB_DISABLE_OS_PROBER="false" in case of automatic rollbacks on. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c7 --- Comment #7 from Lubos Kocman <lubos.kocman@suse.com> --- Not sure if our distribution default for systems where we expect snapper should change this, or if we should install some extra config for grub that would override the default or simply add this to %post in snapper # ensure that we do not drop entries from os-prober on rollback if [ -f /etc/default/grub ]; then sed -i 's/^GRUB_DISABLE_OS_PROBER="true"/GRUB_DISABLE_OS_PROBER="false"/' /etc/default/grub fi Thoughts? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c8 Stefan Hundhammer <shundhammer@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |aschnell@suse.com --- Comment #8 from Stefan Hundhammer <shundhammer@suse.com> --- Arvin, AFAICS this is one for you. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1208584 http://bugzilla.opensuse.org/show_bug.cgi?id=1208584#c9 --- Comment #9 from Stefan Hundhammer <shundhammer@suse.com> --- The snapper plug-ins come into play here because we are creating snapshots for certain system administration tasks; usually a pre- and a post-snapshot. Package upgrades are one such task, but there are others as well, like shown here. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com