[Bug 699598] New: game moonlander does not start; backgroundpics causes game to end
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c0 Summary: game moonlander does not start; backgroundpics causes game to end Classification: openSUSE Product: openSUSE 11.3 Version: Final Platform: i586 OS/Version: openSUSE 11.3 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: tematee@gmx.de QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.19) Gecko/20110420 SUSE/2.0.14-2.2 Lightning/1.0b1 SeaMonkey/2.0.14 when i start moon-lander 1.0-1039.4 (opensuse 11.3) (but also in previous versions) the game starts, but stop then during the start-progress. it freezes. the reason i found out: the config-file ".moon-lander" in the home directory is not build; so the game uses its defaults. BUG: the defaults are not correct, so the game waits a long time... solution: build a txt-file (.moon-lander) and write this numbers in the file: 3 1 1 1 1 2 in the actual game there are 6 parameters, in older one s only 5 or less.!! next bug i fixed, is the problem when backgrund-pics should be loaded. in the source is a bug: when linux reads the *.jpg from the background- directory it reads . and .. as well. so the game crashes. Reproducible: Always Steps to Reproduce: 1. delete .moon-lander in home-directory 2. start a new game is waits a very long time 3. when you create a .moon-lander and fill in the correct parameters, game functions, but if you enter the autopilot: backgrounds changes often, instead of the JPG the program will load a "." or a ".." or a ".DIRECTORY". it crashes then. Actual Results: i build a patch-file, please have a look at it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c1 --- Comment #1 from hain moser <tematee@gmx.de> 2011-06-13 16:49:54 UTC --- Created an attachment (id=434189) --> (http://bugzilla.novell.com/attachment.cgi?id=434189) patch for moon-lander -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c zj jia <zjjia@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@novell.com AssignedTo|bnc-team-screening@forge.pr |prusnak@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c2 Uli Esch. <tematee@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #434189|0 |1 is obsolete| | --- Comment #2 from Uli Esch. <tematee@gmx.de> 2011-06-15 19:53:05 UTC --- Created an attachment (id=434683) --> (http://bugzilla.novell.com/attachment.cgi?id=434683) advanced patch, solved another small error about backgroundpics the background-pics should displayed randomly, so i added this feature. the "bug" i solved: the code: "(game->back_no < 2) {" should be < 0 and not <2 example: (game->back_no < 0)... so all Backgroundpics can be shown during the game. i greyed it out, because i added the random function in the patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c3 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmo.marques@gmail.com --- Comment #3 from Nelson Marques <nmo.marques@gmail.com> 2011-06-15 21:54:11 UTC --- Hi, I have tested the patch (no code review though, someone more proficient on that has to do it). It builds fine for 11.4 and Factory (tested) and it does fix the issues the game has. I'm submitting an update through OBS: SR73788. For reference: * https://build.opensuse.org/package/show?package=moon-lander&project=home:ketheriel:branches:games * https://build.opensuse.org/request/show/73788 - Thanks for the patch submission and improving openSUSE. Nelson Marques. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c4 --- Comment #4 from Nelson Marques <nmo.marques@gmail.com> 2011-06-15 21:59:07 UTC --- New SR: 73789 (Updated URL on spec). * https://build.opensuse.org/request/show/73789 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c5 Pavol Rusnak <prusnak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Pavol Rusnak <prusnak@novell.com> 2011-06-16 05:11:09 CEST --- SR Accepted, thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c6 --- Comment #6 from Uli Esch. <tematee@gmx.de> 2011-06-16 15:45:59 UTC --- (In reply to comment #4)
New SR: 73789 (Updated URL on spec).
Hello Nelson Marques, sorry, the patch you used is the wrong one! the patch you used in https://build.opensuse.org/request/show/73789 is my oldest solution to the problem; i posted it in the forum before i tried to made the bug report.! the orginal game come has 3 problems: the ".", the ".." and(!) the ".Directory" have to be filtered out of the picture-names, when the program reads the picture-directory. the patch you used only solve the "." and ".." NOT THE ".directory"!! both attachments here in the bug report (comment 2 and comment 3) have a better state in solving the bug i (Jolante = Uli Esch.) reported in the forum! Really sorry. I´m a beginner in forums and in bug reporting aswell, so as you mentioned, somebody who can code should have a look at the patches / the source, but: please use the patches i posted HERE as commend 1 / 2 or better 3!! Thanks a lot! Uli -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c7 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | AssignedTo|prusnak@novell.com |nmo.marques@gmail.com Severity|Normal |Major --- Comment #7 from Nelson Marques <nmo.marques@gmail.com> 2011-06-16 15:54:04 UTC --- I'll take a look at it, though the patch on the forum did solved some of the issues. Re-opened. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c8 --- Comment #8 from Nelson Marques <nmo.marques@gmail.com> 2011-06-16 16:12:44 UTC --- SR 73888: home:ketheriel:branches:games/moon-lander -> games/moon-lander with the patch on comment #2. NM -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c9 --- Comment #9 from Pavol Rusnak <prusnak@novell.com> 2011-06-16 19:02:41 CEST --- Accepted again, could you please test and confirm? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c10 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |tematee@gmx.de --- Comment #10 from Nelson Marques <nmo.marques@gmail.com> 2011-06-16 17:09:47 UTC --- I did tested and see no differences in gameplay. But lets wait for the reporter to confirm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c11 --- Comment #11 from Uli Esch. <tematee@gmx.de> 2011-06-16 19:05:41 UTC --- (In reply to comment #10)
I did tested and see no differences in gameplay. But lets wait for the reporter to confirm.
hello, yes, the patch attached in comment 2 is the "best" i can do. i "played" / tested this patch till now and i can´t see any other bug... let´s say so: i´m used to write programs, but i wrote most programs in turbo pascal, quickbasic (and (little bit) of fortran 77) using MS-DOS (in former times). i´m a beginner in c ( /linux programming). i see structures in the code, know the solutions, but c... somebody with good knowledge about c should have a look at the code; looking for "side effects"; i can´t do any more. thank´s a lot for all Uli -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c12 Uli Esch. <tematee@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED InfoProvider|tematee@gmx.de | --- Comment #12 from Uli Esch. <tematee@gmx.de> 2011-06-17 11:17:58 UTC --- hello, as i replied yesterday, i would say my patches solves the problem, sombody should have a closer look to the code, but i think, the code is ok; my changes aren´t so dramatic. greetings Uli -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=699598 https://bugzilla.novell.com/show_bug.cgi?id=699598#c13 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #13 from Nelson Marques <nmo.marques@gmail.com> 2011-06-17 17:15:10 UTC --- Hi, I did not see any relevant issues with the code to be honest, but I'm not a hardcore programmer, I know a few tricks thats all :) Closing this as it seems to be fixed. The upstream project seems to be dead at least since 2005, so we're kinda good and happy to keep this package alive. Once more Uli, much thanks for helping openSUSE improving and for the patch. NM -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com