https://bugzilla.novell.com/show_bug.cgi?id=432129 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=432129#c16 Stanislav Brabec changed: What |Removed |Added ---------------------------------------------------------------------------- Group|SUSE Enterprise Partner | Severity|Critical |Normal Status|RESOLVED |REOPENED Component|GNOME |GNOME Priority|P5 - None |P4 - Low Product|SUSE Linux Enterprise Desktop 11 |openSUSE 11.1 Resolution|FIXED | Summary|f-spot crashes on first launch and when |libusb-compat: f-spot crashes on first launch |importing |and when importing Target Milestone|Beta 3 |Future/Later --- Comment #16 from Stanislav Brabec 2008-11-05 08:49:32 MST --- I got a reply from upstream considering the fix possibly incorrect. Reopening and decreasing to Normal to resolve this issue correctly. Changing the product to openSUSE to make it visible for upstream. From: Daniel Drake Cc: libusb-devel@lists.sourceforge.net Subject: Re: [Libusb-devel] libusb-compat: Fix crash if usb not initialized (more crashes fixed) Date: Sun, 02 Nov 2008 21:53:34 +0000 (22:53 CET) Stanislav Brabec wrote:

Stanislav Brabec wrote:

...

Attached patch fixes crash, if USB is not initialized.

And attached update fixes even more crashes, if USB is not initialized. It replaces previous one.

Thanks for the patch!

...

Affected application: F-Spot Author: Marcus Meissner Reference: https://bugzilla.novell.com/show_bug.cgi?id=432129

I have to sign up to see this bug report? From the 1 line description, it sounds like a F-Spot bug using libusb before it's initialized. I'm interested in matching the behaviour of libusb-0.1.12, but only if we do it precisely, which your patch doesn't quite do. For example, usb_close() on a NULL pointer will cause libusb-0.1.12 to crash, whereas your patch makes libusb-compat return -EINVAL. Also, nitpicking: there are some coding style flaws, please try and match the rest of the file. Some of the patch is fine, some uses spaces for indentation and has 'if' conditions and bodies on the same line. cheers Daniel -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.