https://bugzilla.novell.com/show_bug.cgi?id=441828 Ján Kupec changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|yast2-maintainers@suse.de |sh@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |#8d43 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User ciobi@inbox.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c1 Marian Ciobanu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ciobi@inbox.com --- Comment #1 from Marian Ciobanu 2008-11-09 03:52:15 MST --- Some suggestions to address this, also considering that if the widths are adjusted manually, all the changes are lost when we move to another filter or item inside a filter (package group, pattern, ...): 1) Remember the column widths in a YaST2 session when moving from one filter to another, and perhaps remember the column widths across sessions (which would also sort of need remembering the size of the window). Or perhaps have an "auto-size", given that the space needs vary as the list content changes. However, "auto-size" is not easy to do right, because in many cases there won't be enough space for all the text to be displayed and the question is which ones to shrink and by how much. Besides, just determining the desired widths can take too much time. OTOH the code to get and set column widths in Qt4 is pretty simple, and hopefully integrating it in YaST is not too difficult either. 2) Shrink "Size", enlarge "Installed (Available)" and make "Summary" the stretchable column. Or, what seems better to me but takes more coding, have "Size" use a fixed width and the other columns stretchable. "Size" is the only column that really doesn't benefit from stretching, its maximum width being small and easy to calculate. (IIRC, having multiple stretchable columns in a QTableView makes them all have the same size, which we probably wouldn't want in this case, but it's not that bad; it's possible, though, that I didn't research this area enough or that you are not using QTableView. Also, it's not too hard to do a proportional resize manually when the grid is resized.) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c3 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Minor |Normal Priority|P5 - None |P2 - High --- Comment #3 from Stefan Hundhammer 2008-11-12 10:09:26 MST --- There doesn't seem to be a simple way to fix this with Qt4. In the current version (yast2-qt-2.17.19, yast2-qt-pkg-2.17.15) the width of the "size" column is fixed to match its content, and if the user resizes columns, the resized widths remain in effect even if the table content is cleared and completely replaced. But there doesn't seem to be a reasonable way in Qt4 to have table columns resize to fit their content, stretchable, and user-resizable. You can have any one of the three, but not a combination. Will keep investigating; this is really annoying. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User ciobi@inbox.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c5 --- Comment #5 from Marian Ciobanu 2008-11-12 16:17:45 MST --- Sorry, in Comment #4 "horizontalHeader()->setResizeMode(1, QHeaderView::Stretch);" should be replaced by "header()->setResizeMode(summaryCol(), QHeaderView::Stretch);"; I copied the code from a QTableView and forgot to adapt it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 Stefan Hundhammer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Qt4-Pkg] Size column too wide while other |[Qt4-Pkg] Column widths in package list |columns are too small | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User ciobi@inbox.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c8 --- Comment #8 from Marian Ciobanu 2008-11-13 05:45:04 MST --- Created an attachment (id=251881) --> (https://bugzilla.novell.com/attachment.cgi?id=251881) stretchable column example Stefan, I think I understand what you are saying, but I don't think you're right. What I'm saying is that you can have 1 stretchable column and the others user-sizable, and I'm attaching a little program to prove it (in HeaderResize.tar.bz2). All the widths are adjusted by clicking and moving the separator at their right, except for column "3", which is stretchable. It looks a little weird, because when you resize columns "4", "5" or "6" they extend to the left; anyway, they expand and shrink in a consistent manner. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User danielstefanmader@web.de added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c10 Daniel Mader changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielstefanmader@web.de --- Comment #10 from Daniel Mader 2008-11-21 08:48:52 MST --- Hello, am I missing something or is there no patch yet included in Beta 5.2? Bug #406631 mentioned something about some fixes? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User danielstefanmader@web.de added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c12 --- Comment #12 from Daniel Mader 2008-12-01 05:11:59 MST --- I am still at a loss here: the issue with too small columns, especially for the available/installed version is not fixed it RC1. What am I missing here? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User sh@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c14 --- Comment #14 from Stefan Hundhammer 2008-12-02 07:24:28 MST --- If only it were so simple... Column handling changed a lot with Qt4. It used to be pretty smart in Qt3, but now most of the responsiblity is being relegated to the application. Unfortunately, there is no mode that does all the things we' like to have here: Adapt to content width, stretch to use all available space, yet allow the user to resize the columns manually. Those three options are now mutually exclusive. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User ciobi@inbox.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c16 --- Comment #16 from Marian Ciobanu 2008-12-11 13:28:49 MST --- Created an attachment (id=259514) --> (https://bugzilla.novell.com/attachment.cgi?id=259514) Proposed solution for resizing the columns I'm working on an open source program which needs for a QTableView to show as much information as possible. Now that I'm (mostly) done with that, I adapted it to work with a QTreeWidget and I tested it in YaST to address this bug. Since I'm quite pleased with the results, I'm posting a patch in the hope that others will have a look and perhaps it will be integrated into the official build. The main idea is to resize the columns based on cell content, after the list has been populated. The way my class is connected now to YaST is more of a hack currently, but improving this is no big deal. In the attachment I included the patch as well as the changed/new files, so they can be easy looked at. To build YaST, have a look at http://en.opensuse.org/YaST_Development To apply the patch, copy ColumnResize.patch to <YaST-dir>trunk/qt-pkg , then go to <YaST-dir>trunk/qt-pkg/src and run: patch -p1 < ../ColumnResize.patch Please let me know if you have trouble building or if you think the resizing can be significantly improved (there should be no horizontal scrollbar and most of the content should be visible, but it may be that what I did works well on my machine and not so well on others). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User schaefer.frank@gmx.net added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c17 --- Comment #17 from Frank Schäfer 2009-02-08 10:54:01 MST --- Created an attachment (id=271070) --> (https://bugzilla.novell.com/attachment.cgi?id=271070) Another patch for discussion I've found some time this weekend to take a look at this issue: First of all: thank you Marian for your patch. I've tested it and it works without problems, the results are OK for me. But I guess the main problem with this patch is, that it might be a bit too complicated. It adds much code, which then has to be maintained by Stefan...(Stefan, tell us the truth ;-) ). However, I've written another (simpler) patch for discussion: It adds a new function YQPkgList::optimizeColumnWidths() and calls it each time a package is added to the list (YQPkgList::addPkgItem(...)). It does the following: 1.) get optimal widths by setting them with QTreeView::resizeColumnToContents(...) 2.) determines visible width of the Widget 3.) calculates difference of both values 4.) optimizes column widths according to the following strategy: - distribute overhead space to all columns (except the status-icon-columns), if we have more space than we need => +: looks much better => -: we waste space when the window is resized (to a smaller width), because there is currently no column width adjustment/optimization on resize-events - reduces width of the "summary"-column (there is a lower limit), if we have less space than we need; if that is not enough, we will get a horizontal scrollbar Step 4.) is of course discussable. It should be easy to experiment with it (see code comments). Please tell me what you think about it, so that we can solve this annoying issue soon. Frank -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User schaefer.frank@gmx.net added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c19 --- Comment #19 from Frank Schäfer 2009-02-11 10:10:35 MST --- Created an attachment (id=271962) --> (https://bugzilla.novell.com/attachment.cgi?id=271962) Patch for column width optimization V2 Here is an improved version of the patch. This one works really great, because the column widths are now optimized on window resize, too ! I also fixed the issue reported by Marian. The optimization process/strategy is still the same as in the first patch, but I had to split the function into 2 and the sized-to-contents widths are no saved as global data members (=> improved performance on window resize events). Stefan, what do you think about it ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 Thomas Göttlicher changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sh@novell.com |tgoettlicher@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=441828 User tgoettlicher@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=441828#c21 Thomas Göttlicher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kvas11@seznam.cz --- Comment #21 from Thomas Göttlicher 2009-02-24 06:55:06 MST --- *** Bug 469919 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=469919 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.