http://bugzilla.novell.com/show_bug.cgi?id=533398 Summary: a2ps-4.13-1327.63: return value from fopen not used Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package a2ps-4.13-1327.63 For source code file a2ps-4.13/src/main.c around line 560 is the source code for the member function spy_user. I notice the following lines of code fclose (spy); fopen (spyname, "r"); Note the return value from fopen is not used. This is mystery code. The code appears to assume that an fclose and then an fopen will return the same FILE *pointer. Probably true by fluke, but I wouldn't rely on this in production code. Suggest new code fclose (spy); spy = fopen (spyname, "r"); -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.