[Bug 212696] New: ipw3945 cannot unload on suspend
https://bugzilla.novell.com/show_bug.cgi?id=212696 Summary: ipw3945 cannot unload on suspend Product: openSUSE 10.2 Version: Alpha 5 Platform: i686 OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Mobile Devices AssignedTo: behlert@novell.com ReportedBy: rml@novell.com QAContact: qa@suse.de CC: hmacht@novell.com, seife@novell.com The ipw3945 driver is not part of the default module unload-on-suspend list. But, because of the ipw3945d regulatory daemon, the way we unload modules with rmmod(8) fails for the ipw3945 because the ipw3945d daemon is only killed when `modprobe -r` is used. Since the daemon is not killed, the module retains a nonzero reference count and is not removable. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 seife@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|behlert@novell.com |seife@novell.com Status|NEW |ASSIGNED ------- Comment #1 from seife@novell.com 2006-10-17 02:07 MST ------- Just out of curiosity: did you check if it actually helps? The rmmod is in /usr/lib/powersave/scripts/sleep_helper_functions -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #2 from rml@novell.com 2006-10-17 06:20 MST ------- Just tried it. Oddly, it did not work. In suspend2ram.log I still see "could not unload module ipw3945, usage count was 1". The other modules successfully unloaded with `modprobe -r` so it did not hurt anything else. I can run `modprobe -r` from the command line anytime, and ipw3945 unloads successfully. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #3 from seife@novell.com 2006-10-17 09:53 MST ------- Yes. There's a bug in the logic. If the usage count is != 0, we do not even try to unload the module :-( I'll think about that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #4 from seife@novell.com 2006-10-17 09:55 MST ------- Created an attachment (id=101724) --> (https://bugzilla.novell.com/attachment.cgi?id=101724&action=view) diff against /usr/lib/powersave/scripts/sleep_helper_functions Try this. Maybe just apply manually, it is just removing the "if count = 0" check and tries modprobe -r regardless of the count, if the module has no known users anymore. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #5 from rml@novell.com 2006-10-17 11:54 MST ------- That worked! ipw3945 was unloaded correctly; on resume everything Just Worked. We will need this patch, of course, and also to add ipw3945 to the list of default modules to remove on suspend to RAM/disk. Danke, seife. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #6 from seife@novell.com 2006-10-17 12:24 MST ------- Ok, committed to svn, will find its way into packages once Holger does a new code drop. I did not yet add ipw3945 to the List, since we will start beta1 again with an empty list and it is in fact a kernel bug, not a powersave/pm-utils bug, which should be fixed instead of worked around. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #7 from rml@novell.com 2006-10-17 12:27 MST ------- Ah, I did not know that we were going to clear the list. Good idea. The ipw3945 actually works for me sometimes, but not others, on resume without this change. But it is inconsistent. Sometimes I need to reload the module, sometimes not. Anyhow, thanks again. Holger: Please submit a new package in time for beta 1 ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #8 from behlert@novell.com 2006-10-18 06:44 MST ------- Robert: We clear the list regularly at the beginning of a beta-phase to ensure that the list only contains required modules. In an ideal world all modules support suspend :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #9 from rml@novell.com 2006-10-25 18:35 MST ------- Holger checked this into STABLE and it is in beta 1 and works great (once you add ipw3945 to the reload list, natch). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 seife@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #10 from seife@novell.com 2006-11-06 12:51 MST ------- Both powersave and pm-utils are using "modprobe -r" now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 ------- Comment #11 from seife@novell.com 2007-01-10 10:22 MST ------- i backported this fix to SLES10SP1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212696 behlert@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com