[Bug 848070] New: No rcopenvpn
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c0 Summary: No rcopenvpn Classification: openSUSE Product: openSUSE 13.1 Version: RC 1 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Network AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: mhrusecky@suse.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- openvpn package is missing rcopenvpn script to handle start/stop. In 12.3 I was able to use openvpn by running: rcopenvpn start rcopenvpn stop rcopenvpn wrapper is not present anymore in 13.1 Apart from that calling systemctl start openvpn.target does not start my VPNs and I have to start them manually one by one. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-beta@cboltz.de AssignedTo|bnc-team-screening@forge.pr |mt@suse.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c1 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |mhrusecky@suse.com --- Comment #1 from Marius Tomaschewski <mt@suse.com> 2013-11-05 07:51:37 UTC --- (In reply to comment #0)
openvpn package is missing rcopenvpn script to handle start/stop.
In 12.3 I was able to use openvpn by running:
rcopenvpn start rcopenvpn stop
rcopenvpn wrapper is not present anymore in 13.1
This is not a bug. There is no init script any more, openvpn is started directly from a native template service file.
Apart from that calling
systemctl start openvpn.target
does not start my VPNs and I have to start them manually one by one.
What does a "ls -l /etc/systemd/system/openvpn.target.wants/" say? You have to enable the autostart of the instance(s) first: systemctl enable [--force] openvpn@foo.service systemctl enable [--force] openvpn@bar.service this causes to create openvpn@foo.service and openvpn@bar.service links in /etc/systemd/system/openvpn.target.wants/ pointing to the /usr/lib/systemd/system/openvpn@.service template file. Does it solve the openvpn.target issue? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c2 Michal Hrusecky <mhrusecky@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|mhrusecky@suse.com | --- Comment #2 from Michal Hrusecky <mhrusecky@suse.com> 2013-11-06 08:29:26 UTC --- (In reply to comment #1)
(In reply to comment #0)
openvpn package is missing rcopenvpn script to handle start/stop.
In 12.3 I was able to use openvpn by running:
rcopenvpn start rcopenvpn stop
rcopenvpn wrapper is not present anymore in 13.1
This is not a bug. There is no init script any more, openvpn is started directly from a native template service file.
rc scripts are not tied to init scripts. We even have a nice wrapper for simple services (see rcSuSEfirewall2 or rcnscd). But I can imagine that for backward compatibility openVPN one can be little more specific - like making sure that when I run rcopenvpn start, all my configured VPNs comes to live like in 12.3.
Apart from that calling
systemctl start openvpn.target
does not start my VPNs and I have to start them manually one by one.
What does a "ls -l /etc/systemd/system/openvpn.target.wants/" say?
You have to enable the autostart of the instance(s) first:
systemctl enable [--force] openvpn@foo.service systemctl enable [--force] openvpn@bar.service
this causes to create openvpn@foo.service and openvpn@bar.service links in /etc/systemd/system/openvpn.target.wants/ pointing to the /usr/lib/systemd/system/openvpn@.service template file.
Does it solve the openvpn.target issue?
Ok, it did, so misconfiguration (or too many expectations?) on my part. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c3 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #3 from Marius Tomaschewski <mt@suse.com> 2013-11-07 11:33:42 UTC --- too many expectations :-) You're right, that rcopenvpn is not tied to init scripts, but it comes from there. Openvpn changed to use systemd's native configuration and the suse specific "rcopenvpn" shortcut is gone too. When you want it back, write a script and make a submit request. You may want to use the "service" wrapper, which may be more general. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c4 --- Comment #4 from Marius Tomaschewski <mt@suse.com> 2013-12-17 13:55:09 UTC --- Created an attachment (id=572142) --> (http://bugzilla.novell.com/attachment.cgi?id=572142) untested rcopenvpn wrapper draft Please note: I'll not accept script like: https://build.opensuse.org/request/show/207448 https://build.opensuse.org/request/show/211223 When you _really_ want to add one, use systemctl commands only in it -- no own links / state ... I still think we should not readd rcopenvpn -- we're using systemd mechanizms now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #572142|application/octet-stream |text/plain mime type| | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c5 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #572142|0 |1 is obsolete| | --- Comment #5 from Marius Tomaschewski <mt@suse.com> 2013-12-17 13:58:16 UTC --- (From update of attachment 572142) Marking obsolete as we use systemctl mechamizms only instead. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c6 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.fent@suse.com --- Comment #6 from Marius Tomaschewski <mt@suse.com> 2013-12-17 14:32:38 UTC --- When you really want it back, please: a) create an own package as extension to the existing package b) discuss it in bugzilla -- after 07.01. [I've a time-off] But don't try to push not working scripts like in: https://build.opensuse.org/request/show/211229 again. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c7 Michal Hrusecky <mhrusecky@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID | --- Comment #7 from Michal Hrusecky <mhrusecky@suse.com> 2013-12-17 14:42:43 UTC --- (In reply to comment #4)
I still think we should not readd rcopenvpn -- we're using systemd mechanizms now.
Which is no excuse for deliberately breaking backward compatibility, see http://en.opensuse.org/openSUSE:Systemd_packaging_guidelines (In reply to comment #6)
When you really want it back, please:
a) create an own package as extension to the existing package
No, it should be part of the openvpn package, see packaging guidelines
b) discuss it in bugzilla -- after 07.01. [I've a time-off]
I did that, you told me in comment #3 "write a script and make a submit request" so I did so.
But don't try to push not working scripts like in: https://build.opensuse.org/request/show/211229
That script works, can you at least try it before dismissing it or point to some testcase you see failing? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mt@suse.com |stefan.fent@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c8 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mt@suse.com --- Comment #8 from Marius Tomaschewski <mt@suse.com> 2013-12-17 15:47:12 UTC --- (In reply to comment #7)
(In reply to comment #4)
I still think we should not readd rcopenvpn -- we're using systemd mechanizms now.
Which is no excuse for deliberately breaking backward compatibility, see
http://en.opensuse.org/openSUSE:Systemd_packaging_guidelines
AFAIR, the backward compatibility link as proposed there: ln -s /sbin/service %{buildroot}%{_sbindir}/rcname simply does not work properly in this case. But, well -- here is an shorter variant I'm about to add: https://build.opensuse.org/request/show/211242 Stefan, may you review when you find the time before I'm back on January 7th? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c9 --- Comment #9 from Michal Hrusecky <mhrusecky@suse.com> 2013-12-17 15:55:34 UTC --- (In reply to comment #8)
AFAIR, the backward compatibility link as proposed there:
ln -s /sbin/service %{buildroot}%{_sbindir}/rcname
simply does not work properly in this case.
That's why I proposed script I sent in sr#211229
But, well -- here is an shorter variant I'm about to add:
https://build.opensuse.org/request/show/211242
Stefan, may you review when you find the time before I'm back on January 7th?
Little review: a) Status doesn't really work For some reason regardless of openvpn.target status it just states unused, didn't tried to debug yet, but neat idea reusing old rc scripts. b) It changes default behaviour which was in openSUSE < 13.1 and SLE < 12 to start all VPNs that have .conf file in /etc/openvpn by default, which this new rcopenvpn doesn't. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c10 --- Comment #10 from Michal Hrusecky <mhrusecky@suse.com> 2013-12-18 08:34:59 UTC --- Ok, yet another review of your request sr#211245: a) Status is fixed and kinda works b) Still changes default behavior and doesn't auto-detect new .confs and controls only VPNs that are explicitly enabled before by hand. This is big usability and migration issue but I guess no convincing you to emulate old behavior which I did in script I sent in sr#211229 and you didn't even bothered to try -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c11 --- Comment #11 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-12-22 17:00:10 CET --- This is an autogenerated message for OBS integration: This bug (848070) was mentioned in https://build.opensuse.org/request/show/212028 Factory / openvpn -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c12 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #12 from Marius Tomaschewski <mt@suse.com> 2014-01-09 14:52:24 UTC --- fixed in factory -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|stefan.fent@suse.com |mt@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c13 Michal Hrusecky <mhrusecky@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #13 from Michal Hrusecky <mhrusecky@suse.com> 2014-01-14 07:11:34 UTC --- Tested what landed in Factory and my comment still applies - it confusingly changes default and expected behavior of rcopenvpn. When you call rcopenvpn start it starts only vpns you previously enabled via systemctl. As I commented before, so far the default behavior was to start all I have configuration for. So this change in defaults will greatly confuse users. As I showed, I have script that keeps the expected behavior which was rashly declined for invalid reasons, but I can resubmit it... PS: If you prefer, we can close this bug and I open separate one for behavior change, but as all relevant information was already here, I just reopened this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c14 Marius Tomaschewski <mt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #14 from Marius Tomaschewski <mt@suse.com> 2014-01-14 10:32:40 UTC --- (In reply to comment #13)
Tested what landed in Factory and my comment still applies - it confusingly changes default and expected behavior of rcopenvpn. When you call rcopenvpn start it starts only vpns you previously enabled via systemctl. As I commented before, so far the default behavior was to start all I have configuration for.
Wrong. There was a OPENVPN_AUTOSTART sysconfig variable before, that contains the list of configs to handle. This variable (when set, otherwise all configs) is migrated in %post to "systemctl enable" at install time, which is the way to use per-tunnel/config enable under systemd now. The rcopenvpn is a compatibility wrapper, not more. When you don't want to use "systemctl enable openvpn@foo", you can use "rcopenvpn enable foo" now. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c15 --- Comment #15 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-01-14 12:00:13 CET --- This is an autogenerated message for OBS integration: This bug (848070) was mentioned in https://build.opensuse.org/request/show/213853 Factory / openvpn -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=848070 https://bugzilla.novell.com/show_bug.cgi?id=848070#c16 --- Comment #16 from Michal Hrusecky <mhrusecky@suse.com> 2014-01-31 09:51:54 UTC --- Wrong. Partially :-) Well, Ok, I give you that I overlooked the %post part as I have 13.1 and therefore I don't have sysconfig anymore. And I'm glad that you solved at least migration from already set up system aka SLE11 or openSUSE 12.3. But this still doesn't address the issue with confusing behavior for people migrating. It migrates your existing setup. You add new config file, run rcopenvpn restart and expect your newly setup VPN to start. It doesn't. You start hunting down what went wrong with openvpn and what is wrong with your config. And it will take a while to figure out that rcopenvpn is not starting everything as it used to. I know about sysconfig variable *NOW*, but I doubt that many people use it. You solved the main bug, I don't like the final solution as it is really confusing for our current users, so I can fill usability bug, but from whole this bug and your willingness to accept patches/help I have a feeling you are not going to solve it anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com