[Bug 856501] New: mc dataloss: moving a file and skipping upon problem deletes original file
https://bugzilla.novell.com/show_bug.cgi?id=856501 https://bugzilla.novell.com/show_bug.cgi?id=856501#c0 Summary: mc dataloss: moving a file and skipping upon problem deletes original file Classification: openSUSE Product: openSUSE 13.1 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Critical Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: richlv@nakts.net QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Opera/9.80 (X11; Linux x86_64) Presto/2.12.388 Version/12.15 in midnight commander, move a file to some location that causes a problem (for example, unable to chown it on the other side over ssh/shell link). when mc complains, choose 'skip'. target file is not closed, but original file is still deleted. Reproducible: Always -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=856501 https://bugzilla.novell.com/show_bug.cgi?id=856501#c1 --- Comment #1 from Rihards Olups <richlv@nakts.net> 2013-12-20 12:32:59 UTC --- upstream report : http://www.midnight-commander.org/ticket/3128 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=856501 https://bugzilla.novell.com/show_bug.cgi?id=856501#c zhang jiajun <jzhang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzhang@suse.com AssignedTo|bnc-team-screening@forge.pr |david@dhaller.de |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=856501 https://bugzilla.novell.com/show_bug.cgi?id=856501#c2 --- Comment #2 from Rihards Olups <richlv@nakts.net> 2013-12-23 17:29:15 UTC --- to clarify, this seems to happen when ssh file upload fails because of a permission error in the target directory. mc seems to miss it and thinks file has been uploaded - and deletes the original file to be moved -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=856501 https://bugzilla.novell.com/show_bug.cgi?id=856501#c3 David Haller <david@dhaller.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |UPSTREAM --- Comment #3 from David Haller <david@dhaller.de> 2013-12-23 19:47:43 CET --- Please report/keep bugging upstream. I can't even connect to localhost via mc-sshfs with mc anyway ;) I'll try to look into it anyway as much as I can (but got more on my plate and don't know that code). Preliminarily closing as "upstream" (and I'll follow that upstream ticket and integrate any upstream-patches ASAP!). PS: please state versions when you report (I found them upstream, so it's ok) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=856501 https://bugzilla.novell.com/show_bug.cgi?id=856501#c4 --- Comment #4 from Bernhard Wiedemann <bwiedemann@suse.com> 2014-03-16 06:00:10 CET --- This is an autogenerated message for OBS integration: This bug (856501) was mentioned in https://build.opensuse.org/request/show/226282 Factory / mc -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |obs:running:3308:low -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 --- Comment #5 from Swamp Workflow Management <swamp@suse.de> --- openSUSE-RU-2014:1661-1: An update that has three recommended fixes can now be installed. Category: recommended (low) Bug References: 824729,849082,856501 CVE References: Sources used: openSUSE 13.2 (src): mc-4.8.13-4.1 openSUSE 13.1 (src): mc-4.8.13-2.9.1 openSUSE 12.3 (src): mc-4.8.13-2.4.1 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 Srinidhi B S <srinidhi@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srinidhi@novell.com --- Comment #6 from Srinidhi B S <srinidhi@novell.com> --- I understand this bug completely and for a very long time, refrained from moving files when using network vfs - ssh, ftp or smb. Disabling SSH / fish completely because one action of "move" can cause problems is a bit extreme, IMO. Fish is still useful for other actions. Instead of disabling file "move" functionality, we've disabled entire fish! I can (and I am going to) build my own mc package with fish enabled, but I'm not sure if every other openSUSE user can do the same! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 --- Comment #7 from David Haller <dnh@opensuse.org> --- (In reply to Srinidhi B from comment #6) Disabling SSH / fish completely because one action of "move" can cause
problems is a bit extreme, IMO. Fish is still useful for other actions. Instead of disabling file "move" functionality, we've disabled entire fish!
"Just" disabling "move" is not as easy as you might think. I did have a look at the code and just gave up. Have you ever looked at mc's "fish" code? I'd welcome any patches! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 --- Comment #8 from Srinidhi B S <srinidhi@novell.com> --- (In reply to David Haller from comment #7)
(In reply to Srinidhi B from comment #6) Disabling SSH / fish completely because one action of "move" can cause
problems is a bit extreme, IMO. Fish is still useful for other actions. Instead of disabling file "move" functionality, we've disabled entire fish!
"Just" disabling "move" is not as easy as you might think. I did have a look at the code and just gave up.
I do understand that it isn't easy and may not be the Right Thing To Do. I didn't mean to suggest that it should be done this way - I just wanted to convey that some other less drastic options could have been looked at rather than completely removing fish / SSH functionality. Please understand that I've been using mc for almost 11 yrs now and have relied upon SSH/FTP functionality extensively. When I suddenly found this missing in openSUSE 13.2 - especially, when I needed it very badly - it annoyed me a little. Unfortunately, some of that annoyance came out in my previous comment. My apologies!! I really appreciate all your efforts in maintaining my favorite file manager in openSUSE.
Have you ever looked at mc's "fish" code? I'd welcome any patches!
I was expecting this response and I was planning to look at it. But I'm not confident if I'll be able to come up with any decent patch(es)! :) But today, I tried to reproduce this issue on my local build of mc where I've enabled fish using the steps mentioned in upstream bug / ticket, but wasn't able to reproduce the issue. Looks like "mc-vfs-fish-deleted_source_file.patch" does prevent the deletion of the source file. But one side-effect of this patch is that you get disconnected from remote SSH server! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 Steffen Sledz <sledz@zone42.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sledz@zone42.org -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|obs:running:3308:low | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=856501 David Haller <dnh@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Critical |Minor --- Comment #9 from David Haller <dnh@opensuse.org> --- (In reply to Srinidhi B S from comment #8)
I didn't mean to suggest that it should be done this way - I just wanted to convey that some other less drastic options could have been looked at rather than completely removing fish / SSH functionality.
That's what I did. But after hours, I gave up. And sftp is working just fine.
But today, I tried to reproduce this issue on my local build of mc where I've enabled fish using the steps mentioned in upstream bug / ticket, but wasn't able to reproduce the issue. Looks like "mc-vfs-fish-deleted_source_file.patch" does prevent the deletion of the source file. But one side-effect of this patch is that you get disconnected from remote SSH server!
Hm. That's good to hear. Well, you have a head start with that patch, pointing you to where stuff is done, I for one think that fish is broken by design and am not willing to spend much more time on that code. But I will spend time assessing and testing patches disabling only or fixing the "move" action. In that case, I'd be glad if you reopen this bug. Else, go bugger upstream ;) -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com