[Bug 1121208] New: GCC 9: grub2 build fails
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 Bug ID: 1121208 Summary: GCC 9: grub2 build fails Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: martin.liska@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- [ 77s] ../grub-core/fs/jfs.c: In function 'getblk': [ 77s] ../grub-core/fs/jfs.c:300:32: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 300 | if (!grub_disk_read (data->disk, [ 77s] | ~~~~^~~~~~ [ 77s] ../grub-core/fs/jfs.c: In function 'grub_jfs_read_inode': [ 77s] ../grub-core/fs/jfs.c:339:27: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 339 | if (grub_disk_read (data->disk, [ 77s] | ~~~~^~~~~~ [ 77s] ../grub-core/fs/jfs.c:351:27: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 351 | if (grub_disk_read (data->disk, inoblk, 0, [ 77s] | ~~~~^~~~~~ [ 77s] ../grub-core/fs/jfs.c: In function 'grub_jfs_mount': [ 77s] ../grub-core/fs/jfs.c:393:27: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 393 | if (grub_disk_read (data->disk, GRUB_JFS_FS1_INODE_BLK, 0, [ 77s] | ~~~~^~~~~~ [ 77s] ../grub-core/fs/jfs.c: In function 'grub_jfs_opendir': [ 77s] ../grub-core/fs/jfs.c:467:31: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 467 | if (grub_disk_read (data->disk, blk, 0, [ 77s] | ~~~~^~~~~~ [ 77s] ../grub-core/fs/jfs.c: In function 'grub_jfs_getent': [ 77s] ../grub-core/fs/jfs.c:535:37: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 535 | if (grub_disk_read (diro->data->disk, next, 0, [ 77s] | ~~~~~~~~~~^~~~~~ [ 77s] ../grub-core/fs/jfs.c:557:44: error: taking address of packed member of 'struct grub_jfs_leaf_dirent' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 557 | le_to_cpu16_copy (filename + strpos, leaf->namepart, len < diro->data->namecomponentlen ? len [ 77s] | ~~~~^~~~~~~~~~ [ 77s] ../grub-core/fs/jfs.c:570:48: error: taking address of packed member of 'struct grub_jfs_leaf_next_dirent' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 570 | le_to_cpu16_copy (filename + strpos, next_leaf->namepart, len < 15 ? len : 15); [ 77s] | ~~~~~~~~~^~~~~~~~~~ [ 77s] ../grub-core/fs/jfs.c: In function 'grub_jfs_read_file': [ 77s] ../grub-core/fs/jfs.c:629:27: error: taking address of packed member of 'struct grub_jfs_data' may result in an unaligned pointer value [-Werror=address-of-packed-member] [ 77s] 629 | grub_disk_read (data->disk, [ 77s] | ~~~~^~~~~~ [ 77s] cc1: all warnings being treated as errors and similar errors with -Werror=address-of-packed-member -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 Martin Liška <martin.liska@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1120754 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c1 Martin Liška <martin.liska@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arvidjaar@gmail.com, | |mchang@suse.com --- Comment #1 from Martin Liška <martin.liska@suse.com> --- I can't create upstream bug, can you please take a look? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c2 Martin Liška <martin.liska@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rw@suse.com --- Comment #2 from Martin Liška <martin.liska@suse.com> --- May I please ping this? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c3 --- Comment #3 from Michael Chang <mchang@suse.com> --- (In reply to Martin Liška from comment #2)
May I please ping this?
I'm working on it, and the x86 seems to work fine now. obs://home:michael-chang:branches:devel:gcc/grub2 Is it possible to test the result on other architecture (arm, powerpc and s390x) ? Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c4 --- Comment #4 from Martin Liška <martin.liska@suse.com> --- (In reply to Michael Chang from comment #3)
(In reply to Martin Liška from comment #2)
May I please ping this?
I'm working on it, and the x86 seems to work fine now.
obs://home:michael-chang:branches:devel:gcc/grub2
Thanks for working on that.
Is it possible to test the result on other architecture (arm, powerpc and s390x) ?
Well, you would have to branch gcc9 and gcc package. But the warnings are in generic code. That said I would make a submit request for now. Are you planning to upstream the changes?
Thanks.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c7 --- Comment #7 from Martin Liška <martin.liska@suse.com> --- Sorry for delay, but I tested that for you: https://build.opensuse.org/project/show/home:marxin:test-grub armv7l looks failing here: https://build.opensuse.org/package/live_build_log/home:marxin:test-grub/grub... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c8 --- Comment #8 from Michael Chang <mchang@suse.com> --- Hi Martin, I was trying to test a new patch but the armv7l repo became unresolvable with the follow reasoning. :(
missing pre/vminstalls: kernel-obs-build
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c9 --- Comment #9 from Martin Liška <martin.liska@suse.com> --- (In reply to Michael Chang from comment #8)
Hi Martin,
I was trying to test a new patch but the armv7l repo became unresolvable with the follow reasoning. :(
missing pre/vminstalls: kernel-obs-build
I see, I will test it for you, give me some time for gcc9 package build. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c10 --- Comment #10 from Martin Liška <martin.liska@suse.com> --- It's green on ARM 32: https://build.opensuse.org/package/live_build_log/home:marxin:test-grub/grub... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c11 --- Comment #11 from Martin Liška <martin.liska@suse.com> --- @Michael: What's progress on this please? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c12 --- Comment #12 from Martin Liška <martin.liska@suse.com> --- @Michael: What's progress on this please? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c13 --- Comment #13 from Michael Chang <mchang@suse.com> --- I posted v2 patch to upstream and is waiting for feedback. http://lists.gnu.org/archive/html/grub-devel/2019-04/msg00053.html -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c14 --- Comment #14 from Martin Liška <martin.liska@suse.com> --- (In reply to Michael Chang from comment #13)
I posted v2 patch to upstream and is waiting for feedback.
http://lists.gnu.org/archive/html/grub-devel/2019-04/msg00053.html
Ok, thank you for working on that. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1121208 http://bugzilla.opensuse.org/show_bug.cgi?id=1121208#c15 --- Comment #15 from Martin Liška <martin.liska@suse.com> --- @Michael: Looks all patches are install in git master. Do we have the patches in our OBS devel project? -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com