[Bug 528583] New: novel-pinyin-0.2.4-1.9: two file handling problems
http://bugzilla.novell.com/show_bug.cgi?id=528583 Summary: novel-pinyin-0.2.4-1.9: two file handling problems Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package novel-pinyin-0.2.4-1.9 For source code file novel-pinyin-0.2.4/utils/storage/gen_pinyin_table.cpp around line 210 is the source code for the function gen_phrase_file. I notice the following line of code FILE * outfile = fopen(outfilename, "w"); I can find two problems. 1. No check that the fopen succeeded. 2. No matching call to fclose. Suggest code rework, -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=528583
Marcus Meissner
http://bugzilla.novell.com/show_bug.cgi?id=528583
User pwu@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=528583#c1
--- Comment #1 from Peng Wu
http://bugzilla.novell.com/show_bug.cgi?id=528583
User dcb314@hotmail.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=528583#c2
--- Comment #2 from David Binderman
Thanks very much for the bug report. Sorry for replying lately, I am very busy recently.
No problem - glad the problem is fixed.
This fix is submitted to novel-pinyin.cvs.sf.net. As all tools under utils and tests are used mainly by developer, I don't plan to release a new version for this fix now. Is this OK?
Fine by me - I hope the fix will appear in the next version of openSuse, due November 2009. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=528583
User pwu@novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=528583#c3
Peng Wu
Fine by me - I hope the fix will appear in the next version of openSuse, due November 2009.
Accepted in openSUSE:Factory, closing bug. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com